Release MQ2AutoLoot

[Sum1]

I’m seeing some consistent odd behavior.

The plugin is somehow thinking that a TS material is lore and in parcels, which it is not (neither lore, nor in parcels). It refuses to loot or hand out the item until something else is on the adv loot window ... at which point the main looter grabs everything, per usual.

 

[Hylander]

@plure

Yes only 1 loot.ini (the common shared one). I've done two things
1. My RNG was Group Leader and ML. I made Character #2 WIZ the ML. The WIZ is now is doing all the loot activities
2. I un-equipped the Cliff Stone on my WAR

I have not been successful in seeing the Cliff Stone being distributed as yet and the associated advloot window behavour , but I've seen this entry in the Loot Log

[2019/09/09 15:01:42] WIZ :: PList: looting Primordial Dynastic Radiance
[2019/09/09 15:09:27] WAR :: PList: looting Cliff Stone
[2019/09/09 15:12:42] WIZ :: SList: looting Piece of Molten Metal

There is no pre-amble like previously where it was attempting to distribute ... just that single line.

I will try and narrow it down further by equipping a cliff stone and see if the WAR continues to loot or not

Thanks

Hylander

 

[plure]

I’m seeing some consistent odd behavior.

The plugin is somehow thinking that a TS material is lore and in parcels, which it is not (neither lore, nor in parcels). It refuses to loot or hand out the item until something else is on the adv loot window ... at which point the main looter grabs everything, per usual.

I think I have found where that is being caused in the code. We have a major upgrade at work coming up over the next couple weeks, but after that I should be able to get this bug ironed out.

 

[Sum1]

I think I have found where that is being caused in the code. We have a major upgrade at work coming up over the next couple weeks, but after that I should be able to get this bug ironed out.

It's just annoying right now.... it's not REALLY adversely affecting anything.

 

[kaen01]

I'd like to see an autoloot feature to loot if:

Stackable >= 20
Item Plat Value > 10 etc

For broad coverage.

this 100%

 

[drawthow]

Is there any default settings to disable autoloot on a named mob? I keep forgetting to turn off autoloot when pulling the names. I think my wife my divorce me in I loot one more thing I can't use.

 

[plure]

Is there any default settings to disable autoloot on a named mob? I keep forgetting to turn off autoloot when pulling the names. I think my wife my divorce me in I loot one more thing I can't use.

There is currently no way to turn it off when a named mob is being killed.

 

[bb4]

Autoloot is messed up on Test again. It is struggling to pass out loot and the non ML toons are constantly toggling no like I reported a few months ago.

 

[plure]

Autoloot is messed up on Test again. It is struggling to pass out loot and the non ML toons are constantly toggling no like I reported a few months ago.

eqmule updated the advloot/lootitem struct, re-download and let us know if it is still causing you issues

 

[Randyleo]

I'm getting these errors when it tries to loot.




MQ2Autoloot loaded, LootOn=0,

[KissError]
LastCMD:=/if (!37) {
ErrorDateTime:=10/11/2019 23:24:15
ErrorMsg:=Woah! hold your horses there little filly... You better add a !TRUE check in your macro to make sure loot is not in progress.
DataError:=NULL
SyntaxError:=NULL
RunningTime:=5770586
BuildDate:=20191011
CurrentUI:=Default

 

[plure]

I'm getting these errors when it tries to loot.

View attachment 17995


MQ2Autoloot loaded, LootOn=0,

[KissError]
LastCMD:=/if (!37) {
ErrorDateTime:=10/11/2019 23:24:15
ErrorMsg:=Woah! hold your horses there little filly... You better add a !TRUE check in your macro to make sure loot is not in progress.
DataError:=NULL
SyntaxError:=NULL
RunningTime:=5770586
BuildDate:=20191011
CurrentUI:=Default

That looks like a bag struct. Are you on test? If so please update to the latest version.

Also your also running ninjadvloot.inc and mq2autoloot... it isn't necessary to run both. Though that won't cause this issue

 

[Randyleo]

Yes I am on Test. If I am using ninjadvloot I don't know how it got started. I just ran updater for test and it says I am up to date. Where would I go to download the newest dll? The download button at the upper right actually says go to download.

 

[Mikey02]

Is there any default settings to disable autoloot on a named mob? I keep forgetting to turn off autoloot when pulling the names. I think my wife my divorce me in I loot one more thing I can't use.

If you use kissassist, you can put in a /autoloot turn off command in burn section.

 

[drawthow]

Mikey02 Thank you very much!!!!!!

 

[bb4]

eqmule updated the advloot/lootitem struct, re-download and let us know if it is still causing you issues

Still causing issues.

 

[Randyleo]

It looks like it is defaulting to use Ninjadvloot for looting. I wiped out my MQ directory and reinstalled it. Rebuilt all new ini's and it is still not wanting to loot unless I give it to a character.

 

[bb4]

Issues I'm seeing currently:
I loaded Autoloot on the Leader/ML and the first toon to join the group.
ML is passing loot to 1st Toon instead of looting. ML has a ton of bag space.
1st Toon is spamming No on and off like the issue a months ago.

 

[plure]

Issues I'm seeing currently:
I loaded Autoloot on the Leader/ML and the first toon to join the group.
ML is passing loot to 1st Toon instead of looting. ML has a ton of bag space.
1st Toon is spamming No on and off like the issue a months ago.

Was it working before the last patch?

From the screen shots randyleo has shown it appears something is wrong with the struct. I am not able to fix issues with regards to the structs, only eqmule can do that.

 

[Randyleo]

Before the last patch it was working.

 

[plure]

Can either of you just confirm the build date you are using?

/echo ${MacroQuest.BuildDate}

 

[Randyleo]

20191011, just a reminder, this is on Test.

 

[plure]

@eqmule It appears the struct for LOOTITEM struct might be off on the latest test build.

 

[bb4]

I'm on the same build on Test.

 

[bb4]

Another weird behavior. Depositing items to Guild Bank and the permissions setting is Public. It is changing things from Public to View Only.

 

[plure]

Another weird behavior. Depositing items to Guild Bank and the permissions setting is Public. It is changing things from Public to View Only.

I'll look into this next week.

 

[bb4]

I'll look into this next week.

Awesome. Let me know if I can help in any way.

 

[Redbot]

Redbot updated MQ2AutoLoot with a new update entry:

small loot distribution bug fixed

@plure Fixed a bug when distributing loot and no one wanted the item, it would screw up the next item to be looted.

Read the rest of this update entry...

 

[Randyleo]

Was this updated for Test also?

 

[Randyleo]

Still not looting on Test. Oh well.

 

[bb4]

Do we have any ETA on the fix for Test?

 

[plure]

@eqmule @Redbot

It doesn't appear there is a problem on live for looting, any idea why test is still not working?

 

[Redbot]

test fix will come out with next patch (tomorrow or thursday)

 

[Randyleo]

Thank you.

 

[Randyleo]

MQ2AutoLoot working on Test now.

 

[Gator]

I'm not sure if this is not possible or already been discussed or maybe even part of the plugin already but it would be cool if there was a "learn" mode where you can switch it on (and off) and do your selling/bartering/ect manually and have those actions reflected in the Ini. VS editing the Ini.

So potentially you would already have some settings, then you go to a new zone and get new phat lewtz. You go to a zone with a vender and do your buy/sell/barter but still have some items left over. Swap "learn" on and finish with the new stuff, swap "learn" off and the new zone is now configured.

 

[Jetanroth]

Whenever I try to load MQ2AutoLoot it crashes MQ2Main and the instance crashes. Any ideas why this might be happening?

 

[plure]

Whenever I try to load MQ2AutoLoot it crashes MQ2Main and the instance crashes. Any ideas why this might be happening?

I'd redownload the latest version of VV.

 

[drawthow]

I have all the Rog only tradeskill items set to destroy but they never get deleted anyone know why?

Items like

Distilled Grade A Choresine Sample=Destroy
Distilled Grade A Gormar Venom=Destroy
Distilled Grade A Mamba Venom=Destroy
Distilled Grade A Nigriventer Venom=Destroy
Distilled Grade A Taipan Venom=Keep
Distilled Grade AA Choresine Sample=Keep
Distilled Grade AA Gormar Venom=Keep
Distilled Grade AA Nigriventer Venom=Keep
Distilled Grade B Choresine Sample=Keep
Distilled Grade B Gormar Venom=Destroy
Distilled Grade B Mamba Venom=Destroy
Distilled Grade B Nigriventer Venom=Destroy
Distilled Grade B Taipan Venom=Destroy
Distilled Grade C Choresine Sample=Destroy
Distilled Grade C Gormar Venom=Destroy
Distilled Grade C Mamba Venom=Destroy
Distilled Grade C Nigriventer Venom=Destroy
Distilled Grade C Taipan Venom=Destroy

 

[plure]

I have all the Rog only tradeskill items set to destroy but they never get deleted anyone know why?

Items like

Distilled Grade A Choresine Sample=Destroy
Distilled Grade A Gormar Venom=Destroy
Distilled Grade A Mamba Venom=Destroy
Distilled Grade A Nigriventer Venom=Destroy
Distilled Grade A Taipan Venom=Keep
Distilled Grade AA Choresine Sample=Keep
Distilled Grade AA Gormar Venom=Keep
Distilled Grade AA Nigriventer Venom=Keep
Distilled Grade B Choresine Sample=Keep
Distilled Grade B Gormar Venom=Destroy
Distilled Grade B Mamba Venom=Destroy
Distilled Grade B Nigriventer Venom=Destroy
Distilled Grade B Taipan Venom=Destroy
Distilled Grade C Choresine Sample=Destroy
Distilled Grade C Gormar Venom=Destroy
Distilled Grade C Mamba Venom=Destroy
Distilled Grade C Nigriventer Venom=Destroy
Distilled Grade C Taipan Venom=Destroy

They are left in the bags of your master looter?

 

[drawthow]

They are left in the bags of your master looter?

Yes. It almost seems like the same item from a different zone has a different ID. The program seems to delete them in the beginning but stops after some time later.