• You've discovered RedGuides, an EverQuest multi-boxing and scripting community 🧙‍♀️⚙️. We want you to play several EQ characters at once, come join us and say hello! 👋

  • A TLP without truebox has thawed (Very Vanilla ready)
    Frostreaver

Release Tradeskill Construction Set |Quests:GOD,TSS,POK,POR Freebie Assister [Deleted]

Status
Not open for further replies.
Everything ran great, just missing the Research.
Research Requirements Not Met: Skill 25, skipping Research
Never bought the Kit.
Guessing there is some requirement I overlooked.
 
Any negative reactions to adding this to around Line: 758 in TSC.mac to recognize the purchase of the hybrid kits?
and remove around Line: 228 /Call BuyKit "${kit_name}" 13
to avoid purchasing two.
not sure why it wont purchase here on first run, but will purchase 2 with the code below.

|dont buy one if skill over >= 50 .. and just do say text.. /if (${Me.Level} > 33) { /varset kit_name string local ${Macro.Return} /if (${Select[${Me.Class.ShortName},NEC,WIZ,MAG,ENC]}) { /varset kit_name Spell Research Kit /Call BuyKit "${kit_name}" 13 |Spell Research Kit } /if (${Select[${Me.Class.ShortName},CLR,DRU,SHM]}) { /varset kit_name Prayer Writing Kit /Call BuyKit "${kit_name}" 13 |Prayer Writing Kit } /if (${Select[${Me.Class.ShortName},BRD]}) { /varset kit_name Song Writing Kit /Call BuyKit "${kit_name}" 13 |Song Writing Kit } /if (${Select[${Me.Class.ShortName},PAL,RNG,SHD,BST]}) { /varset kit_name Hybrid Research Kit /Call BuyKit "${kit_name}" 13 |Hybrid Research Kit } /if (${Select[${Me.Class.ShortName},WAR,MNK,ROG,BER]}) { /varset kit_name Tome Binding Kit /Call BuyKit "${kit_name}" 13 |Tome Binding Kit }
 
Last edited:
Any negative reactions to adding this to Line: 758 in TSC.mac to recognize the purchase of the hybrid kits?

/varset kit_name string local ${Macro.Return} /if (${Select[${Me.Class.ShortName},NEC,WIZ,MAG,ENC]}) { /varset kit_name Spell Research Kit /Call BuyKit "${kit_name}" 13 |Spell Research Kit } /if (${Select[${Me.Class.ShortName},CLR,DRU,SHM]}) { /varset kit_name Prayer Writing Kit /Call BuyKit "${kit_name}" 13 |Prayer Writing Kit } /if (${Select[${Me.Class.ShortName},BRD]}) { /varset kit_name Song Writing Kit /Call BuyKit "${kit_name}" 13 |Song Writing Kit } /if (${Select[${Me.Class.ShortName},PAL,RNG,SHD,BST]}) { /varset kit_name Hybrid Research Kit /Call BuyKit "${kit_name}" 13 |Hybrid Research Kit } /if (${Select[${Me.Class.ShortName},WAR,MNK,ROG,BER]}) { /varset kit_name Tome Binding Kit /Call BuyKit "${kit_name}" 13 |Tome Binding Kit }


.. this is accomplished by line 723.. of TSC.mac

/if (${Me.Level} > 33) {
/call WhatKit
/varset kit_name string local ${Macro.Return}
/Call BuyKit "${kit_name}" 13
}
 
yes, but it don't work, he won't buy the hybrid kit.


/if (${Me.Level} > 33) {
/call WhatKit
/varset kit_name string local ${Macro.Return}

add
/echo ${Macro.Return}
/end

does it have a kit name?

/Call BuyKit "${kit_name}" 13

and ya need at least 13pp


}
 
Think this is the problem.

/varset kit_name ${Macro.Return}

instead of

/varset kit_name string local ${Macro.Return}
 
In both lines 453 and 727 ?

/varset kit_name ${Macro.Return}

instead of

/varset kit_name string local ${Macro.Return}

That was it.

Atleast I narrowed it down to it not pulling that data from the tss file. but it took me all night half the morning. haha such a noob!
 
cool, thanks for taking the time to explain that, i appreciate it.

left line 453 /declare kit_name string local ${Macro.Return}
changed the other to /declare kit_name ${Macro.Return}


on a side note, some asshat is standing right in my nav line to zone.
 
Last edited:
Um it has /declare in my macro lol

er /declare on 453 and /varset on 723 ish.

clarify what I changed
Line: 272 from /varset kit_name string local ${Macro.Return} to /varset kit_name ${Macro.Return}

I just seen above what you referred too.. haha yeah, that was wrong.
 
Last edited:
Nice, with that fix, back in the saddle again, once I test the others I will run a virgin toon through the whole process. lol
 
Have you done anymore on the POR_trophyquests.ini since you uploaded last?

Yes, and it works in conjunction with TSC_POR, which has also changed and is not ready for human consumption.

If the question is have I added more quests, then no , at this time..
 
Last edited:
Ok. Just ran the research
Ran great got the quest, went back to pok,
ran /mac tsc shop researchtrophy and bought the supplies (ended)
ran /mac tsc make researchtrophy and failed two of the combines (ended)
ran /mac tsc shop researchtrophy and bought all the supplies for the whole quest (ended)
ran /mac tsc make researchtrophy and finished making the two failed items
ran /mac tsc Beginner Research and that is what led me to ask that quest. LOL
 
Guess I will chill for a while on something else. If you need anything tested or anything I can do in the meantime, just holler.
 
Ok. Just ran the research
Ran great got the quest, went back to pok,
ran /mac tsc shop researchtrophy and bought the supplies (ended)
ran /mac tsc make researchtrophy and failed two of the combines (ended)
ran /mac tsc shop researchtrophy and bought all the supplies for the whole quest (ended)
ran /mac tsc make researchtrophy and finished making the two failed items
ran /mac tsc Beginner Research and that is what led me to ask that quest. LOL


but but but

have you tried

/mac tsc shopmakeskill researchtrophy
/mac tsc shopmake researchtrophy

and the rest of those looks like they are working as currently intended. shop is mass shopping.. So you can use it to do trophies but it is meant to make like 1000 picnic baskets or something like that..

Which is making me inch ever closer to make a shop that buys what you need based on how much you got.. the mass shop looks at eeerey recipe in the list and shops for it all.. it sounds like a better way to shop individually per recipe as needed..

The mass shopping accomplished the buying of 500 water flasks if the total of all the recipes was that.. This saved time from running back to the same vendor you just left to buy something again.. So all recipes were accounted for..

There is a lot of logic in the trophy making , buying, turning in, task updates.. which makes it so you buy what you need ..

if you do it without the logic you would be buying mats based on your inventory alone.. this would not work too well because it would ignore that you no longer need to make something because you have already met the task requirement. It would also shop, and make items you don't need because they are not a task update item ..

The example where single recipe buying and making would work, is if it is not a task, it would still adhere to the counts and not overbuy, or buy too much..

It would ignore mass buying and buy for each recipe and then make that recipe and then buy for the next recipe and go through the list of recipes.. we could also add a recipe loop so that it keeps doing it over and over until it reaches the amount with the least amount of waste..

Present Functionality:

1) Buys a crapton of mats and goes to town.. once

2) Buys what is needed based on task requirements.. and keeps at it..

proposed new option

3) Buys what is needed per recipe based on inventory or skill requirements and shops every recipe..

Note: would need to add in logic to look at the recipe before it buys it and parse the vendor list to determine what items can be bought, and then skip buying the recipe if there are farmed item you don't have.. so you don't waste money on a recipe you can't make because you don't have farmed leopard intestines..

GREAT for non-tasks or non-quests..
 
Last edited:
/mac tsc shopmakeskill researchtrophy
/mac tsc shopmake researchtrophy

I have tried those on the older version. For this version I was trying to take it one step at a time to see what was happening.

I don't believe shopmakeskill or shopmake went back a second time for inventory (as you propose above) just cut out the steps of typing /shop /make /skill. or /shop /make?

The mass shopping accomplished the buying of 500 water flasks if the total of all the recipes was that.. This saved time from running back to the same vendor you just left to buy something again.. So all recipes were accounted for..

I thought /mac tsc shop smithing (bought everything needed already for all of the requested itemtotals?

3) Buys what is needed per recipe based on inventory or skill requirements and shops every recipe..

This would be the ideal way to do it. If you wanted 50 dogs and 50 cats and you shopped for 50 dogs and 50 cats minus the ingredients you already have in your inventory, but were un successful in 10 dogs and 10 cats it would only buy the ingredients for 10 dogs and 10 cats minus the supplies you already have in inventory the next time you shopped. (that was even confusing to me) haha
 
I'm having a recurring problem with the beginning brewing trophy quest; Shopping list & item on the vendor list seems incomplete (downloaded 2 days ago). The result is that not everything is being purchased from the vendors in PoK, so quest items aren't being made, the macro is ending. This happens for Sylvan Berry Juice, Bottle of Kalish, Fizzle Pop, Honey Mead, & Lemonade.

EDIT: Nevermind, I'm not the sharpest tool in the shed. Turns out the missing items aren't buyable, at least not in PoK, and some of them are forage only. Don't mind me.

EDIT 2: Except for Lemonade. The /mac tsc shop brewingtrophy won't buy lemons from Chev Denrun; it doesn't list them on his item list, and there's no command to purchase them.
 
Last edited:
I'm having a recurring problem with the beginning brewing trophy quest; Shopping list & item on the vendor list seems incomplete (downloaded 2 days ago). The result is that not everything is being purchased from the vendors in PoK, so quest items aren't being made, the macro is ending. This happens for Sylvan Berry Juice, Bottle of Kalish, Fizzle Pop, Honey Mead, & Lemonade.

EDIT: Nevermind, I'm not the sharpest tool in the shed. Turns out the missing items aren't buyable, at least not in PoK, and some of them are forage only. Don't mind me.

EDIT 2: Except for Lemonade. The /mac tsc shop brewingtrophy won't buy lemons from Chev Denrun; it doesn't list them on his item list, and there's no command to purchase them.

TCS 3.0: Life will be much better.. wait for it..

That is part of the vendor list... which is being updated and included in the next release.. u can however add it to the vendor file if you choose...

[Vendor1]
VendorName=Chef Denrun
VendorItem1=Turnip
VendorItem2=Lettuce
VendorItem3=Carrot
VendorItem4=Bottle Of Milk
VendorItem5=Bear Meat
VendorItem6=Cheese
VendorItem7=Loaf Of Bread
VendorItem8=Spices
VendorItem9=Baking Spirits
VendorItem10=Garlic
VendorItem11=Jug Of Sauces
VendorItem12=Gator Meat
VendorItem13=Rennet
VendorItem14=Scaler Mold
VendorItem15=Celandine Herb
VendorItem16=Cup of Sugar
VendorItem17=Lemon
VendorItem18=Cup of Flour
VendorItem19=Mixing Bowl
VendorItem20=Spit
VendorItem21=Rat Meat
VendorItem22=Frosting
VendorItem23=Vinegar
VendorItem24=Free-Range Egg
VendorItem25=Mixing Bowl
VendorItems=25
 
Last edited:
EDIT 2: Except for Lemonade. The /mac tsc shop brewingtrophy won't buy lemons from Chev Denrun; it doesn't list them on his item list, and there's no command to purchase them.

Ya, he don't sell lemonade. haha This is probably the most updated vendor file there is at the moment.
Lemon is in there.
 

Attachments

Jb, if you want to list an excerpt of what a completed quest looks like in the POR_trophyquests.ini I could possibly do some of them. I assume your eventually doing all of the trophies, beginner, expert, ect. ..
 
Jb, if you want to list an excerpt of what a completed quest looks like in the POR_trophyquests.ini I could possibly do some of them. I assume your eventually doing all of the trophies, beginner, expert, ect. ..

Here's the template.. I can adjust as needed..

[Jewelry]
|name of turn in NPC
|QuestNPC=Judge Marion Teld`Mare
|Skill being used
SkillName=Jewelry Making
|Kit to use for GOD quest..
BagName=Jeweler's Kit
|data for GOD quest
DataUsed=Jewel_Data

[BeginnerJewelryTrophy]
|name of turn in NPC
QuestNPC=Judge Marion Teld`Mare
|tradeskill filename associated with the trophy..
TS_FileName=JewelryTrophy
|task name in alt-q
TaskName=Beginner Jeweler Test
|name of item to turn in to get trophy.
ScoreCardName=Beginner Jeweler Scorecard
Combines=0
|means no extra combines just make it and go..

|Storebought - 1 means ALL vendor bought for the recipe, 0 means you need to farm, forage, and prolly fight..
Recipe1SB=1
Recipe2SB=1
Recipe3SB=1
Recipe4SB=1
Recipe5SB=1
Recipe6SB=1
Recipe7SB=1
Recipe8SB=1
Recipe9SB=1
Recipe10SB=0

|Create Task Dependencies
|example Recipe1CTD=2 means it needs recipe 2 for recipe 1 to work..
|Recipe8CTD=3 needs recipe 3 to complete recipe 8.

Recipe1CTD=0
Recipe2CTD=0
Recipe3CTD=0
Recipe4CTD=0
Recipe5CTD=0
Recipe6CTD=0
Recipe7CTD=0
Recipe8CTD=0
Recipe9CTD=0
Recipe10CTD=0

|Step to Recipe (All steps for create tasks, and then delivery tasks as needed)
Step1=1
Step2=2
Step3=3
Step4=4
Step5=5
Step6=6
Step7=7
Step8=8
Step9=9
Step10=10
Step11=1
Step12=2
Step13=3
Step14=4
Step15=5
Step16=6
Step17=7
Step18=8
Step19=9
Step20=10

|Delivery Steps (The task step turn in ID)
Turn11Step=16672
Turn12Step=16680
Turn13Step=16688
Turn14Step=16696
Turn15Step=16704
Turn16Step=16712
Turn17Step=16720
Turn18Step=16728
Turn19Step=16736
Turn20Step=16744

|Override Buy Count - used only if you want to override a purchase count.
|Recipe10Override=1

if you are doing the recipes.. keep in mind that if it is for a quest the order of the recipes don't really matter.. it only matters if you were just running through a normal craft session and the 1st recipe needed to be made to make the 2nd recipe..

all that being said.. just keep in mind for task/quests it needs to match up in the 'step' section..
 
Last edited:
This item was dropped into range. When I did a wipeall smithingtrophy, ended up in loop at that item.
 

Attachments

  • Untitled.png
    Untitled.png
    24.5 KB · Views: 4
This item was dropped into range. When I did a wipeall smithingtrophy, ended up in loop at that item.

I knew/know there were kinks to work out with the sell and destroy routines.. I thought I had the range down.. guess not.. it pretty much uses the same to do turn ins for trophies/quests.. just something else to look at..
 
1606273099289.png

Mainly here for the bottom. it looks at a recipe and looks at available normal vendor items and spits out the farmed/foraged item needed. cool!
 
Open Question.. does anyone know how to stop lag buying.. more specifically putting in measures to stop over buying even with the right number..

file provided by from here: buy.inc
 
Last edited:
I can remember putting in delays when opening up vendors. Seems like especially the main vendors by all the trade skill stuff, as they fill up with sold items, the get really slow to populate.

/nomodkey /notify QuantityWnd QTYW_Accept_Button leftmouseup
/delay 5s !${Window[QuantityWnd].Open}
/doevents
 
I can remember putting in delays when opening up vendors. Seems like especially the main vendors by all the trade skill stuff, as they fill up with sold items, the get really slow to populate.

/nomodkey /notify QuantityWnd QTYW_Accept_Button leftmouseup
/delay 5s !${Window[QuantityWnd].Open}
/doevents

What's happening is it tries to buy and then keeps trying until it gets the right amount, but sometimes there is a blip and it doubles up..
 
think this is the area to focus on..

/nomodkey /shift /notify MerchantWnd MW_Buy_Button leftmouseup
/delay 1s
/doevents
/varset QTY ${Math.Calc[${amount}-${FindItemCount[=${ItemToBuy}]}]}
/delay 1s


of course this ain't mine it is buy.inc which is from the EQ Deities.. so I don't want to futz to much with it..
 
You could always modify it in your folder and see if it does the trick. It's really just a matter of how long you want to wait for the window to populate.
 

Attachments

Last edited:
jb321 updated Tradeskill Construction Set |Quests:GOD,TSS,POK,POR with a new update entry:

3.0! 11/25/2020 Gobble Gobble: The Big Cheese & Turkey Sandwich

3.0! 11/25/2020 Gobble Gobble: The Big Cheese & Turkey Sandwich

New Credits:

CannonballDex for testing and finding issues..

Big Dorf - quest journal routines!


Change List:

Command Changes:
/mac tsc gettrophy fletching (deprecated)

New Commands.. .. runs through from start to finish of crafting , buying, turn in for trophy quests!

/mac tsc beginner fletching (new)
/mac tsc beginner brewing (new)
/mac tsc beginner jewelry (new)
/mac tsc beginner pottery (new)

Others will be added as...

Read the rest of this update entry...
 
Release Tradeskill Construction Set |Quests:GOD,TSS,POK,POR Freebie Assister [Deleted]
Status
Not open for further replies.

Users who are viewing this thread

Back
Top
Cart