Question - newbie macro question

[Zat]

So i was trying to write my self a macro. I managed to get it so it would go around and kill everything at first but i tried to make it a little more advanced now it has multiple problems.

first off if the spell either fizzles or does not one shot the target i wanted it to recast the spell by setting the b = corpse
second and more frustrating i cant seem to figure out how to make Ninjadvloot to work at all. I cant seem to make the /lootkeep command work anywhere, any insight would be greatly appreciated.

    #include Ninjadvloot.inc
Sub Main(string MobName)
    /declare a int
    /for a 1 to ${SpawnCount[npc ${MobName}]}
    /declare b int
    /for b 2 to ${SpawnCount[npc ${MobName}]}
    :Start

/warp wp geo1
/delay 1s
/target g
    :Loop1
/cast 1
/delay 7s
/if (${Me.NearestSpawn[${b},npc ${MobName}].CleanName.NotEqual[${MobName}]}) /goto :Loop1
/if (${Me.NearestSpawn[${a},npc ${MobName}].CleanName.Equal[${MobName}]}) {
    /tar corpse
    /warp t
    /call LootMobs
}

 

[Maskoi]

Complete instructions for using ninjadvloot.inc are here.

http://forums.notaddicted.com/showthread.php?t=23202

You are missing the /call SetupAdvLootVars line that initializes ninjadvloot.inc

 

[Zat]

i accidentally left out the /call command in that one but i had it earlier. But i narrowed down the problem, its my /if commands what I'm trying to do is determine if my target is a corpse, if its not then loop back up, if it is continue and loot. the problem I was having is the macro seems to be just ignoring both of the /if commands all together

 

[Maskoi]

/if (${Target.Type.Equal[corpse]}) do some thing here
/if (${Spawn[npc ${MobName}].Type.Equal[corpse]}) so something here

 

[Zat]

oh man the first one worked great Maskoi thank you, guess ill share my macro now that it works properly

Prerequisites, goto crystal caverns set whichever nuke you want to use in your first spell slot.

its slow but safe and out of the way.

makes about 4k per 8 hours

version 3

        	#include Ninjadvloot.inc
Sub Main
:search
/target geonid
/if (${Target.CleanName.Equal[a geonid]}) /call Kill
/target collector
/if (${Target.CleanName.Equal[a gem collector]}) /call Kill
/tar focus
/if (${Target.CleanName.Equal[a focus gem]}) /call Kill
/delay 1s
/goto :search

/return

Sub Kill

:Kill
/warp t
/delay 1s
/cast 1
/delay 6s
/tar corpse
/if (${Target.Type.NotEqual[corpse]}) /goto :Kill
/call SetupAdvLootVars
/call LootMobs
/delay 1s
/hidecorpse all

/return

 

[Harleyrider]

You can optimize this a bit

/call SetupAdvLootVars only needs to be issued once in the mac, best to move it up between Sub Main and :search

You shouldn't need the /tar corpse command in there, the /call LootMobs will handle that

and the /hidecorpse all could be issued right after /call SetupAdvLootVars followed by a /hidecorpse looted

Since you're using a warping mac, and I'm assuming you're on a progression server because 4k in 8 hours is horrid on regular servers, you probably should use the AHTools.inc found on these forums to stall the mac in case someone zones in on ya.

#include Ninjadvloot.inc
Sub Main
/call SetupAdvLootVars
/hidecorpse all
/delay 1s
/hidecorpse looted

:search
/target geonid
/if (${Target.CleanName.Equal[a geonid]}) /call Kill
/target collector
/if (${Target.CleanName.Equal[a gem collector]}) /call Kill
/tar focus
/if (${Target.CleanName.Equal[a focus gem]}) /call Kill
/delay 1s
/goto :search

/return

Sub Kill

:Kill
/warp t
/delay 1s
/cast 1
/delay 6s
/if (${Target.Type.NotEqual[corpse]}) /goto :Kill
/call LootMobs


/return

 

[Zat]

Yeah i had made some more improvements and it was the first macro i have ever made, i have actually gotten it over 1k an hour now, first afk farming i have ever done so dont know whats good yet.