Release DumpsterDive.mac 1.82

[Redmarine]

@toadwart Great macro, running today using your list of vendors in pok.

trying to buy Blue Diamond, it bought 100 Blue Vernain Bulbs as well.

[Items]
Blue Diamond=1
[PoKnowledge-Merchants]
Elisha Dirtyshoes=1

 

[Redfrog]

@toadwart same for me, absolutely love this, but the partial names thing is making my guy buy other things. I have
[Items]
Bone Chips=1
Used Parchment=1

I am buying Fine Bone Chips and 2-3 other vendor sold items with the parchment name in it. One vendor sells an item with the name parchment that was 512 Plat each, thankfully I was watching my guy run around and I was able to stop it by th third purchase. at 512 plat each, I would have been broke fast !
If possible would:
Partial=1 option be available, so some of us can turn it off.

 

[Ordell]

Can someone post an INI for PoK?

 

[Redfrog]

Can someone post an INI for PoK?

Ordelll, its in Post #35 https://www.redguides.com/community/threads/dumpsterdive-mac.56906/post-397828

 

[Ordell]

*sigh* another embarrassing moment.

thanks

 

[Jarsath12]

@toadwart You maintaining this still? Any chance of searching for exact names and not partials.

 

[rouneq]

@toadwart You maintaining this still? Any chance of searching for exact names and not partials.

On or about line 165, at the end of the line change List[${ItemName},2]} to List[=${ItemName},2]}

 

[toadwart]

what Rouneq said^

Having said that, I think I actually did change that in my dev version to address the issue brought up by redfrog above, and need to update the resource.

 

[toadwart]

toadwart updated DumpsterDive.mac with a new update entry:

Dumpsterdive v 1.81

v1.81 updates 220504

-Fixed a timing issue that was causing inappropriate item purchases at times
-Fixed the partial name match to be an exact name match when buying items to also hopefully remove incorrect item purchases
-Thank you Redfrog and Redmarine for bringing the issue to my attention, and for helping me test
-Also thanks to Jarsath12 for the prod to finish updating the public resource and not just my dev build

Read the rest of this update entry...

 

[Redfrog]

TY @toadwart

 

[Fenworth]

I'm having trouble adding merchants. It looks like Par1 is not defined in version 1.81 as it was in version 1.8.

/if (${Debugging}) /echo Adding Merchant: \ag${Param1}\ax to Merchant List: \ag${Param0}\ax

When I run debug, Line 148 runs and provides: "Adding Merchant: to Merchant List: merchant"
So it's not understanding that anything is being passed to Param1 but it is seeing the correct Param0

/if (${Debugging}) /echo First Parameter inside AddMerchant: ${Par1}

Then when debug gets to line 177 the output is: "First Parameter inside AddMerchant: NULL"
Which tells me that Par1 has not been set.

No further outputs are echo'd and nothing gets written to the ini file. I have to manually end the macro.

When I look at version 1.8 as compared to 1.81, there's been quite a bit of change to this subroutine. I'm thinking it somehow missed defining Par1 as the targeted merchant's name.

Any ideas?

Fenny

 

[toadwart]

There were some screwups there. I think it's working correctly now. Check out v1.82

 

[toadwart]

toadwart updated DumpsterDive.mac with a new update entry:

Dumpsterdive v 1.82

Correctly the "/dive merchant" routine to correctly add targeted merchants to the lists.

Briefly tested, and it worked, but let me know if there's something else I missed.

Read the rest of this update entry...

 

[Ordell]

You've got a really great utility here, and I appreciate your work. I would just like to make one suggestion. Trim the ini file to remove obscure and out-of-the-way merchants. You've got every merchant in the POK listed there, and some of them are upstairs and in twisty areas, and never have anything from users because they are so out of the way nobody bothers. So getting rid of some merchants from the POK ini might make navigation a little bit easier.

Again, just a suggestion.

 

[toadwart]

I hear what you're saying, but that's just a sample ini that was fully inclusive, and I included every merchant just 'cause someone "might" sell there. it's a public ini, just delete the ones you don't want to visit. It won't be over written if you download in the future, so it's specific to your computer.

 

[blahblahblah84]

This is a great macro, and yet it also sucks ... I can no longer seed something on vendor trying to collect stuff. Every couple hours someone runs through and buys all the items I've seeded. On every vendor, no matter how out of the way. <sigh>

:-P

 

[toadwart]

I blame the seed stealing gnomes

 

[Klunk]

I have been using this on a EMU server so i can start tradeskilling, it is a Awsome script , saves me hours

 

[toadwart]

I'm glad it's helpful. I don't use it as much as I used to on live. there's been less need for it, at least for my scenario, on the TLP I'm on now, but it's a lifesaver for gathering TS items other's have ditched, that can't be found other than by farming, and sometimes they're quite valuable, either individually, or the item they can help make.

 

[Klunk]

I'm glad it's helpful. I don't use it as much as I used to on live. there's been less need for it, at least for my scenario, on the TLP I'm on now, but it's a lifesaver for gathering TS items other's have ditched, that can't be found other than by farming, and sometimes they're quite valuable, either individually, or the item they can help make.

Well works perfectly on EMU , I been gathering binding powders for skilling up research and the amount it can grab if you run at right time of day is great

 

[Douler]

I know this is an oldie but on EMU its amazing, one issue is PoK with merchants like Vuli Ironstove who sit in pens the macro wants to keep running at them with it hits the small fence even though its close enough to check the merchant. I've adjusted this part to the max it can go and still open the merchant window but no luck. (toon is doing the running man on the fence) /squelch /nav spawn npc ${MerchantName} | dist=22