Auto_CLR fixes

[saar]

so far fixed the buff spamming I might have fix pet healing someone test out and let me know

Edit:updated for spell stacking (I hope) give it a shot. I dont use mercs so hard to test for me.

 

[macromanic]

can you add a ini option for cleric to have buffs on and off till we get fix for the buff spam either that or a ini timer for a recasting set for rebuffing?

 

[saar]

with the version i posted wasnt spamming grp cleric buff nor self buffs and was recasting buffs as they left the tank. Now I do not have a druid so couldnt test the druid skin, but if it is spamming I can fix the logic for it.

 

[macromanic]

I tried the one you linked it spams when it cant over wright anothers spell ie mercs

 

[saar]

which spell is it trying to over write, there is no stacking logic in there atm so thats why its spamming for you i just need to know what merc spell is it trying to overwrite, and I am guessing it is a nuking merc since it will pull if it has another cleric buff on already.

 

[godsfshrmn]

I see the repeated casting when I have assurance blocked and I am using druid buffs. I just leave druidbuffs to on an manually do assurance on tank. It needs to be able to detect buff failures. I bet blocked buffs is why some are seeing this

 

[saar]

if using druid buffs there is a check for using a druid, so if you have usedruid=1 it won't cast assurance and will cast symbol instead. I guess I can pull info from the blocked buffs window as a check aswell, or reverse the logic to check for symbol before assurance.

 

[macromanic]

The merc is level 110 casting assurance the player char cleric is 109 casting hand of sureity over and over again.

 

[saar]

well all i can say is grp with your tank only and have assurance on and then use this while the macro is running

/echo ((${Target.ID} && ${Target.BuffsPopulated}==TRUE) && (!${Target.Aego.ID} || !${Target.Skin.ID} && !${Target.Symbol.ID}) && (!${Target.Buff[${GroupBuff}].ID} && ${Target.Spell[${GroupBuff}.RankName].Stacks} && ${GroupBuffRecast}!=1))

and let me know what you get

 

[kaen01]

@saar use .NewStacks for checking if a buff stacks. should help a bit.

 

[saar]

I haven't seen anything on that change. I could just rewrite the buff section but this is Noob's code I am tweaking, maybe should see if anyone else is having issues.

 

[joojoobee]

It was reported in another thread, but there are a few targeting issues with the Heal routine.

If you watch the targeting window you see that either nothing is targeted, or an NPC is targetted. It spam broadcastss a NULL heal broadcast (usually something incorrect is targetted). The tank dies from underhealing. I don't understand why it spams the broadcast because the broadcast is within an /if statement that requires a successful cast event (? is the cast event not cleared?). It also sometimes tries to spam heal an NPC... and I can't figure out where it's getting that targeting ID because I have DPS off.

I tried tracking the error and so far either the ${tankid} in the heal section is "lost" or the groupmemberid is lost.

The issue primarily seems to happen when HealQueue is called (primarily from the Promised line) or from a direct heal to ${tankid}, and the heal is broadcast, as noted above, and reports as NULL. Or it somewhere is picking up an NPC and tries to spam heal.

I have two groups working a spot for AA experience. Usually happens when things start to get messy about 5 minutes in.

JJB

 

[Marnan]

I'm seeing the Null Targeted a lot lately. Probably need to switch to something else on my out of main group cleric.

 

[saar]

I will look into it later on when I have time to see if I can track it down

 

[Noobhaxor]

I'm currently slimming down this macro. WTF is .NewStacks? and is there a better way to handle buffing @saar ?

 

[saar]

not sure what .newstacksis I have not found anything on it. Other than expanding the logic used to determine buffs to use your buff routine is good, if you look at what I changed to the buff check it should be grouped better in line with your flow as it was.

 

[dannuic]

.NewStacks is meant to replace .Stacks and is still in testing. It's more accurate, but also not guaranteed to work (though I'm not sure what cases it won't).

 

[poopyfarts]

Doesn't seem to be healing my pet