Release ZFix - 'You cannot see your target' fixer .8

[nerp]

nerp submitted a new resource:

ZFix - Reel it back

A simple moveback with path check to fix the "You cannot see your target" bug.

NOTE: Assumes your group is in chase mode. If this is not the case, '/zfix camp' before starting or edit the lua to suit your specific scheme.

Read more about this resource...

 

[Tibberu]

I think you need to change these 2 lines to remove the /dgge from them.

 mq.cmd('/dgge /cwtn mode 0')

 mq.cmdf('/dgge /cwtn mode %s',cwtn_group_mode)

The /cwtn is already doing a /dgge so with the /dgge /cwtn you're telling every client to do a /cwtn which causes the other clients to tell the tank to go into mode 0 and end up in mode 2.

 

[Sic]

I think you need to change these 2 lines to remove the /dgge from them.

 mq.cmd('/dgge /cwtn mode 0')

 mq.cmdf('/dgge /cwtn mode %s',cwtn_group_mode)

The /cwtn is already doing a /dgge so with the /dgge /cwtn you're telling every client to do a /cwtn which causes the other clients to tell the tank to go into mode 0 and end up in mode 2.

no.

/cwtn blah

 

[Tibberu]

no.

/cwtn blah

I think we're saying the same thing? The Lua has /dgge /cwtn, which you wouldn't want to do because it causes the non-driver accounts to /cwtn and send whatever you are trying to send to your group back to your driver. If you wanted to do that you would just /cwtna.

So as is when the Lua executes /dgge /cwtn mode 2 at the end it causes the tank to be in mode 2, rather than tank or hunter or whatever you were doing beforehand.

 

[Sic]

Right - sorry i definitely mis-read/mis-understood what you wrote Tibs

- mq.cmd('/dgge /cwtn mode 0')
+ mq.cmd('/cwtn mode 0')
- mq.cmdf('/dgge /cwtn mode %s',cwtn_group_mode)
+ mq.cmdf('/cwtn mode %s',cwtn_group_mode)

 

[nerp]

Oops, I had that alias overwritten and thought it was the single-toon version. Fix inc.

 

[nerp]

nerp updated ZFix - 'You cannot see your target' fixer with a new update entry:

Tweaks

-revised group command method
-now retargets original mob and resumes attack just in case it was important

Read the rest of this update entry...

 

[a_moss_snake]

BTW, I have been running into some issues with zfix, I added this to counter the occasional "you cannot see your target" messages:

[ninja edit to fix my crap]

local timer = os.time()

local function Event_BrokenZ()
    local dist = mq.TLO.Target.Distance() or -1
    if dist > 0 and dist < 20 then
        if timer < os.time() - 2 then
            count = 0
            timer = os.time()
            debug("resetting counter")
            return true
        end
        count = count + 1
        debug("increasing counter to "..count)
        timer = os.time()
    end

[...]

 

[nerp]

Yeah it can be a bit aggressive depending on how fast your main hand is. I'll pull this in.

 

[nerp]

nerp updated ZFix - 'You cannot see your target' fixer with a new update entry:

os.time check

os.time check to reduce aggressiveness a little. Thanks AMS

Read the rest of this update entry...

 

[a_moss_snake]

nerp updated ZFix - 'You cannot see your target' fixer with a new update entry:

os.time check



Read the rest of this update entry...

Sorry, forgot to mention, but you need to initialize timer at start, I set it like this:

local timer = os.time()

 

[nerp]

nerp updated ZFix - 'You cannot see your target' fixer with a new update entry:

timer initialize

--oops?

Read the rest of this update entry...

 

[a_moss_snake]

nerp updated ZFix - 'You cannot see your target' fixer with a new update entry:

timer initialize



Read the rest of this update entry...

Right, and I wasn't even drunk...I did convert this from another timer implementation but just now noticed that the condition is now in the wrong direction. Please see above

 

[nerp]

poop, now i have to actually go test things?

 

[knave23]

I had a solo toon running into this bug while farming low level stuff, but was unable to run this because it expects you to be the MA. I added a check for grouped to the clause below (line 133) to fix it if you want to incorporate that into the main branch:

if mq.TLO.Me.Grouped() and mq.TLO.Group.MainAssist.Name() ~= me then
        print('Only run this on your MA')
        mq.exit()
    end

 

[grimmier]

because my MA is always the first to load and the group is never set when my Lua scripts all load. I did this for a work around.
added an argument check so if you run /lua run zfix ma you are telling the script you intend to be the MA even if the group isn't here yet.

--- insert at top with variables
local meMA = false -- variable to hold MA setting

--- insert before the init function
local args = {...}  -- check arguments on load for ma tag.
if #args > 0 then
    if args[1] == "ma" then
        meMA = true  -- set var to true denoting we are the ma even if group is missing still
    end
end

-- adjusted check inside of init function
if not (mq.TLO.Group.MainAssist.Name() == me or meMA) then -- check if you are not MA and didn't say you were exit
    print('Only run this on your MA')
    mq.exit()
end