Ultimate Potion Making Macro

[Really]

I could use some help with this macro. It buys the required ingredients, but will not do combines. This is my first attempt to upload a gif file to the post so bare with me.
Distillate of Skinspikes 6 is the macro I am running.

 

[VillageIdiot]

uploaded a new version, please try that one. I had typo'd a few times.

 

[Really]

Thanks for fast reply. Will try it in the morning.

 

[Really]

I just figured out why I sometimes CTD when using this mac. If I have bags open so I can see how much inventory room I have in determining the qty to make, then I will CTD every time. But if I make sure all bags are closed, it will run flawlessly.
Thanks for the great mac VillageIdiot.
Redcented

 

[wisperin]

Trying to run this but I'm a bit slow and confused. I'm assuming this is the section for me to change "container" to "Medicine Bag":

|---------------------------------------------------------------------------
|NOTE: Below section should choose your Alchemy container. as ContainerType
|---------------------------------------------------------------------------
/declare container String Outer
|---------------------------------------------------------------------------

"Please make sure to have "one of these 4 alchemy bags as the combine pouch and if not please change the mac to whatever you use." <-- Is a bit vague to slow guys like me - lol

When I edit the macro section above it will find the vendor, bring up the buy window and then CTD. It never buys anything. I have my Medicine Bag in a top inventory slot with nothing in it. I'm starting the macro with all windows closed. Am I editing the correct part or am I misunderstanding? A sample line would be perfect. Any help would be much appreciated, thanks!

 

[kaen01]

try this version it shouldn't require you to edit anything, only really have your alchemy bag in a main inventory slot that is not slot 1 or 2 re

 

[Boring]

Macro does not recognize Reinforced Medicine Bag or Medicine bag? I have it in the top slot and all bags are closed when I start. The macro goes to each vendor, buys the right ingredients then stops saying it doesn't recognize the bag.

Edit: I am using the potion.mac that kaen01 posted right above mine.

 

[Boring]

At least it saves me time buying the ingredients ..

 

[kaen01]

oh you cant have it in slot 1, put it in slot 9

 

[Boring]

oh you cant have it in slot 1, put it in slot 9

OH! Ok, I will give that a go next run.

Yeah, putting it in slot 9 didn't work either. Same error message. Thanks for the help though - and working on updating this !! It seems to work fine purchasing supplies that's half the battle.

 

[kaen01]

have started the long and tedious rewrite of this macro, gonna try and bring it up to date with new functions and commands such that now exists in mq2.

Expect something before christmas

 

[Boring]

Hell yeah. Red cents to you!

 

[Redbot]

have started the long and tedious rewrite of this macro, gonna try and bring it up to date with new functions and commands such that now exists in mq2.

Expect something before christmas

king

 

[Wolfborn]

I ran this the other day (last week) and made hundreds of potions. Tried again this morning and it would crash when trying to buy the ingredients.
I remembered that when I used it before I had just unloaded almost all plugins when trying to diagnose some issues.
I again unloaded most all plugins except the basics.

I did end up moving some declares in the BUY sub in Buy.inc

These three lines were moved up to the top of the sub instead of inside the loop.

/declare char string local
/declare InStr string local
/declare loopctr int local

That got rid of all the errors I was seeing.

It runs flawlessly now.

[CODE title="Move highlighted lines to this position" highlight="8,9,10"]Sub Buy(Item ItemToBuy, int amount)
/echo Buying ${ItemToBuy}!
/declare QTY int Inner
/declare l2 int local
/declare LastItemCount int local
/declare CurrentItemCount int local

/declare char string local
/declare InStr string local
/declare loopctr int local

/varset LastItemCount ${Window[MerchantWnd].Child[ItemList].Items}
|---SMALL delay to allow the MERCHANT Window to populate
/delay ${Math.Calc[${DelayMult}*2]}s
/varset QTY ${Math.Calc[${amount}-${FindItemCount[=${ItemToBuy}]}]}[/CODE]

 

[Sic]

I'm not sure about that delay, but you can do a delay with an early out condition to allow the merchant to populate

This would delay for 10 seconds unless the merchant items populate, if it populates the delay ends early
/delay 10s ${Merchant.ItemsReceived}

 

[Valthonis]

Anyone still using this that can help me with the crashing of it when it tries to buy from vendor (default UI)

 

[Wolfborn]

This mac has been working for me since I made a few corrections.
I've added "Philter of Fearune" to the list of potions as I need it when I start a human toon with their horrible vision.
To get a list of potions available enter - "/mac potion"
I can add more if requested.

Attaching the BUY.INC file since I did modify it to eliminate some errors.

 

[Zeeeeeee]

This mac has been working for me since I made a few corrections.
I've added "Philter of Fearune" to the list of potions as I need it when I start a human toon with their horrible vision.
To get a list of potions available enter - "/mac potion"
I can add more if requested.

Attaching the BUY.INC file since I did modify it to eliminate some errors.

nice...gonna try this today, i remember when i leveld a shaman in agnnar to sell potions and some of them were really nice

 

[Zeeeeeee]

This mac has been working for me since I made a few corrections.
I've added "Philter of Fearune" to the list of potions as I need it when I start a human toon with their horrible vision.
To get a list of potions available enter - "/mac potion"
I can add more if requested.

Attaching the BUY.INC file since I did modify it to eliminate some errors.

I would like that =)

 

[KamyKam]

One of the mac files is named potion while the other is named potions so be sure you use the right /mac potion or potions when using this...I am still trying to get mine to work but just noticed that. will update if that is my issue.

Redguides is making my life so easy, I find tho I am getting quite lazy by having all these GREAT macros!

Update: the potion/potions was my issue TY I am running smooth now!

 

[Wolfborn]

One of the mac files is named potion while the other is named potions so be sure you use the right /mac potion or potions when using this...I am still trying to get mine to work but just noticed that. will update if that is my issue.

Redguides is making my life so easy, I find tho I am getting quite lazy by having all these GREAT macros!

Update: the potion/potions was my issue TY I am running smooth now!

Sorry, I forgot to mention that I changed the name to protect the original uploaders file.

 

[Ninjapickle]

This worked great for Gate potions, but I can't seem to get SoW potions to work. When I type /mac potion sow1 (or any of them 1-5) I get a message telling me to try typing in the correct format. I've tried using sow 1, but the space just has it trying to make null potions. Any ideas?