• You've discovered RedGuides, an EverQuest multi-boxing and scripting community 🧙‍♀️⚙️. We want you to play several EQ characters at once, come join us and say hello! 👋

  • A TLP without truebox has thawed (Very Vanilla ready)
    Frostreaver
Resource icon

Release Tradeskill.mac 2.02

No permission to download
This is working great. How do I bypass once I know the recipe from only making 1 if my SkillUp is set to TRUE? SkillUp=TRUE and Recipetomake=1 Doesn't seem to keep going to skill up or I am missing something. Thanks. Also, before it would go back to try making the first one after the second one ran out of items. Is this changed now?
@cannonballdex

I've looked and can't see a way you reproduce the issue you describe, I set the recipes as known/make 0 and it still skills up on them for me. can you screen shot the issue you have / the ini you're using?
 
SkillUp=TRUE and Recipetomake=1
I didn't realize it was suppose to be set to 0 . Trying to figure out now why recipes I have 1 there and it just makes them till it is out of ingredients even though past trivial. Thanks.

DUH! I just noticed that I had skilltype as Smithing instead of Blacksmithing therefore never checking the skill. Something so simple. haha Thanks again.

All of the issues so far have been with me setting up the skill.ini file. Thanks.
 
Last edited:
Trying to make a mac for kunark meat and kunark shakes. I have attached the files for the meat. I snipped a screen shots for the items it says i'm missing. I hope you can read them. I have the items it says i'm missing in my inventory.

1586667730080.png1586667730080.png1586667846203.png
1586667846203.png
 

Attachments

Just change the RecipeXItemX= to the item names, not the ID's

I forget exactly what I was doing that made me add the item ID for the resulting item, I think it was a fletching thing, but I never made it so it needed the ID for the components.

I could maybe change it to use either at some stage
 
A recipe I use called for a bottle of wine, if i had a bottle in my inventory it would say you dont have a bottle of wine, this is when i used the number in place of a bottle for a bottle to get it to work. I think that is how it went. :)
 
I'll have a look in a few days at adding being able to use a item name or ID, currently the FindItem[=name] doesn't bt work with ID afaik

For making/reading ini I really don't like using just IDs it takes to much away from readability.

At the moment though I have a bunch of study to finish up that's due in a week, so need to avoid starting any mq/eq stuff... Else my days disappear :-(
 
@Cillon

Made it so it will use either full item name or item ID, simply use in the ini as example below. You don't have to use ID but you have to specific the item name and separate with a | . It doesn't necessarily have to be the item name, but you need some before the | and ID number. I haven't thought of a way around that yet

Only minor testing went into this at the moment FYI

[Recipe1]
Recipe1ItemName=Class 3 Bone Hooker Arrow (Small Groove)
Recipe1ItemID=Class 3 Bone Hooker Arrow|8670
Recipe1Container=Fletching
Recipe1Known=TRUE
Recipe1Trivial=102
Recipe1SkillType=Fletching
Recipe1MakeTotal=0
Recipe1Items=4
Recipe1Item1=x|8052
Recipe1Item2=Hooked Arrowheads|8056
Recipe1Item3=Bundled Bone Arrow Shafts
Recipe1Item4=Several Shield Cut Fletchings
 

Attachments

hahaha, I just got out of bed. I do typo a lot . Thanks for pointing that out! I think I can leave that
 
Allo,
How would you feel about this being made into an .inc so that another mac could call this just to do the combines and then return. This would be used in a manner for buying supplies/checking skills and getting ts quests from the main sub..

So the flow would generally be..

What do I want to make
What do I need to make it
Let's go there and Buy it
Let's Make It
Let's get the beginner TS quest..

ideas below for changing the tradeskill.mac

Test.mac
#turbo
#include tradeskill.inc
/sub main
/Call TS "smith50"
/return

would call TS routine (formally main) and make whatever is in the TS_Smith50.ini file and then return to main macro

Example change to the tradeskill.mac would be primarily

Sub TS(String Param0) - gets what is passed from the calling macro.

and change a few ends to return and prolly wipe out some code that may or may not apply in tradeskill.inc let me know what you think...
 
Beginner Baking Test

  1. Gather Materials
    • Store Bought Materials
      • Chef Denrun in PoK
        • Bottle of Milk x25
        • Carrot x100
        • Cup of Flour x25
        • Fresh Fish x100
        • Frosting x25
        • Garlic x50
        • Jug of Sauces x100
        • Lettuce x100
        • Loaf of Bread x25
        • Rat Meat x25
        • Spices x25
        • Turnip x100
        • Vinegar x25
        • Water Flask x100
      • Darius Gandril in PoK
        • Bat Wing x25
      • Katha Firespinner in Commonlands
        • Rat Ears x25
    • Drops / Search Bazaar
      • Bixie Parts - Misty Thicket
      • Griffon Meat - Nedaria's Landing, a serene griffawn
      • Snake Egg - Blightfire Moors, a moss viper or a greenscale viper
      • Spider Legs - East Karana - various spiders
      • Wolf Meat - East Karana - various wolves
    • Fishing
      • Saltwater Crab - Natimbi - these come in 1 lb. to 15 lb. varieties, the macro will process all of them
      • Saltwater Tuna - Natimbi - these come in 1 lb. to 15 lb. varieties, the macro will process all of them
  2. Run /mac tradeskill baking50
    • This gets you up to the 50 Baking Skill level needed to pick up quest.
  3. Go to West Freeport and talk to "Event Coordinator Baublie Diggs" if you have not already. Say "test" and then "baking" to receive the Beginning Baking Test quest.
  4. Go back to Plane of Knowledge to trade skill area, where "Caden Zharik" the Parcel guy is.
  5. Run /mac tradeskill bakingtrophy
  6. Go back to West Freeport and deliver items to "Judge Marion Teld`mare"
  7. You will receive "Beginner Baker Scorecard"
  8. Turn that into "Event Coordinator Baublie Diggs" to receive the "Beginner Baker Trophy"

Beginner Brewing Test

  1. Gather Materials
  2. Run /mac tradeskill brewing50
    • This gets you up to the 50 Brewing Skill level needed to pick up quest.
  3. Go to West Freeport and talk to "Event Coordinator Baublie Diggs" if you have not already. Say "test" and then "brewing" to receive the Beginning Brewer Test quest.
  4. Go back to Plane of Knowledge to trade skill area, where "Caden Zharik" the Parcel guy is.
  5. Run /mac tradeskill brewingtrophy
  6. Go back to West Freeport and deliver items to "Judge Marion Teld`mare"
  7. You will receive "Beginner Brewer Scorecard"
  8. Turn that into "Event Coordinator Baublie Diggs" to receive the "Beginner Brewer Trophy"

Beginner Jeweler Test

  1. Gather Materials
    • Store Bought Materials
      • Jeweler Nonny in PoK
        • Opal x5
        • Emerald x5
        • Peridot x5
        • Topaz x5
        • Pearl x5
        • Jade x5
        • Wolf's Eye Agate x5
        • Amber x5
        • Star Rose Quartz x5
        • Silver Bar x40
      • Summon Resupply Agent - AA ability, 20 hour cooldown but only vender supply of Black Pearls.
        • Black Pearl x3
  2. Run /mac tradeskill jewelry50
    • This gets you up to the 50 Jewelry Making Skill level needed to pick up quest.
  3. Go to West Freeport and talk to "Event Coordinator Baublie Diggs" if you have not already. Say "test" and then "jewelry" to receive the Beginning Jeweler Test quest.
  4. Go back to Plane of Knowledge to trade skill area, where "Caden Zharik" the Parcel guy is.
  5. Run /mac tradeskill jewelrytrophy
  6. Go back to West Freeport and deliver items to "Judge Marion Teld`mare"
  7. You will receive "Beginner Jeweler Scorecard"
  8. Turn that into "Event Coordinator Baublie Diggs" to receive the "Beginner Jeweler Trophy"

Beginner Mechanist Test

  1. Gather Materials
    • Store Bought Materials
      • Chef Denrun in PoK
        • Water Flask x100
        • Pie Tin Mold x5
        • Skewer Mold x5
      • Engineer Beri in PoK
        • Gnomish Spirits x30
        • Metal Shaft x30
        • Cork x20
        • Spriket x10
        • Gnomish Bolts x10
        • Metal Rod x30
        • Static Orb x10
        • Battery Casing 1 x10
      • Blacksmith Gerta in PoK
        • Small Piece of Ore x40
      • Sculptor Radee in PoK
        • Quality Firing Sheet x10
        • Ceramic Lining Sketch x10
        • Small Block of Clay x10
      • Darius Gandril in PoK
        • Bat Wing x30
    • Drops / Search Bazaar
  2. Go to West Freeport and talk to "Event Coordinator Baublie Diggs" if you have not already. Say "test" and then "tinkering" to receive the Beginning Mechanist Test quest.
  3. Go back to Plane of Knowledge to trade skill area, where "Caden Zharik" the Parcel guy is.
  4. Run /mac tradeskill tinkeringtrophy
  5. Go back to West Freeport and deliver items to "Judge Marion Teld`mare"
  6. You will receive "Beginner Mechanist Scorecard"
  7. Turn that into "Event Coordinator Baublie Diggs" to receive the "Beginner Mechanist Trophy"

Beginner Potter Test

  1. Gather Materials
    • Store Bought Materials
      • Chef Denrun in PoK
        • Block of Clay x 15
        • Ceramic Lining Sketch x 15
        • High Quality Firing Sheet x 15
        • Large Block of Clay x 15
        • Medium Jar Sketch x 15
        • Pot Sketch x 15
        • Quality Firing Sheet x 35
        • Small Block of Clay x 100
        • Small Jar Sketch x 15
        • Unfired Dye Vial x 15
        • Bowl Sketch x100
      • Chef Denrun in PoK
        • Water Flask x100
      • Blacksmith Gerta in PoK
        • Small Piece of Ore x10
  2. Run /mac tradeskill pottery50
    • This gets you up to the 50 Pottery Skill level needed to pick up quest.
  3. Go to West Freeport and talk to "Event Coordinator Baublie Diggs" if you have not already. Say "test" and then "pottery" to receive the Beginning Potter Test quest.
  4. Go back to Plane of Knowledge to trade skill area, where "Caden Zharik" the Parcel guy is.
  5. Run /mac tradeskill potterytrophy
  6. Go back to West Freeport and deliver items to "Judge Marion Teld`mare"
  7. You will receive "Beginner Potter Scorecard"
  8. Turn that into "Event Coordinator Baublie Diggs" to receive the "Beginner Potter Trophy"

Beginner Researcher Test

  1. Gather Materials
    • Store Bought Materials
      • Eric Rasumus in PoK - Turn off "Show only items I can use" in vendor window.
        • Chromium Powder x20
        • Arcane Treatment x20
        • Iron Powder x20
        • Graphite Powder x10
        • Hematite Powder x10
        • Galena Powder x10
        • Logwood Pigment x10
        • Fustic Pigment x10
        • Knight's Treatment x20
        • Divine Treatment x20
        • Empty Vial x100
        • Gnomish Heat Source x40
        • Quill x50
        • Water Flask x200
      • Darius Gandril in PoK
        • Celestial Solvent x20
  2. Run /mac tradeskill research50
    • This gets you up to the 50 Research Skill level needed to pick up quest.
  3. Go to West Freeport and talk to "Event Coordinator Baublie Diggs" if you have not already. Say "test" and then "research" to receive the Beginning Reseacher Test quest.
  4. Go back to Plane of Knowledge to trade skill area, where "Caden Zharik" the Parcel guy is.
  5. Run /mac tradeskill researchtrophy
  6. Go back to West Freeport and deliver items to "Judge Marion Teld`mare"
  7. You will receive "Beginner Researcher Scorecard"
  8. Turn that into "Event Coordinator Baublie Diggs" to receive the "Beginner Researcher Trophy"
 

Attachments

Last edited:
Does this take into account that you can do the free tradeskill quests in CR or AS to get you up to 54 in the different tradeskills? Then just go to the Event Coordinator Baublie Diggs and start the quest for the different trophies. Normally that is how I usually do the tradeskills. Do the free skill ups for whatever trade I want to do then go to see Baublie Diggs to start the test.
 
Does this take into account that you can do the free tradeskill quests in CR or AS to get you up to 54 in the different tradeskills? Then just go to the Event Coordinator Baublie Diggs and start the quest for the different trophies. Normally that is how I usually do the tradeskills. Do the free skill ups for whatever trade I want to do then go to see Baublie Diggs to start the test.

Exactly why I was going with the separate INI file for getting the 50 skill. You can just skip if need and go straight to gathering materials for the beginning trophy. I had Tailor and Blacksmithing to high to do Beginning Trophy on my current character, when I switch to my second character to do tradeskills I will finishing rest of the Beginning INI files in my guide.

My Supplies list is a little heavy how many mats of each you need, that way you won't run out if fails. I'm sure some of them could be smaller but the cost is not that bad and I just sell back the rest.
 
Having multiple issues with the research trade skill, first one I've tried.

First my Research Trophy is already equipped so in my mind there is no reason I should have to even mess with that portion of code. I'm not sure why it is even there but I didn't write the program so I'm sure you had a valid reason for sticking it in there. Thing is no matter HOW I set "UseTrophies" it always attempts to load and gives me the message below. I'm quite sure this is just a minor irritation as I cannot imagine why it would affect the macro. My question is how do I actually bypass this? I will provide the ini code below, very small.

/echo Missing one or more trophies/mods either typo in the name, or it's in the bank...
/echo Or you don't have a mod listed, macro will wait a moment for you to either /end macro to check, or /mqp and collect item from bank

Second it can't find my research container message "[MQ2] Can't find container -- Prayer Writing Kit -- for combine, check spelling / does it exist in this zone?" I have checked the spelling on this numerous times and it is correct. Initially I had "Recipe1Container=research" which gave the same message. Can't find anything in your write up which tells me what to set it too so I changed it to "Prayer Writing Kit" which is what I use for research.

(((( INI file )))
[General]
TotalRecipeNumber=1
DoSkillUps=FALSE
[Recipe1]
Recipe1ItemName=Glowing Energeiac Rod
Recipe1ItemID=33762
Recipe1Container=Prayer Writing Kit
Recipe1Known=TRUE
Recipe1Trivial=316
Recipe1SkillType=Research
Recipe1MakeTotal=10
Recipe1Items=3
Recipe1Item1=Silver Conduit Small Core
Recipe1Item2=Peridot
Recipe1Item3=Freetide Wood Wand

I'm sure this is a simple issue dealing with something I missed in your write up but if you would not mind taking a look and providing me with a gentle nudge I would appreciate it.

Edit ---- If you have answers to these issues I would like to know HOWEVER I changed it back to research and found a "research table" and it actually works great. Great job.
 
Last edited:
Sorry, I never coded support for inventory based containers for combine. Just stationary environment types, ie the research table. The macro will nav to a different container for the recipe types in the ini if you have mq2nav and a mesh loaded/path exists to alleviate any issues with doing different type combines

I don't see anything in your ini about trophies, but either way apart from the initial message at the start it won't affect how the macro runs etc. So long as you have manually equipped any trophy/mod you want it won't change it unless you have set it up to.

I could probably do something more elegant to, I just felt a message to remind people they don't have trophy set or what not would be more beneficial then no mention and potentially missing a skill mod or skilling up a trophy. At least I didn't make it spam it each recipe/skill etc... :-P

I need to sit down a revisit the item ID stuff anyway soon, just really exhausted with work at the moment....shit just never ends
 
You are so right!!! :f5: Shit just never ends. I was under the impression that you had to put the trophy into the container use for the trade skill to evolve the trophy.
 
I am working on doing swaps for trophies based on inventory to do it automagically, also I have modded the tradeskill.mac now called ts_core.inc to do inventory containers also..
 
Here is a demo of the tradeskill shopping list shopper.. yes it can really buy but I added a simulated shopping mode so you can see what it would buy... without actually buying it

reads Tradeskill.mac ini files...! Thx Rooster!
 

Attachments

2.78 posted.. with skillups, and a host of other options...

2.78 6/12/2020 release

Change List

Quests:

Added: Prophecy of Ro (Get Trophy Tasks)
This is good to do after you have done all the freebie quests
/mac tsgod trophies

Fixed: If you had a different task than the beginner task and re-started it will now ask for supplies instead of quitting
Added: Checks to make sure you have a skill point for research.. otherwise no combining for you!

Tradeskill Machine:

Added: Check for INI file before trying to load recipes - Error Checking

Added: Use your own INI file and make recipes
usage /mac tsgod Make Brews
Description: This will look in your tradeskill folder and try to make recipes in TS_Brews.ini file

Added: Skill Up Option
usage /mac tsgod Skillup brews
Description: Will make recipes only if you have not met the trivial for that item. Ignores make totals

Added: Recipe List Option Short
usage /mac tsgod list brews
Description: Lists the recipes in the ini file with just the name and number

Added: Recipe List Option Full
usage /mac tsgod full brews
Description: lists the recipes in the ini file with ID, Trivial, Skill, Container, Items, Count, Name

Added: Make Items with loose searching
usage /mac tsgod loose brews
Description: Makes items but when searching it throws caution to the wind and does the closest match

Added: Make Items with loose searching with skillups
usage /mac tsgod looseskillup brews
Description: Makes items but when searching it throws caution to the wind and does the closest match
and does skillups when crafting

Added: Spruced up quest info/instructions /mac tsgod

Travel:

Added: West Freeport zone to POK/Crescent Reach/Abysmal Sea now
Will run from this zone to POK for quests

Notice: Enabling Skill Ups DISABLES Make Total Adherence!

Note: If you are using a custom UI it may interfere with the tradeskill UI search window.. test out the container and see if
the search window is there...
 
Downloaded and extracted to macros folder did the /mac tradeskill mana 1 for the new .ini I want to create, not able to locate file. I have the tradeskill folder in MQ2/macro folder any advice? Went threw the code for the file and says it should put it in the tradeskill folder but nothing is showing up. If I type the /mac tradeskill mana it acts like it wants to do it but since nothing in the .ini it ends.
I did a PC search for the file and made icons in MQ2 folder large and not finding it.
 
Downloaded and extracted to macros folder did the /mac tradeskill mana 1 for the new .ini I want to create, not able to locate file. I have the tradeskill folder in MQ2/macro folder any advice? Went threw the code for the file and says it should put it in the tradeskill folder but nothing is showing up. If I type the /mac tradeskill mana it acts like it wants to do it but since nothing in the .ini it ends.
I did a PC search for the file and made icons in MQ2 folder large and not finding it.
C:\...\MQ2\Release\Macros\Tradeskill\TS_mana.ini should be the full path and filename
 
I'm at work until (about 8 hours from now) I'll have a look

I was having a look the other night, I went through and cleaned up a few things to post an update soon. I didn't test file creation recently though as I haven't actually used it at all recently, not finding a huge amount of time for eq (at least at the keyboard :-x) let alone tradeskills, they are honestly my second least favourite thing in eq.... Housing first... But at least I can ignore housing completely lol
 
Downloaded and extracted to macros folder did the /mac tradeskill mana 1 for the new .ini I want to create, not able to locate file. I have the tradeskill folder in MQ2/macro folder any advice? Went threw the code for the file and says it should put it in the tradeskill folder but nothing is showing up. If I type the /mac tradeskill mana it acts like it wants to do it but since nothing in the .ini it ends.
I did a PC search for the file and made icons in MQ2 folder large and not finding it.

I just downloaded the currently posted version of the macro on the forums and it created a new ini for me ok.

When you do /mac tradeskill mana 1, did it output anything/error? Could you try it again and screenshot it's output?

As I mentioned above, I went through and cleaned up a few things... i'm probably gonna add some colours to the messaging for it... seems everyone else has colour these days :P

I haven't worked out a neat way for some of the originally added code to use either ID or item name that I just posted in the thread, but I will post a version with that in it as the latest resource with updated instructions hopefully on Saturday or maybe Friday night. In a pretty foul mood after work today sadly to do anything.
 
I just downloaded the currently posted version of the macro on the forums and it created a new ini for me ok.

When you do /mac tradeskill mana 1, did it output anything/error? Could you try it again and screenshot it's output?

As I mentioned above, I went through and cleaned up a few things... i'm probably gonna add some colours to the messaging for it... seems everyone else has colour these days :P

I haven't worked out a neat way for some of the originally added code to use either ID or item name that I just posted in the thread, but I will post a version with that in it as the latest resource with updated instructions hopefully on Saturday or maybe Friday night. In a pretty foul mood after work today sadly to do anything.

Rooster, Do you want to collaborate or throw out ideas so we can keep TS_Core.inc and tradeskill.mac in-line with each other.. ? Or let them go their own "Separate Ways"

by all means grab whatever code I have..
 
New TS Construction Set Release..

Change List:

Tradeskill Machine:

Added: Can Use Modest Guild Hall Tradeskill Items without changing ini. It will automagically target and use the right item.
(I.E. Brew Barrel becomes Brewing Barrel)

Added: Can Use (AFAIK) all the buyable portable containers anywhere and crafted/most tinkered (See Note)

Note: Portable Oven not supported at this time (charged items) or items that match Portable Kiln, Portable whatever..

Changed: Only check for free inventory slots on 1st run. If inventory falls below 1 when obtaining items the macro will end.


Quests:

Added: text to tell you when a quest ends or starts for the chain questing

Fixed: that dreaded KILN walking in Abysmal Sea

Tested with Ogre and Gnome... seems ok..
Note: If you are tall, you might wanna shrink, makes things easier

Fixed: that dreaded Fletcher Sign walking in Abysmal Sea

Tested with Ogre.. seems ok..

Added Tradeskill Files:

Craggyisland tradeskill ini's for the beginner trophies:

Baking , Brewing, Pottery, Jewelry, Research, and Tinkering
 
2.79v2 6/25/2020 release

Change List:

Folder structure, now moved all files save for TSGOD.mac to TS_GOD sub-folder (less macs in the main dir)

Be sure to delete all the current TSQ files in the macro directory..

Travel:

Fixed: Casting Gate Parsing Error, Now uses alt act to gate.

Quests:

Changed: Check Method for Research chain-quest, now it checks to see if you have a skill point and the proper research kit.

Added: Run Timer for the quests.

Added: Get The Trophy Now! added beginner trophy turn in and get the trophy and go to POK

You need to have made all the stuff first for this to work!

usage: /mac tsgod GetTrophy Jewelry
usage: /mac tsgod GetTrophy Research
usage: /mac tsgod GetTrophy Baking
usage: /mac tsgod GetTrophy Pottery
usage: /mac tsgod GetTrophy Fletching
usage: /mac tsgod GetTrophy Brewing
usage: /mac tsgod GetTrophy Smithing
usage: /mac tsgod GetTrophy Tailor
usage: /mac tsgod GetTrophy Alchemy
usage: /mac tsgod GetTrophy Tinkering
usage: /mac tsgod GetTrophy Poison

Tradeskill Machine:

Changed: Text output to be less wordy but informative enough.

Main TSGOD.mac:

Moved a lot of code around to be more efficent.

General:

Added a crafting results text list for determining what items you made and what ones you didn't

TODO: Allow for quest completion if you already know a similar recipe with a different sub-component.
TODO: Alternatively enable option to not use search UI

COMING: Auto-SHOP!
COMING: Destroy everything you made or crafted with if you want
COMING: Sell everything of value you made or crafted with if you want

================== END =================
 
Last edited:
2.79v3 6/26/2020 release

!!!!!!!!!!!!!!Compatibility Release!!!!!!!!!!!!!!

Change List:

Removed Search UI - Now custom UI setups should work!

Automagically Turned Off - Open Tradeskill List With CtrlRight Click option

Explanation: was causing crash!

Static Containers:

Fixed: Now static containers will clean up properly.

Portable Containers:

Fixed: Clean Routine was causing loop to infinity on vendor crafting tools

Explanation: This was directly caused by me getting rid of outer variables and making them local,and I didn't find all the locals!

General Tradeskill Machine:

Fixed: Varibles with no declarations.

Quests:

Fixed: TSS Research Quest was trying to turn in items to NULL .. No Bueno!

COMING: Auto-SHOP!
COMING: Destroy everything you made or crafted with if you want
COMING: Sell everything of value you made or crafted with if you want

NOTE: Removing the UI was a decision made for the following reasons:

Custom UI - Would cause crash
Searching - If there was a similar item and you were running the tradeskill quests it would loop endlessly.
Tradeskill INI files - now you don't have to specify what kind of recipe name Patty Melt (Bear) , Patty Melt is good enough.

NOTE: You must have all the components made to do the /mac tsgod GetTrophy baker..

the missing link is the auto shopper and the auto re-buyer, I think the shopper is solid but the re-buy needs work.. it needs it's own separate list otherwise it will try to re-buy items that are just part of the sub-combines and we don't want that.. or maybe we do, just don't want it to be costly..
 
Last edited:
Think of this in Marvel movie terms, we started with Iron Man and we are working are way up to the End Game!.. we are somewhere in the middle right now.. but we will have an end to end experience..
 
So I never understood this in the clean container sub

When I used the code,, and didn't understand it or it's implications, it would go to this routine and clean the container all the time with nothing in it..
with my code..

didn't know what was being Bool'd against.. Was it part of an event trigger or some magic?

Sub ContainerCleanup
/declare cc int local 1
/for cc 1 to ${TradeSkillArray[${CurrentRecipeNumber},7]}
/if (${Bool[TRUE]}) {
/itemnotify enviro${cc} leftmouseup
/while (${Cursor.ID}) {
/autoinv
/delay 2
}
}
/next cc
/return


So.. I am trying this instead..

Sub CleanStatic
/declare cc int local 1

/declare counter int local 0

/Call Recipe_Item_Count "${IniName}" ${CRN}
/declare iRecItems int local ${Macro.Return}

/for cc 1 to ${iRecItems}

/if (!(${InvSlot[enviro${cc}].Item.ID} == NULL)) {
/itemnotify enviro${cc} leftmouseup
/while (${Cursor.ID}) {
/autoinv
/delay 5
}

}

/next cc
/return false


thoughts?
 
Last edited:
From memory I can't remember well, but I recall having issues with the enviro container way back when, so it just got left to clean out each slot regardless of item/count even though could make it run faster to not empty the container and only add in required items

Ideally I would of removed the sub, and just included the check in the combine sub to check for item in enviro$a and only add in the item if the slot was empty ... since the items are always in the same slot based on the recipe from ini
 
Release Tradeskill.mac

Users who are viewing this thread

Back
Top
Cart