Leveling - Tank Aggro Target Selection Revamp

[Algar]

Could use some extra eyes on this if someone feels like playing... especially people in nonstandard groups or people who don't use Tank MAs.

Tank Aggro Target Revamp (Beta) (#1072)​

​

Added a setting to allow a PC in Tank Mode to independently select an xtarget to attempt to reclaim aggro, without affecting or changing the AutoTarget, even if they are also the MA.​

• The tank will continue to engage the AutoTarget, but will periodically change to the Aggro Target to use abilities found in the HateTools(AggroTarget) rotation.​
• If this tank is the MA, they will continue to broadcast the AutoTarget to any assisting RGMercs peer.​
• This is a "Beta" test of the funcionality, as such, it is defaulted to false. Once full testing is complete, certain settings will revert to defaults to encompass the new functionality.​
• A warning will appear if the Legacy "Aggro Scan" setting is enabled. Please disable this setting if using the Tank Aggro Scan.​

Eventually, this will be default behavior, but for now, it is an opt-in in Options > Targeting > Tank Aggro Scan (Beta).
Cheers!

 

[Nerenalist]

The premise of this is dope, I try it out for you and see what it does!

 

[Addict]

Thanks for working on this! I'll take a look asap! (Once I can log onto test)

 

[Addict]

I'll leave my comments here as well as is in the commit. All for utils/combat.Lua:

• If I understood correctly, the rotation engine will temporarily target the add and fire abilities, but the tanks position stays wherever the movement module has them. So if the add is beating on a healer, lets say 40 dist away, abilities with less range (Taunt, etc.) would not pass. Should we add a nav so the tank goes to the mob and ensures that he gets aggro?
• We have AggroTargetID and AggroTargetId (lowercase d and uppercase D)? Globals.AggroTargetId = 0 (lowercase d) at the top of TankAggroScan() vs Globals.AggroTargetID everywhere else
• I think the code is writing to the wrong table on assignment (Config.Globals.AggroTargetID vs Globals.AggroTargetID). Config.Globals.AggroTargetID = xtId, this never sets the real global