Release MQ2Say (1 Viewer)

[ChatWithThisName]

Right, so you already know what needs to be done. I was just asking what the hangup was. I didn't touch mqsay off, so not relevant to my changes as you would say.

I've reviewed them, which is where I got dates from in my original question.

Just find it odd that the original feature request was for the options to be added, they got submitted and denied, you took over it, then submitted the commit but didn't include the requested features and are waiting on that MR to get approved before adding in the requested features. Why not add them to the existing MR since you've already included the function. I'd been watching your MR thinking the additions were coming when you had a chance, I didn't realize you were waiting for that to be merged before submitting the things that the users have been requesting.

 

[Knightly]

Nothing was ever denied, I'm not sure where you're getting that information from. Regardless, referring back to the link I've pointed out multiple times now, you can see that that information isn't true. You can see that SL's request is still open and by her responses that she was open to the changes requested. She just didn't have time to do them and asked if I would finish out the MR for her, which I agreed to do. When looking it over, I noticed there were other issues and asked her if it would be okay if I fixed those as well, which she was amenable to. So I did and submitted an MR.

If the MR I submitted was a work in progress, I would have tagged it as "WIP" so that no one would review it while I was working on it. But even with you not having that information -- the very first line of the MR explains that it is prep for taking over MR 412 (and then goes on to explain the other ~4 bugs and ~12 changes) -- I put that in first so no one would have to read the whole thing to know that this was a precursor to me taking over the other MR.

Answering the question of why I did it that way -- it's because the majority of changes in that MR are unrelated to what SL was working on. But they do pave the way for answering everything that is in her MR. So it makes it easier on reviewers to split the concerns. They can independently review this MR which has intermediate changes, and then when I submit the changes to the other MR they flow from SL's initial MR. If I submit it in reverse then I'd be changing code while leaving bugs and then coming back and making changes to the code in SL's MR in a separate MR anyway. That's inefficient for everyone since a reviewer would have to review the same block of code twice. Similarly, if I just did all that in the one MR the title and feedback on the MR no longer makes sense and they have to review it all from scratch, including things unrelated to the things they've already commented on and, again, reviewing the same blocks of code twice. Doing it this way, I can minimize the code changes in that MR and specifically address the concerns that were brought up as a result of the MR itself. It says "I value your time and feedback" to the reviewers and, in general, it's just polite, but mostly it keeps any reviewers from having to do extra work on my account.

An important thing about MRs is to keep them specific in what you're addressing. In fact, MR 424 is actually more than what I would normally try to submit in a single MR, but I figured the reviewers would forgive me since a lot of it is fairly easy to follow changes.

 

[ChatWithThisName]

The "prep" bit is what led me to believe it was pending more submission. I'll keep an eye out for "WIP" tag in the future.

I agree that you submitted a lot of changes, which is why I didn't understand not also adding the features, specifically because you referenced the other MR, which would have already had the information regarding previous comments. As you say, it addresses some concerns that were brought up in that one just seemed so close to going full circle and knocking out the feature request that I failed to see the point in dropping the anchor there.

Either way, aside from all this other stuff, the answer to my question is "We're waiting on this other MR before we proceed with the changes." which is all I was really trying to find out.

 

[Knightly]

The reason to "drop the anchor there" is because it addresses concerns that were brought up in that MR but also exists in code that wasn't changed in that MR. So that's the distinction I used to draw the line of what goes in. Again, with the idea that I'm not adding unrelated changes to an existing MR because I don't want to be a burden on the people reviewing it. However, the specific items that were in SL's MR don't exist at all in my MR.

Just to be clear: If I wasn't planning on using SL's MR to finish out the changes, they could have all gone in mine, but then that disregards the other MR entirely. Doing that both disregards SL's previous work and the work of any reviewers (which sucks when you're the one reviewing). It is a little more work on me to do it this way, but it's cleaner and easier on everyone else while still giving credit where credit is due.

When I'm done, a reviewer can compare the last two changes on SL's MR (and I'll probably link to where I've addressed their concerns to make it even easier -- though that depends on how much energy I have on that day). Another way to put it is I appreciate the time of everyone who volunteers to read my code, so I'm trying to make it as easy as possible on them.

 

[eVILE]

Is it possible to have this play a .wave, .mp3, or some other way to have a custom notification?

 

[Knightly]

/mcicontrol C:\your\mp3\here.mp3

?

 

[BigDorf]

Is it possible to have this play a .wave, .mp3, or some other way to have a custom notification?

The current code will run a command that is defined in the ini file.
If you have a look in the ini, you will see the entry of line AlertCommand.

The default entry for this is to use, /beep.

You can replace that with any slash (/) command you like ( or set of slash commands, lead by /multiline ).




Now, moving on from that.

Have you experience of other notification plugins like Posse and GMCheck ?
They have specific support for playing wave files.

Is that where you're getting the idea of asking about playing some chosen sound files?

 

[eVILE]

The current code will run a command that is defined in the ini file.
If you have a look in the ini, you will see the entry of line AlertCommand.

The default entry for this is to use, /beep.

You can replace that with any slash (/) command you like ( or set of slash commands, lead by /multiline ).




Now, moving on from that.

Have you experience of other notification plugins like Posse and GMCheck ?
They have specific support for playing wave files.

Is that where you're getting the idea of asking about playing some chosen sound files?

I haven't used either of those. I only started using MQ2 on Riz, well, other than back in like 2003 when I had to compile it for myself.

I had been using GINA with triggers for "says" and "tells you" since the start of Mangler, ever since I received a 7 day suspension for "cheating." I have found the /beep to not be loud or distinctive enough for me to notice while fighting mobs and casting spells.

Funny thing is, my "cheating" happened when I was playing a full group on Mangler and was reported by someone even though I wasn't breaking any rules. A buddy who works IT had given me bunch of old laptops from the 2008/2009 era so I had one client per computer. However, I was reported, the GM showed up invis and did a /say while I was fighting mobs that talked, and I was given 7 days off. It didn't matter that I was talking to people in tells and manually playing. I was reported and missed a say so I was booted. Funny thing is, all I was doing back then was I had five wireless number pads and were using them. My bard would /melody and didn't melee because moving him was too hard. My healer did the pulling so that I could swap heal targets and not have to depend on in game macros to /target groupmember1, /pause 5, /cast heal, etc. My DPS and tanks were three mages and a wizard who had in game macros of /assist XXX , /pet attack, /cast 1 etc. TBH it was horrible how inefficient I was, but I played in odd hours (daytime) and enjoyed having a ready made group. Ever since then I have put up with GINA. In some zones it is awful how much my triggers go off, but between that and moving say to a giant window on each laptop, that was all I could do. At least that was all I could do until Rizlona came along.

 

[Redbot]

RG will tip 15 krono to whoever can get the proposed mq2say features through code review.

MQ2Say - Add ignore for group/guild/fellowship/raid (!412) · Merge requests · RG Creators / LegacyMQ2 · GitLab

This commit adds the ability to ignore say messages from members of your group, guild, fellowship, and raid. H/T Chatwiththisname for his contribution to MQ2Say. He...

gitlab.com

sl968 has RL issues and needs someone to take this over.

 

[Sic]

RG will tip 15 krono to whoever can get the proposed mq2say features through code review.

MQ2Say - Add ignore for group/guild/fellowship/raid (!412) · Merge requests · RG Creators / LegacyMQ2 · GitLab

This commit adds the ability to ignore say messages from members of your group, guild, fellowship, and raid. H/T Chatwiththisname for his contribution to MQ2Say. He...

gitlab.com

sl968 has RL issues and needs someone to take this over.

As always I'm happy to take over MRs, and I don't need krono

 

[Knightly]

As I said, SL asked me for help and I helped. The code for this is already done, I just split it into two MRs for all the reasons I outlined above.

 

[Hylander]

is splitting a merge request an oxymoron ?

 

[Knightly]

You've obviously never driven through Atlanta during rush hour. SPLIT MERGE SPLIT MERGE! But yeah, I split the unrelated code into two merges, not the merges themselves

For those watching from the cheap seats, the first MR was approved this morning and second MR is now in for review.

 

[madruk20]

The current code will run a command that is defined in the ini file.
If you have a look in the ini, you will see the entry of line AlertCommand.

The default entry for this is to use, /beep.

You can replace that with any slash (/) command you like ( or set of slash commands, lead by /multiline ).




Now, moving on from that.

Have you experience of other notification plugins like Posse and GMCheck ?
They have specific support for playing wave files.

Is that where you're getting the idea of asking about playing some chosen sound files?

I've actually tried to alter this and it will just revert back to the default beep in the ini once you reload the plugin. Is there a different way to do it?

 

[ChatWithThisName]

For any following along, the changes to add the features have been merged for MQ2Say, should be available next time VV Patches.

 

[Knightly]

I've actually tried to alter this and it will just revert back to the default beep in the ini once you reload the plugin. Is there a different way to do it?

If you edit it in the ini while the plugin is running you have to issue /mqsay reload on every character. Since it saves the file when it's unloaded, it'll overwrite your changes otherwise. Alternatively, you can do it before the plugin is loaded (ie, while you're out of the game on all characters) or you can unload the plugin on all characters, make the change, and then load the plugin on all characters.

This is generally true for anything where you're editing the ini directly.

 

[madruk20]

Ahh makes sense thanks for the reply.

 

[Redbot]

Redbot updated MQ2Say with a new update entry:

MQ2Say - Add ignore for group/guild/fellowship/raid

This commit adds the ability to ignore say messages from members of your group, guild, fellowship, and raid.

H/T Chatwiththisname for his contribution to MQ2Say. He has been added as a contributing author

MQ2Say - Add ignore for group/guild/fellowship/raid (!412) · Merge requests · RG Creators / LegacyMQ2 · GitLab

This commit adds the ability to ignore say messages from members of your group, guild, fellowship, and raid. H/T Chatwiththisname for his contribution to MQ2Say. He...

gitlab.com

Read the rest of this update entry...

 

[BayouGator]

Webroot is saying MQ2Say.dll has malware and quarantined it after this patch. Also MQ2Rez.dll is still doing it too. FYI

 

[Sic]

Webroot is saying MQ2Say.dll has malware and quarantined it after this patch. Also MQ2Rez.dll is still doing it too. FYI

Here is the source for mq2rez < here >
Here is the source for mq2say > here <

this ai-based antivirus that some of these providers are employing is a bit of an inexact science. sometimes there is no rhyme or reason to it at all.

tl;dr - I would suggest adding your mq2 folder as an exception on your anti-virus

 

[Knightly]

I usually recommend virustotal.com as well, for independent verification. If lots of scanners detect it then you're likely in trouble. If it's only one or two, less so (though the chances on a detection being safe are never 0). But as Sic said, the code is public for these two.

 

[Sic]

I usually recommend virustotal.com as well, for independent verification. If lots of scanners detect it then you're likely in trouble. If it's only one or two, less so (though the chances on a detection are never 0). But as Sic said, the code is public for these two.

Thanks knightly - i couldn't find a quick "general" quote from you like i did from brain, tho i did look

 

[sl968]

As someone who's been through the code review process here, there's 0 chance of malware slipping through the system that's in place for Redguides!

 

[Knightly]

Good sentiment, but you can never be too cautious (and we only review the open source ones through that process -- of which MQ2Rez and MQ2Say are part, as Sic pointed out).

 

[rouneq]

Are there slash commands for the new features or just modify the config? I seem to recall (but can't find) discussion on the changes in another thread that might have provided this info. Or maybe I'm just too tired to properly recollect.

 

[Knightly]

/mqsay help

Should show all the commands

 

[dreamflux]

This is pretty excellent as a means to filter out PC vs NPC says. I don't suppose there would be a clever way to make this able to connect up to mq2discord to relay what is said? Clearly you can put a trigger into the ini for /tell toon hey someone is in camp, but if there was a way to make that tell say "so and so said this" in our camp it would be pretty fancy.

 

[runcade]

This is pretty excellent as a means to filter out PC vs NPC says. I don't suppose there would be a clever way to make this able to connect up to mq2discord to relay what is said? Clearly you can put a trigger into the ini for /tell toon hey someone is in camp, but if there was a way to make that tell say "so and so said this" in our camp it would be pretty fancy.

MQ2discord can already relay /say messages.

 

[dreamflux]

I'm quite aware, but it does ALL says including NPC. This leads to the need for a ridiculously long and ever involving list of filters that could then exclude PC names. This plugin filters out NPC says and relays the say text to a window. There should be a way to fairly easily modify it so that the same say message could be put into a tell from one toon to another for instance.

 

[BrianGragg]

Being able to add in a delay for all say messages for a second or two would be awesome. Right now if I forget it’s on and I’m at a an AoC with another guild it will lock up all my boxes until their guild is logged in.
I know there is an option for suppressing notifications from the same person but I don’t believe that works for back to back say messages from another guild full of people??

 

[Knightly]

This plugin filters out NPC says and relays the say text to a window. There should be a way to fairly easily modify it so that the same say message could be put into a tell from one toon to another for instance.

I think what you're probably looking for is a token you can use to pass to actions. A TLO would probably solve this and then you can do whatever you want with the information.

Being able to add in a delay for all say messages for a second or two would be awesome. Right now if I forget it’s on and I’m at a an AoC with another guild it will lock up all my boxes until their guild is logged in.
I know there is an option for suppressing notifications from the same person but I don’t believe that works for back to back say messages from another guild full of people??

/beep (the default SL put in) is going to freeze you. You can change the action to something else and it will likely not, but the appropriate answer for this is to pause it when you don't want it running. A delay would just spread out your freezing over time.

 

[sl968]

There is a delay command which basically stops new beeps for a defined period of time. /mqsay IgnoreDelay #

 

[BrianGragg]

There is a delay command which basically stops new beeps for a defined period of time. /mqsay IgnoreDelay #

To my knowledge it only delays /says from the same toon. Not the entire raid force that tries to enter an Agent of Change in front of you. When you forget you have it running and they blow up your computer with /say ready.

/beep (the default SL put in) is going to freeze you. You can change the action to something else and it will likely not, but the appropriate answer for this is to pause it when you don't want it running. A delay would just spread out your freezing over time.

I guess I should of rephrased it to be 'ignore' all /says in a time window. Like beep once and then don't beep again no matter the /says for a small time frame. If it already does that and I just screwed up my settings please correct me.

 

[Knightly]

I understand, this probably makes sense as just making the alerts capable of being changed from Per Speaker to global. I'll add an AlertPerSpeaker setting.

 

[sl968]

There is the /mqsay raid on, /mqsay guild on etc.

 

[BrianGragg]

There is the /mqsay raid on, /mqsay guild on etc.

Yeah great features. However they only apply to your own raid / guild. When another raid force / guild comes up to an agent while you have say loaded your screwed until their raid force gets done and your computer gets done catching up.

It leads to me unloading the plugin and forgetting it’s unloaded for when I actually want / need it. Then Isee it’s unloaded and load it back. Go to a raid and bam locked up until they are done again lol.

Hoping knightly takes pity on me and makes a global flag.

 

[Knightly]

Hoping knightly takes pity on me and makes a global flag.

I did, I submitted the MR for it last Friday.

 

[Redbot]

Redbot updated MQ2Say with a new update entry:

mqsay settings

Added command "/mqsay settings". Will output all settings at once.

Read the rest of this update entry...

 

[chrome]

There seems to be a bug where if you add a custom AlertCommand, that it gets overwritten back to default next time you load the game.

AlertCommand=/dex driverCharacter /mcicontrol play "c:\eqsounds\say.mp3"

 

[Knightly]

There seems to be a bug where if you add a custom AlertCommand, that it gets overwritten back to default next time you load the game.

AlertCommand=/dex driverCharacter /mcicontrol play "c:\eqsounds\say.mp3"

Are you using mqnext?

Are you adding the command using the in game commands or by editing the ini file?