Request - [Bounty] C++ Dev Help with MQ2XAssist

[Redbot]

@morisato is having issues with MQ2XAssist,

Work items · RG Creators / Plugins / MQ2XAssist · GitLab

Repository moved to GitHub: https://github.com/redguides/MQ2XAssist

gitlab.com

And I'd like to throw a 10 krono bounty into the pot for a fix.

 

[kaen01]

honestly morisato should discontinue the usage and use dannet obersvers, so much easier for him, and it works much better than the plugin.

 

[Redbot]

10 krono to @kaen01 unless someone has an argument to the contrary

 

[brainiac]

It’s what we’ve all been saying for a while now

 

[kaen01]

yeah i should not get kronos for that
at all

 

[ChatWithThisName]

I can poke it with a stick. No promises though. I've never personally used it.

 

[ChatWithThisName]

Believe I tracked down the issue of blinking on/off xtarget.

[CODE title="Distance Gating" highlight="1"]else if (pAssistSpawn && DistanceToSpawn3D(pAssistSpawn, pXTarget) > 1500)
{
ClearXTargetWithDebugMessage("it's too far away from our assist.", i);
}[/CODE]

This will cleanup XTarget if a spawn is greater than 1500 away, but adding things to xtarget doesn't check distance. So likely being added and then cleared back to back due to inconsistent checks for adding and removing.

I'm testing the changes now so will let you know what the result is. Mori is in the process of trying to force it to happen.

 

[ChatWithThisName]

Mori is currently testing the random things getting stuck on XTarget. So we're going to give him an opportunity to test it at length to ensure it doesn't happen again before I push any changes.

 

[morisato]

Yup testing is Going forward now. hopefully this resolves these issues !

 

[ChatWithThisName]

Issue #2 fixed. https://gitlab.com/redguides/plugins/MQ2XAssist/-/merge_requests/1

Issue #1 commented on. Would need more feedback. https://gitlab.com/redguides/plugins/MQ2XAssist/-/issues/1#note_796183956