What's wrong with my code?

[iforgotmyoldlogin]

	/if (${MeleeOn} && ${Me.AbilityReady["Backstab"]}) /doability "Backstab"

 

[Maskoi]

no quotes

${Me.AbilityReady[backstab]}
/doability Backstab

 

[nostress]

${MeleeOn}? You might want to try ${Melee.Combat}, and take the quotes off backstab on the abilityready. Let me know if that works for you.

 

[nostress]

3 minutes, you beat my post by three minutes! Clearly the time to lookup the mq2melee tlo's has cost me dearly!

 

[iforgotmyoldlogin]

${Melee.Combat} worked, thanks.

 

[iforgotmyoldlogin]

What's wrong with this one?

		/if (${Melee.Combat} && ${Me.AltAbilityReady[Deadeye Discipline]}) /call Cast "Deadeye Discipline" alt

 

[dencelle]

your using deadeye discipline as a AA...

 

[william12]

/if (${Melee.Combat} && ${Me.CombatAbilityReady[Deadeye Discipline]}) /call Cast "Deadeye Discipline" alt

 

[dencelle]

/if (${Melee.Combat} && ${Me.CombatAbilityReady[Deadeye Discipline]}) /call Cast "Deadeye Discipline"

you don't need the alt on there... spell routines auto detects if its a combat ability or a spell...

 

[nostress]

Can't you get away with doing /casting instead of /call cast? /casting is a mq2cast command, I find it much more reliable than spellroutines.inc

Also if this is a holyshit in mq2melee I don't think you can call subroutines in a macro from a plugin without weird stuff happening.

 

[william12]

/if (${Melee.Combat} && ${Me.CombatAbilityReady[Deadeye Discipline]}) /disc "Deadeye Discipline"

would be the best way to do it.

 

[iforgotmyoldlogin]

"You do not seem to have that spell memorized."

/cast "Deadeye Discipline"

 

[nostress]

sorry it should be /disc Deadeye disipline

 

[iforgotmyoldlogin]

Thanks

 

[iforgotmyoldlogin]

/if (${Melee.Combat} && ${Me.AbilityReady[Backstab]} && ${Target.Distance}<16.5) /doability "Backstab"
/if (${Melee.Combat} && ${Me.AltAbilityReady[Deadeye Discipline]}) /disc "Deadeye Discipline"
/if (${Melee.Combat} && ${Me.AltAbilityReady[Kinesthetics Discipline]}) /disc "Kinesthetics Discipline"
/if (${Melee.Combat} && ${Me.AltAbilityReady[Counterattack Discipline]}) /disc "Counterattack Discipline"

Does not /disc at all

 

[Maskoi]

disc = ${Me.CombatAbilityReady[]} /disc
AA = ${Me.AltAbiltiyReady[]} /alt activate or /call Cast
Spell = ${Me.SpellReady[]} /call Cast

/call Cast has to have an #include Spell_routines.inc in your mac

you are trying to use aa for disc doesn't work

 

[william12]

You're seeing our correction but not processing why yours dont work.

${Me.AltAbilityReady[Counterattack Discipline]

${Me.AltAbilityReady refers to an AA when counterattack is not an AA.
${Me.CombatAbilityReady refers to combat disc like Counterattack
${Me.SpellReady refers to spells for classes that have spells.

Take what I've said and look at your code and see where you messed up.

As far as why you're casting them disc in that situation.

Counterattack is a ripo disc like reckless right ? Wouldn't you only cast this when close to death or when you pulled too many mobs ? Wouldn't you want something like.

/if (${Melee.Combat} && !${Melee.DiscID} && ${Me.PctHPs}<10 && ${Me.CombatAbilityReady[Counterattack Discipline]}) /disc "Counterattack Discipline"

This would only use the disc if you're attacking and your health is under 10%. Using it otherwise is a waste especially if you don't have aggro on something.

 

[iforgotmyoldlogin]

apparently its /doability.

Of course, when one problem is solved three more arise. I am getting spammed "You are already using a discipline!". What about an event?

#Event  AlreadyUsingDisc    "You are already using a discipline!"

Sub Event_AlreadyUsingDisc
do nothing
else


	        /if (${Melee.Combat} && ${Cursor.ID} ) /autoinv	
		/if (${Melee.Combat} && ${Me.CombatAbilityReady[Deadeye Discipline]}) /doability "Deadeye Discipline"
		/if (${Me.CombatAbilityReady[Kinesthetics Discipline]} && ${Melee.Combat}) /doability "Kinesthetics Discipline"
		/if (${Melee.Combat} && ${Me.CombatAbilityReady[Counterattack Discipline]}) /doability "Counterattack Discipline"
        	/if (${Melee.Combat} && ${Me.AbilityReady[Backstab]} && ${Target.Distance}<16.5) /doability "Backstab"

	

                    /return
                }

 

[william12]

Add !${Melee.DiscID} to them and its not doability while that will work /disc s the way to go. doability is for backstab

Try

/if (${Melee.Combat} && !${Melee.DiscID} && ${Me.CombatAbilityReady[Deadeye Discipline]}) /disc Deadeye Discipline

 

[iforgotmyoldlogin]

ah nice

 

[iforgotmyoldlogin]

Thanks. DiscID = a number or just DiscID?

 

[william12]

!${Melee.DiscID} will return 0 when you're not using a disc so if its anything higher it wont use it because you're using a disc if its 0 it uses it.

 

[william12]

Here is a great example of it all using my af_ber macros burn routine. This shows plenty of variables you can use to determine when to and when not to use a disc. It doesn't say the disc names because them are defined in the macros ini but you get the idea.

/if (${UseOPFrenzy} && ${Me.CombatAbilityReady[${OPFrenzy}]} && ${Me.PctEndurance}>=5 && ${Target.PctHPs}<98 && ${Me.Combat}) /disc ${OPFrenzy}
/if (${UseVAX} && ${Me.CombatAbilityReady[${VAX}]} && ${Me.PctEndurance}>=5 && ${Target.PctHPs}<96 && ${Me.Combat}) /disc ${VAX}
/if (${UseVolley} && ${Me.CombatAbilityReady[${Volley}]} && ${Me.PctEndurance}>=5 && ${Target.PctHPs}<94 && ${Me.Combat}) /doability "${Volley}"
/if (${UseAOR} && ${Me.CombatAbilityReady[${AOR}]} && ${Me.PctEndurance}>=5 && ${Target.PctHPs}<94 && ${Me.Combat}) /doability "${AOR}"
/if (${UseSS} && ${Me.AltAbilityReady[Savage Spirit]} && ${Me.Combat} && ${NameList.Find[${Target.CleanName}]} && ${Target.PctHPs}<${WhenToBurn}) {
 /alt act 3710
/delay 3s
 /alt act 499
/delay 3s
 /alt act 465
}
/if (${UseBer} && !${Melee.DiscID} && !${Me.AltAbilityReady[Savage Spirit]} && ${Me.CombatAbilityReady[${Ber}]} && ${Me.Combat} && ${NameList.Find[${Target.CleanName}]} && ${Target.PctHPs}<${WhenToBurn}) /disc ${Ber}
/if (${UseCleaving} && !${Melee.DiscID} && !${Me.CombatAbilityReady[${Ber}]} && !${Me.AltAbilityReady[Savage Spirit]} && ${Me.CombatAbilityReady[${Cleaving}]} && ${Target.PctHPs}<${WhenToBurn} && ${NameList.Find[${Target.CleanName}]}) /disc ${Cleaving}
/if (${UseWarcry} && ${Me.CombatAbilityReady[${Warcry}]} && ${Me.Combat} && ${Target.PctHPs}<${WhenToBurn} && ${NameList.Find[${Target.CleanName}]}) /disc ${Warcry}
/if (${UseVehRage} && ${SpawnCount[npc radius 35 zradius 100]}>1 && ${Me.AltAbilityReady[Vehement Rage]} && ${Me.Combat} && ${Target.PctHPs}>40 && ${Target.PctHPs}<${WhenToBurn}) /alt act 800
/if (${UseJugg} && ${SpawnCount[npc radius 35 zradius 100]}>1 && ${Me.AltAbilityReady[Juggernaut Surge]} && ${Me.Combat} && ${Target.PctHPs}>40 && ${Target.PctHPs}<${WhenToBurn}) /alt act 961
/if (${UseThirdspire} && ${SpawnCount[npc radius 35 zradius 100]}>1 && ${Me.AltAbilityReady[Fundament: Third Spire of Savagery]} && ${Target.PctHPs}>40 && ${Me.Combat} && ${Target.PctHPs}<${WhenToBurn}) /alt act 1502
/if (${UseEpic2} && ${Cast.Ready[VengeFul Taelosian Blood Axe]} && ${Target.PctHPs}>40 && !${Me.Buff[Blinding Fury].ID} && ${Target.PctHPs}<90 && !${Me.Moving} && ${Me.Combat}) /casting "VengeFul Taelosian Blood Axe"
/if (${UseEpic2} && ${Cast.Ready[Raging Taelosian Alloy Axe]} && ${Target.PctHPs}>40 && !${Me.Buff[Blinding Fury].ID} && ${Target.PctHPs}<90 && !${Me.Moving} && ${Me.Combat}) /casting "Raging Taelosian Alloy Axe"
/if (${UseBlinding} && ${Me.AltAbilityReady[Blinding Fury]} && !${Me.Song[Strike of Savagery].ID} && ${Target.PctHPs}<98 && ${Target.PctHPs}>40 && ${Me.Combat}) /alt act 610 
/if (${UseBer} && !${Melee.DiscID} && ${Me.CombatAbilityReady[${Ber}]} && ${Me.Combat} && ${SpawnCount[npc radius 20 zradius 20]}>2 && ${Target.PctHPs}<${WhenToBurn}) /disc ${Ber}
/if (${UseCleaving} && !${Melee.DiscID} && !${Me.CombatAbilityReady[${Ber}]} && !${Me.AltAbilityReady[Savage Spirit]} && ${SpawnCount[npc radius 35 zradius 100]}>2 && ${Me.Combat} && ${Me.CombatAbilityReady[${Cleaving}]}) /disc ${Cleaving}
/if (${UseVengeful} && !${Melee.DiscID} && ${Target.PctHPs}>40 && ${Target.PctHPs}<80 && !${Me.Buff[Blinding Fury].ID} && ${Me.Combat} && ${Me.CombatAbilityReady[${Vengeful}]}) /disc ${Vengeful}
/if (${UseVengeful} && !${Melee.DiscID} && ${NameList.Find[${Target.CleanName}]} && !${Me.CombatAbilityReady[${Cleaving}]} && !${Me.AltAbilityReady[Savage Spirit]} && !${Me.CombatAbilityReady[${Ber}]} && !${Me.Buff[Blinding Fury].ID} && ${Me.Combat} && ${Me.CombatAbilityReady[${Vengeful}]}) /disc ${Vengeful}
/if (${UseSS} && ${Me.AltAbilityReady[Reckless Abandon]} && ${Me.AltAbilityReady[Cascading Rage]} && ${Me.AltAbilityReady[Savage Spirit]} && !${Melee.DiscID} && ${Me.Combat} && ${SpawnCount[npc radius 35 zradius 100]}>3 && ${Target.PctHPs}<${WhenToBurn}) {
 /alt act 3710
/delay 3s
 /alt act 499
/delay 3s
 /alt act 465
}
/if (${UseSS} && ${Me.AltAbilityReady[Savage Spirit]} && !${Melee.DiscID} && ${Me.Combat} && ${SpawnCount[npc radius 35 zradius 100]}>3 && ${Target.PctHPs}<${WhenToBurn}) {
 /alt act 3710
/delay 3s
 /alt act 499
/delay 3s
 /alt act 465
}