Request - SK epic turn in

[zeusdraco]

Hello,

I am looking for a simple macro that will target marl upon his pop, turn in the item i need to turn in and origin after.

Anyone know one already made or can create me one pretty plz ?

Thx

 

[tms]

I think the other sk on tlp. standing at him and waiting for pop dont like it if that task is automated by another player.
just my opinion.

beside this. if more than one player use that script, given that he depop after turnin, it may be that your item gets eaten.

 

[zeusdraco]

they actualy using it, i got stolen marl by a lvl 35 sk twice time in a row with that script, then another one came in and got the next one......seem most using it atm.

 

[KronoBro]

The level 35 SK doing the turn is has been there multiple times the past couple of months, I wonder wtf he is even doing?

 

[tarquinn]

A lot of SK's do the quest twice up to that point to get the BP again because it is Best-in-Slot through Kunark. Either he's doing it twice, or whoever owns that SK is doing it over and over just to cockblock people I guess?

 

[zeusdraco]

Yes this is why i need a turn in macro this sk is driving me nuts, well that part of the quest is. anyone able to help ?

 

[nyghteyes]

This is Maskoi's re-write since ubertrade hasn't worked in years. Added your altactivate origin at the end. Make sure you have the right mob and item names in the first 2 declared variables.

Sub main

/declare NPCName string outer MobName
/declare GiveItem string outer ItemGiveName

    :mainLoop
        /if (${Spawn[npc ${NPCName}].ID}) {
            /if (${Target.ID}) /squelch /target clear
            /delay 2s !${Target.ID}
            /squelch /target id ${Spawn[npc ${NPCName}].ID}
            /delay 2s ${Target.Name.Find[${NPCName}]}
            /if (${Target.Name.Find[${NPCName}]}) {
                /echo ${NPCName} found attempting to give him the ${GiveItem}
                /if (${Cursor.ID}) /autoinventory
                /delay 2s !${Cursor.ID}
                /shift /itemnotify in Pack${Math.Calc[${FindItem[${GiveItem}].ItemSlot}-22]} ${Math.Calc[${FindItem[=${GiveItem}].ItemSlot2}+1]} leftmouseup
                /delay 2s ${Cursor.ID}
                /click left target
                /delay 2s ${Window[GiveWnd].Open}
                /if (${Window[GiveWnd].Open}) {
                    /notify GiveWnd GVW_Give_Button leftmouseup
                    /altactivate 331
                    /endm
                }
            }
        }
        /delay 10s
    /goto :mainLoop
/return

Credit goes here

 

[zeusdraco]

Many thx

 

[Hihi]

If it's what you're looking for, click the "Thanks" button on the bottom left of his post. Will give him redcents for contributing.

 

[zeusdraco]

Sub main

/declare NPCName string outer Marl Kastane
/declare GiveItem string outer Blood of Kyrenna

:mainLoop
/if (${Spawn[npc ${NPCName}].ID}) {
/if (${Target.ID}) /squelch /target clear
/delay 2s !${Target.ID}
/squelch /target id ${Spawn[npc ${NPCName}].ID}
/delay 2s ${Target.Name.Find[${NPCName}]}
/if (${Target.Name.Find[${NPCName}]}) {
/echo ${NPCName} found attempting to give him the ${GiveItem}
/if (${Cursor.ID}) /autoinventory
/delay 2s !${Cursor.ID}
/shift /itemnotify in Pack${Math.Calc[${FindItem[${GiveItem}].ItemSlot}-22]} ${Math.Calc[${FindItem[=${GiveItem}].ItemSlot2}+1]} leftmouseup
/delay 2s ${Cursor.ID}
/click left target
/delay 2s ${Window[GiveWnd].Open}
/if (${Window[GiveWnd].Open}) {
/notify GiveWnd GVW_Give_Button leftmouseup
/altactivate 331
/endm
}
}
}
/delay 10s
/goto :mainLoop
/return

I target the npc fine but he doesnt give the item at all? i am missing a plugin loaded or something ?

Thx

 

[LamahHerder]

You probably need to put quotes around both names in the declare
You sure altactivate 331 = origin?

I dont see any non base commands
/itemnotify /click /autoinv /altactivate are all base stuff

That has many 2s delay's thou, at a minimum its going to take 8seconds to do turn in and probably 18seconds since there is a 10s loop delay

 

[zeusdraco]

The 18 sec delay sure wouldnt make it as the lvl 35 macro despawn the npc within 3 second.... but even then, i just cant get it to work properly using the code nyght provided, someone got an idea how to optimise and make it work ?

- - - Updated - - -

Lets say i keep the item on the cursor, i can skip lots of sec delay to turn in

A check to see the npc if up, targeting him and opening trade and clicking give. If someone can optimise something working in that way plz

 

[LamahHerder]

Test this with something else first as it is untested and I dont know why i wrote it

Sub Main

/declare NPCName string outer "MobName"
/declare ItemName string outer "ItemGiveName"

:checkSpawnLoop
/if (${Spawn[${NPCName} npc].ID} && ${Target.ID}!=${Spawn[${NPCName} npc].ID}) {
    /squelch /target id ${Spawn[${NPCName} npc].ID}
    /goto :checkDistance
}

:checkCursor
/if (!${Cursor.Name.Equal[${ItemName}]}) {
    /autoinv
    /itemnotify ${FindItem[${ItemName}].InvSlot} leftmouseup
}

/goto :checkSpawnLoop

:checkDistance
    /if (${Target.Distance}<5) /stick 5

:giveItem
/if (${Target.ID}==${Spawn[${NPCName} npc].ID} && ${Cursor.Name.Equal[${ItemName}]} && ${Target.Distance}<5) {
    /click left target
}
/delay 5
/goto :giveitem

:waitTradeWnd
/if (${Window[TradeWnd]}) {
    /notify TradeWnd TRDW_Cancel_Button LeftMouseUp
    /delay 2s
    /goto :gtfo
}
/delay 5
/goto :waitTradeWnd

:gtfo
    /alt activate 331
    /delay 120s
    /camp desktop

 

[zeusdraco]

Ok gonna test this out when i get back from job

- - - Updated - - -

Wow M0nk you close! , it target the temp named i gave him as name and put the item in trade, he doesnt press give *** the give part of the code doesnt work *** unless i need to load a plugin ?

- - - Updated - - -

Well if i dont have the item on my cursor he wont go get it in my inventory, but that doesnt bother me , i can have it on my cursor right away.

When i have the item on my cursor, he target the name properly, open trade window properly with the item in, but doesnt press give

 

[nyghteyes]

Are you using a custom UI? Because it can screw with window commands.

/notify GiveWnd GVW_Give_Button leftmouseup

 

[zeusdraco]

I am using the default UI right now but windored mode tough

- - - Updated - - -

I fixed it by adding a delay before the turn in, it was too fast or something. thx everyone for the help

 

[LamahHerder]

Should work better

Sub Main

/declare NPCName string outer "MobName"
/declare ItemName string outer "ItemGiveName"

:checkSpawnLoop
/if (${Spawn[${NPCName} npc].ID} && ${Target.ID}!=${Spawn[${NPCName} npc].ID}) {
    /squelch /target id ${Spawn[${NPCName} npc].ID}
    /goto :checkDistance
}

:checkCursor
/if (${Cursor.Name.NotEqual[${ItemName}]}) {
    /autoinv
    /itemnotify "${ItemName}" leftmouseup
}

/goto :checkSpawnLoop

:checkDistance
    /if (${Target.Distance}<10) /stick 10

:giveItem
/if (${Target.ID}==${Spawn[${NPCName} npc].ID} && ${Cursor.Name.Equal[${ItemName}]} && ${Target.Distance}<12) {
    /click left target
}
/delay 5
/goto :giveitem

:waitTradeWnd
/if (${Window[TradeWnd]}) {
    /notify TradeWnd TRDW_Cancel_Button LeftMouseUp
    /if !${Window[TradeWnd]} /goto :gtfo
}
/delay 5
/goto :waitTradeWnd

:gtfo
    /alt activate 331
    /delay 120s
    /camp desktop

 

[KronoBro]

BTW on Ragefire the level 35 responded to me the other day that he is selling the MQ of SK epics for 30 krono which is why he does it so often.

 

[etherealmist]

Yeah, setting up a macro is about the only way you could get your turn in completed a month ago. Not sure what the situation is now, or if any SKs are waiting in line like they were.

My favorite moment in Kunark so far on the TLP is watching 3 SKs bicker back and forth trying to block each other from getting the turn in. Having druids treeform, having ogres and enchanters turn into ogres. All the while, I was using a turnin macro. Marl spawned, 1 second later I had my turn in done. I watched for about 30 minutes while they continued to fight. I left, and about an hour later one of them sent me a tell saying "grats".

 

[xilo15]

When i run this script it returns: "Unmatched bracket or invalid character following bracket found in index: handin.mac@7 (Main): /if (${Spawn[${NPCName} npc].ID} && ${Target.ID}!=${Spawn[${NPCName} npc].ID}) {"

 

[riot]

Delete the last {

- - - Updated - - -

If it still errors out then I'm guessing the { was supposed to be a }.

 

[xilo15]

Theres an equal amount of { and } in monks code. Not sure where the issue is.

 

[mroutlaw]

anyone got a final version of this that works? I'm having same issues as above poster

- - - Updated - - -

cmon some one has to have this working lol

 

[nyghteyes]

Dev's

Is

${Spawn[${***} npc].ID}

still valid?

 

[mroutlaw]

"Unmatched bracket or invalid character following bracket found in index: handin.mac@7 (Main): /if (${Spawn[${NPCName} npc].ID} && ${Target.ID}!=${Spawn[${NPCName} npc].ID}) {" this still happening not sure how one would even fix this but I keep getting it

 

[nyghteyes]

"Unmatched bracket or invalid character following bracket found in index: handin.mac@7 (Main): /if (${Spawn[${NPCName} npc].ID} && ${Target.ID}!=${Spawn[${NPCName} npc].ID}) {" this still happening not sure how one would even fix this but I keep getting it

Try this, I dont think it needs to call it as an npc.

Sub Main

/declare NPCName string outer "MobName"
/declare ItemName string outer "ItemGiveName"

:checkSpawnLoop
/if (${Spawn[${NPCName}.ID}] && ${Target.ID}!=${Spawn[${NPCName}].ID}) {
    /squelch /target id ${Spawn[${NPCName}].ID}
    /goto :checkDistance
}

:checkCursor
/if (${Cursor.Name.NotEqual[${ItemName}]}) {
    /autoinv
    /itemnotify "${ItemName}" leftmouseup
}

/goto :checkSpawnLoop

:checkDistance
    /if (${Target.Distance}<10) /stick 10

:giveItem
/if (${Target.ID}==${Spawn[${NPCName}].ID} && ${Cursor.Name.Equal[${ItemName}]} && ${Target.Distance}<12) {
    /click left target
}
/delay 5
/goto :giveitem

:waitTradeWnd
/if (${Window[TradeWnd]}) {
    /notify TradeWnd TRDW_Cancel_Button LeftMouseUp
    /if !${Window[TradeWnd]} /goto :gtfo
}
/delay 5
/goto :waitTradeWnd

:gtfo
    /alt activate 331
    /delay 120s
    /camp desktop