Semi-AFK Monk Skillup Macro Help Please (1 Viewer)

[Funkalicious]

Ok, here is an attempt I've made to create a macro I can run to skill up my monks while semi-AFK against a pet on another account. I've mostly pieced it together from some of this and some of that I've found while looking at other macros. What I'd like it to do is:
1. Train special melee attacks against a pet placed on hold.
2. train FD, mend, etc
3. since my monk is iksar, might as well let him forage some while I'm there anyhow
4. most importantly, what I'm trying to do and having the most difficulty in is having it check to see if the ability is ready, and whether that skill is already maxed or not.

here's what I have:

|-----Usage: /mac monkskills


#turbo
#Event Zoned "#*#LOADING#*#"
#Event Zoned "#*#You have entered#*#"


Sub Main

/declare Maxskill int outer

/varset Maxskill ${Math.Calc[(${Me.Level}*5)+5]}

/alert add 2 pc ${Me}
/alert add 2 pc playername
/alert add 2 pc playername

:loop

	/call playercheck
	/call GMcheck
	/doevents
/echo sneak code

  /if (${Me.AbilityReady[Sneak]} && (${Me.Skill[Sneak]}<${MaxSkill})) { 
    /doability "Sneak"
	/echo Sneaking... 
    /delay 10 
    /doability Sneak 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents
/echo beg code

  /if (${Me.AbilityReady[Begging]} && (${Me.Skill[Begging]}<${MaxSkill})) { 
    /doability "Begging"
	/echo Begging... 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents

  /if (${Me.AbilityReady[Forage]}) { 
    /doability "Forage"
	/echo Foraging... 
    /delay 3s
	/Autoinventory 
  }

	/call playercheck
	/call GMcheck
	/doevents

  /if (${Me.AbilityReady[Tail Rake]} && (${Me.Skill[Tail Rake]}<${MaxSkill})) {
    /doability "Tail Rake"
	/echo Tail Rake... 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents

  /if (${Me.AbilityReady[Dragon Punch]} && (${Me.Skill[Dragon Punch]}<${MaxSkill})) {
    /doability "Dragon Punch"
	/echo Dragon Punch... 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents

  /if (${Me.AbilityReady[Round Kick]} && (${Me.Skill[Round Kick]}<${MaxSkill})) {
    /doability "Round Kick"
	/echo Round Kick... 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents

  /if (${Me.AbilityReady[Kick]} && (${Me.Skill[Kick]}<${MaxSkill})) {
    /doability "Kick"
	/echo Kicking... 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents

  /if (${Me.AbilityReady[Flying Kick]} && (${Me.Skill[Flying Kick]}<${MaxSkill})) {
    /doability "Flying Kick"
	/echo Flying Kick... 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents

  /if (${Me.AbilityReady[Tiger Claw]} && (${Me.Skill[Tiger Claw]}<${MaxSkill})) {
    /doability "Tiger Claw"
	/echo Tiger Claw... 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents

  /if (${Me.AbilityReady[Eagle Strike]} && (${Me.Skill[Eagle Strike]}<${MaxSkill})) {
    /doability "Eagle Strike"
	/echo Eagle Strike... 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents   

  /if (${Me.AbilityReady[Feign Death]} && (${Me.Skill[Feign Death]}<${MaxSkill})) { 
    /doability "Feign Death"
	/echo Feigning Death 
    /delay 30 
    /stand 
  }

	/call playercheck
	/call GMcheck
	/doevents  

  /if (${Me.AbilityReady[Mend]} && (${Me.Skill[Mend]}<${MaxSkill})) { 
    /doability "Mend"
	/echo Mending 
    /delay 10 
  }

	/call playercheck
	/call GMcheck
	/doevents 

  /if (${Me.AbilityReady[Intimidation]} && (${Me.Skill[Intimidation]}<${MaxSkill})) { 
    /doability "Intimidation"
	/echo Attempting to Intimidate my target 
    /delay 100 
  }

	/call playercheck
	/call GMcheck
	/doevents  

  /if (${Me.AbilityReady[Disarm]} && (${Me.Skill[Disarm]}<${MaxSkill})) { 
    /doability "Disarm"
	/echo Attempting to Disarm my target 
    /delay 10 
  } 

/goto :loop 


   Sub playercheck
	/if (${Spawn[pc noalert 2 radius 5000].ID}) {
	/echo Playerdetection tripped...
	/beep
	/beep
	/echo ...ending macro
	/keypress up
	/if (${Me.AbilityReady[Feign Death]}) /doability "Feign Death"
	/endmac 
   }
   /return

   Sub GMcheck
	/if (${Spawn[gm].ID}) {
	/echo GM DETECTED IN ZONE
	/echo ENDING MACRO NOW!!!
	/beep
	/beep
	/beep
	/keypress up
	/endmac
	/unload
	/q
   }
   /return

   Sub Event_Zoned
	/echo You must have died!
	/beep
	/pause 2
	/beep
	/echo camping and ending macro now... get a rez later
	/sit
	/camp desktop
	/endmac
	/unload
	/q
   /return

I started adding in the echos to try to figure out what was going on with the mac and where. What it is doing atm is starting, giving the sneak and beg echos, forage echo once, then loops the sneak/beg echos endlessly. All this is happening but the monk stands there doing nothing. This is my first real attempt to try to put something together on my own so any help would be very appreciated.

 

[Funkalicious]

Would someone please take a look to see what I've done wrong here? I'm sure I screwed up on the syntax somehow, but after looking through several macs for help, and reading the wiki, still no luck.

 

[Roguish]

I found Me.AbilityReady to not work properly for some reason. In my Rogue macro I had to change this to Me.Sneaking, Me.Invis (for hiding) and such.

Have you thought about simply using MQ2Combat to auto all your skills and stick to the pet and making a macro that did everything else you needed?

 

[Funkalicious]

yeah, tried it, but the main reason I was hoping to get this working is so that the macro can check to see if the various skills are at max or not, thus only training the skills needed rather than spamming kick forever and ignoring all the rest.