Request - Mage Pet Toys scripting

[B_I_G__D_A_D_D_Y]

For any Dev or author of scripts, plugins, or macros that attempt to automate Mage pet weapon distribution...


PLEASE FOR THE LOVE OF GOD put an /autoinventory and a /stopforage command early in the routine!


If there is something already on the cursor when you enter the routine OR if you forage something while in the middle of the routine then it's BORKED and you have to start over!


Thanks!!!

/rant off

 

[Redbot]

lol @ctaylor22 @morisato

 

[Medicman]

For any Dev or author of scripts, plugins, or macros that attempt to automate Mage pet weapon distribution...


PLEASE FOR THE LOVE OF GOD put an /autoinventory and a /stopforage command early in the routine!


If there is something already on the cursor when you enter the routine OR if you forage something while in the middle of the routine then it's BORKED and you have to start over!


Thanks!!!

/rant off

What macro or plugin are you talking about specifically???

 

[Lemons]

Stopforage is on you, not the macro writer.

Checking the cursor is on the macro writer though.

 

[B_I_G__D_A_D_D_Y]

Stopforage is on you, not the macro writer.

Checking the cursor is on the macro writer though.

Yes, I agree with you mostly. I will however say that Pet Toys are a constant source of trouble posts on these forums. There are many things that can break it. Making them more user friendly wouldn't be a bad thing. Ideally, all the little things that can break the routine should be addressed in some manner even if only in a message to the user.

On my own I've implemented a social button that disables all movement commands and now also stops autoforaging before invoking the /pettoysplz command. Plus I modify the current macro to add the commands mentioned in the first post.

I find that sometimes my mage will be in the buff routine and casting the Cauldron of Many when the Pet Toys command is issued. The Cauldron will leave an item on the cursor most times and of course the macro is programmed to leave it there for 15 seconds. Then the Pet Toys routine can't even open the spell book to begin making toys and it inevitably fails.

And as it stands now, each and every new user of either KissAssist or MuleAssist has to learn all these failure modes on their own and how to fix them. It's almost like a rite of passage for new MQ users.

 

[ctaylor22]

From what I can tell MQ2AutoForage does NOT have a TLO. Without a TLO to check the status on AutoForge. The macro would end up turning on autoforage for those that have the plugin loaded and turned off. I can check if the plugin is loaded, but I don't see a way to check if AutoForage is on, so when it gets paused, The macro will also un-pause. Another way to look at this is, knowing when it is turned off, so the macro knows NOT to turn it on.

 

[AmericanNero]

I took it upon myself to improve / fix KA12 pet equip routine. I'll post a cut paste. In software, there is a strong tendency to silo issue responsibility, however, the big picture is the user simply wants the damn thing to work, and lead devs point fingers at who they think should do it. A simple cursor check and a stopcast is a reasonable request imo.

 

[hellfyre]

A cursor check I'd agree with but foraging isn't even in the macro. It's in a plugin that is separate and should be on the user to turn it off and on as needed.

 

[B_I_G__D_A_D_D_Y]

A cursor check I'd agree with but foraging isn't even in the macro. It's in a plugin that is separate and should be on the user to turn it off and on as needed.

Yes, that's a valid argument. So is @ctaylor22 's! There isn't a clean solution. But it still remains one of those situations that nearly every new user will stumble across since I think nearly everyone bots a mage. For the users who Search and try to find solutions this thread may provide the insight they need to fix the problem on their own.

I maintain a "delta" file of changes I need to make to production macros. Most of my delta file pertains to Pet Toys!

 

[ctaylor22]

I am in the Process of reworking the PetToys routine. One of the things I am adding is the cursor check, everyone is mentioning. This change/fix is not as simple as just adding an /autoinventory. One of the things that the PetToys routine does is figures what open BAG slot is going to be used. So this whole /autoinventory thing has to got BEFORE the /call OpenInvSlot otherwise it will still be broken. To fix this properly and not just patch it is requiring changes to be made to the OpenInvSlot routine as well. A lot of the issues are having to do with not only checking if there is something on the cursor, but after dropping the item into your inventory. Checking if your inventory is now FULL.

@B_I_G__D_A_D_D_Y Look at what you started.

 

[B_I_G__D_A_D_D_Y]

@B_I_G__D_A_D_D_Y Look at what you started.

I'm truly sorry. I'm just amazed how many seemingly minor things can break Pet Toys. I hadn't even thought about issues like not having any inventory space. Of course now that I've personally figured out nearly every method the routine might fail I actually don't need the fixes for myself. I'm just being a squeaky wheel for the newbies who follow along behind!

 

[hellfyre]

And for the record not everyone bots a mage. I benched all my casters years ago and they are still gathering dust. All melee no pet toys needed

 

[ctaylor22]

@hellfyre is my new best friend.

@B_I_G__D_A_D_D_Y I have been working on pettoys on and off for a while, and was aware of most of the issues. It's just every time I would start working on it, I would run into another problem and be like. DAMN I don't have time for this right now, and just put it on the back burner. That PetToys1 you mentioned to me in a PM. That's me putting it on the back burner.

 

[B_I_G__D_A_D_D_Y]

And for the record not everyone bots a mage. I benched all my casters years ago and they are still gathering dust. All melee no pet toys needed

I'm boxing ancient accounts I've had for years. I'm sad to admit I've never actually even created a zerker and my rogue was a bazaar bot I Hero'd in order to work on Poisonmaking skill!

I did however level a monk up to 105 but that was pre-mq2 and it was a real drag having to mash buttons constantly in order to get a little dps going. So my bard is the closest thing I have going to melee except for my SK tank...