• You've discovered RedGuides, an EverQuest multi-boxing and scripting community 🧙‍♀️⚙️. We want you to play several EQ characters at once, come join us and say hello! 👋

  • A TLP without truebox has thawed (Very Vanilla ready)
    Frostreaver

Problem - "mage" issues from recent patch

D

dewdew

Level 2
Joined
May 21, 2020
RedCents
34¢
Version of KissAssist.mac?
12
When did your problem start?
6/18
Character Role?
  1. Tank
  2. Hunter
What class is having this issue?
  1. Warrior
How often does this issue occur?
Always
Can you reproduce the issue?
yes
The recent patch changed the SClassInfo / ClassInfo tags for mage/magician, and now when I run KA and a mob has the word "mage" in the name, it throws a warning. I searched the macro for "mage" and "spawnsearch" with no results. I am assuming it is due to ${SpawnCount[${vstStr1} radius ${MaxRadius} zradius ${MaxZRange} targetable ${SearchType}]}>${PullMaxCount} or something simlar, but I cannot figure out how to get around this warning. KA still functions but just throws warnings.

1781792588358.png
 
Sort by date Sort by votes
dewdew said:
The recent patch changed the SClassInfo / ClassInfo tags for mage/magician, and now when I run KA and a mob has the word "mage" in the name, it throws a warning. I searched the macro for "mage" and "spawnsearch" with no results. I am assuming it is due to ${SpawnCount[${vstStr1} radius ${MaxRadius} zradius ${MaxZRange} targetable ${SearchType}]}>${PullMaxCount} or something simlar, but I cannot figure out how to get around this warning. KA still functions but just throws warnings.

View attachment 77630
Click to expand...
well kiss would need to be updated. the warning says it is a deprecation - so it is still going to function as it did before - but warn that there was a deprecation.

there's nothing for you to fix (unless you edited your kiss, which would get overwritten next time you patched)
 
Upvote 0 Downvote
Sic said:
well kiss would need to be updated. the warning says it is a deprecation - so it is still going to function as it did before - but warn that there was a deprecation.

there's nothing for you to fix (unless you edited your kiss, which would get overwritten next time you patched)
Click to expand...
I would gladly edit my kiss if i could figure out what to edit even if its just commenting out a line. I dont overwrite my macros from patch so while i appreciate the warning, its not a concern for me.

any help with what to edit out until a real fix is appreciated.
 
Upvote 0 Downvote
1781797410025.png
Best place I could find without actually testing everything was the spawn count for 'eye of' checking in validate target.

Set up the above test just to prove the second part of the If isn't short circuited and still triggering the issue.

Short answer: comment out line ~983 of kiss assist. Looks like this:
/if (${MobName.Find[eye of]} && ${SpawnCount[pc ${MobName.Right[${Math.Calc[${MobName.Length}-7]}]}]}) /return Spell-Eye-PC

This just reminded me of how lucky we are to have Lua now.
 
Upvote -1 Downvote
bytebite said:
View attachment 77633
Best place I could find without actually testing everything was the spawn count for 'eye of' checking in validate target.

Set up the above test just to prove the second part of the If isn't short circuited and still triggering the issue.

Short answer: comment out line ~983 of kiss assist. Looks like this:
/if (${MobName.Find[eye of]} && ${SpawnCount[pc ${MobName.Right[${Math.Calc[${MobName.Length}-7]}]}]}) /return Spell-Eye-PC

This just reminded me of how lucky we are to have Lua now.
Click to expand...
tyvm for the reply, I will test this!
 
Upvote -1 Downvote
why the heck is spawn search even checking for mage when there is never been a mage class in eq, its always been Magician and or MAG

its not a kissassist issue, its a spawn search issue, it treats mage like a class and not a name like it should, so they probably fixed it, and having a gnome mage on target gets you into that bit
 
Upvote 0 Downvote
It's checking for "Does my targets name start with 'eye of' and do the right most characters starting from the 7th index contain a PC name?

So it is asking, is my target "eye of PCNAME". But the target is "a gnome mage" so it turns into SpawnCount[pc mage]

I just looked over kiss and looked for mobname being used in a spawn search. Didn't actually test this.
 
Upvote 0 Downvote
yes but spawn search should not treat mage as a class tag, it should only treat it as a name, but yes with a gnome mage you gonna hit that check, but i thought eye of zomm was just that and not eye of bytebite
 
Upvote 0 Downvote
1781800883871.png To add to this discussion, I confirmed that it is indeed the target name thats causing this, and not the class because this target did not cause any warnings. I still have not gotten around to testing the fix.
 
Upvote 0 Downvote
1781801748110.png

spawn search needs this tag to even search by class, anything other than is treated as name

1781801796220.png

so technically

${SpawnCount[PC Magician]} should only count players with the name magician


so something changed in spawn search.
 
Upvote 0 Downvote
Upvote 0 Downvote
kaen01 said:
but it should never have reacted to that in the first place, mage is not class, pc mage is not looking for class either
Click to expand...
From the perspective of MacroQuest -- The "magician" class was never "magician" it was: mage or MAG. It is NOW magician and if you do a class search for mage it will tell you that doing that is deprecated.

There is (probably) a quirk in spawnsearch where that name was always treated as a keyword. If you wanted to search for a pc with the name of "mage" in it, you needed more than just "mage" because "mage" is a keyword. Think of it the same way you would try to search for an NPC with the word "class" in it. If you just search "class" then you're going to trigger the keyword because it's all just text.

So, the issue here -- as far as I can tell -- is in kissassist (and it always was, kissassist always did it this way, it just now TELLS you that it's doing it this way because the keyword is deprecated). If there's another example someone can give me that doesn't make sense, I can look at it, but everything I'm seeing here makes sense.

Note that similarly, doing this on "wizard" or any other class will also hit the class keyword, and it always would, it was just doing it silently before.
 
Upvote 0 Downvote
bytebite said:
I don't disagree. I'm just saying Kiss is using the mob name and it creates a collision with a very old line of code that now has a warning as of the last build. Mage and Shadow Knight have had a special place for years. Right now, pc mage works to get pc magicians just fine and has for years.

EDIT: See here for the change last week. https://github.com/macroquest/macroquest/commit/242aea8ace8628ef42a1b89156061fae1cb8f0b0
Click to expand...
someone probably has to update it to use spawn id instead of name when the name has mage in it.
 
Upvote 0 Downvote
i understand knightly ,but if we follow the instructions on how to use spawn search, using a class word like ranger or wizard in by itself does not trigger a class search, but triggers a name search, or atleast it should

and in this case theere is no CLASS tag to signify we are looking for a class, so it should be treated as a name and should not trigger any CLASS related things.
 
Upvote 0 Downvote
kaen01 said:
i understand knightly ,but if we follow the instructions on how to use spawn search, using a class word like ranger or wizard in by itself does not trigger a class search, but triggers a name search, or atleast it should

and in this case theere is no CLASS tag to signify we are looking for a class, so it should be treated as a name and should not trigger any CLASS related things.
Click to expand...
The functionality hasn't changed, but I think the assumption here is incorrect.

You could always do a spawnsearch for "mage" and it would pull the class (you can test it now by doing just "wizard" without anything else and see that it is a class search).

The functionality of how it works didn't change -- and because of the way that arguments are parsed (it's all text) SpawnSearch is basically doing (and has always been doing) a "best guess" search on whether you mean a keyword or not. There's nothing to differentiate the difference in spawnsearch when it comes to keywords or not keywords other than spawnsearch assumes you mean a keyword.
 
Upvote 0 Downvote
You must log in or register to reply here.
Problem - "mage" issues from recent patch
Next unread thread 🦁

Users who are viewing this thread

Total: 1 (members: 0, guests: 1)
Back
Top
Cart

Cart

Total -