Macro: AdvTrader.mac

[EvenLessSpam]

Name:
AdvTrader.mac


Description:
Macro for controlling your trader. It has a lot of features for allowing multiple users of the AdvTrader bot.

To use you must manually add at least 1 user in the ini file with userlevel 3 (Master). For more help just use the !help command from any character added to the userlist.


Changes:
1.0.0

• Initial release.

1.0.1

• Fixed so that items would be added to traderlist after running Underbid.

1.1.0

• Fixed !setprice with a bit of sanity checking.
• Changed output of pricecheck to give same information on fewer lines.
• Added optionable auto-setprice on under-/overbid. See !help !underbid
• Added !reload (or !restart) command for restarting the macro. Only really usefull during development.

1.2.0

• Added !free command, which reports number of free inventory/trader slots.
• Added !tmpprice command, which will set the price on specied item in the BazaarWnd right away, untill next !underbid.
• Fixed (hopefully) a bug where the script would hang in a ClearField loop

Credits:

• ebs2002 on MacroQuest2 forums
  For the inspiration for the pricechecking and underbidding feature.
• Anubis on MacroQuest2 forums
  For the inspiration for the "remote control" idea.

Todo:

• Add !report command. Give a list of every item currently being sold by AdvTrader, with the current price and saved SellMin/SellMax prices. One line/tell per item. Should figure out automatically whether to report for barter or trader (How? Check if BarterWnd is open?) Should I just remove the barter features completely (except for pricecheck)?
• Add timer for re-enabling trader if disabled. Operators (level 2) should not be able to permanently turn off tradermode. Masters (level 3) should be able to turn off tradermode permanently.
• Maybe add auto overbid/underbid at certain intervals?

Feel free to vote me towards that GP2X if you like this macro


AdvTrader.mac
Attached below.

Remember to change the CharacterNameGoesHere to whatever character is the master of the traderbot.
AdvTrader.ini

[Userlist]
; 3 = Master.
;	Can do everything Operators can do.
;	Can make the bot end the AdvTrader macro.
;	Can retrieve money/items.
;	Can add/modify users.
;
; 2 = Operator
;	Can change min/max prices on items.
;	Can trade new items to be sold
;	Can force overbid (barter)/underbid (trader).
;	Can set tradermode on/off.
;	Can set AFK.
;	Can check money.
;
; 1 = User
;	Can do pricechecks.
;
CharacterNameGoesHere=3

 

[king007]

this macro works pretty good however cannot get bot to respond to help !command, or setprice command and can we get it to automate the check price then set lower price loop that would be great to automate the competition?? just some thaughts other than that it works sort of

 

[EQManiac]

Automation can cause headaches. Imagine two guys using the same script

 

[EvenLessSpam]

Aye, as EQManiac said it can cause problems if being automated.
Sure it will never get lower than SellMin, but.. Maybe I'll add it at a later time..

Both the help and the setprice command works fine here, I've made no changes to my macro compared to the one posted here.

"/tell TraderBot !help !setprice" that will give you the syntax (and an example) on how it should look.

I'll write up a better presentation when I get /unlazy so everyone will know what this macro is all about. Also a few features that I'm thinking about adding (so tired I can't remember what they were though, so I'll have to come up with them again )

The thing I use the most is actually the !pricecheck command.. Doing some tradeskilling? Need something and too lazy to run to the bazaar to check? "/tell TraderBot !pc Item Name". Quick way to see if the item is even for sale and what the price level is. I also give close friends access to that command (userlevel 1)

 

[king007]

thank you in that case It works good the automation that I was thinking about was some delay like auto check/set price say every hour or so. but ur right it could get troublesome (10 peeps using this all eventually give their wares away free) so I understand thanks good Mac. :p

 

[TSPlayer62]

I hope some of you use this on Zek so I can run through the bazaar saying !setprice and change your AoNs to 1 plat

 

[EvenLessSpam]

I hope some of you use this on Zek so I can run through the bazaar saying !setprice and change your AoNs to 1 plat

You just do that It won't work unless they have added you to the userlist with at least level 2. (There are 3 levels: 1 = User, 2 = Operator, 3 = Master).

 

[EvenLessSpam]

10 peeps using this all eventually give their wares away free

It will never go below your SellMin price, but everyone running it fully automatic would always sell at their minimum price then, sooo... This is however not the reason I don't like it automated; it's because it's too easy to track if you update way every hour.. I could sit around in bazaar and lower my prices then watch who's prices are lowered on the minute every hour and pin them down as users of this macro

 

[EvenLessSpam]

Updated

 

[Mandrake]

Link isn't working

 

[EvenLessSpam]

Link isn't working

What link? Link in credits? Go get MQ2 VIP!

 

[Mandrake]

What link? Link in credits? Go get MQ2 VIP!

The link you made to the advtrader.mac up top in original post.

Attched file AdvTrader.mac 46.8 kb

When I go to download or view it just goes to a new screen with a little x box in the corner links in other messages work so i know am not blocking it.

 

[Mandrake]

Attached Files AdvTrader.mac (46.8 KB, 12 views)

Ok I right clicked and did a save as and it worked, but clicking on the link just got me a new webpage with an X in the corner

Should I just remove the barter features completely (except for pricecheck)?

I wouldn't there are probably folks out there that have a buyer up that are doing so for multiple people so I would keep it.

Possible features to add
1. Set the ini so that you can Designate an owner or master then be able to list their alts under them so that next feature would work.

2. Give it the ability to run an ini so that it knows who gave it what and thereby an operator can ask for plat or an item and get only the plat or items they dropped off that have sold not all of it like a master could and also that way 1 operator could not lower the price on another operator's items. It would require that folks clear everything off the buyer or seller but would add a lot more convience to it. and operator plat checks would only report their plat not how much total the vendor has.

3 Allow Master to issue a cleanup command because the item list would continue to grow as stuff sold and new items were added, A master would know when there wasn't any plat on the vendor to mess up a clean up and then the bot could remoe all items in the list that were no longer there. But games ini would still have the last saved price in it for adding an item back at a later time.

I know Flame me for the big wish list but figure i might as well put in my thoughts.

 

[EvenLessSpam]

Possible features to add
1. Set the ini so that you can Designate an owner or master then be able to list their alts under them so that next feature would work.

Probably won't happen, I'll give the reason further down

2. Give it the ability to run an ini so that it knows who gave it what and thereby an operator can ask for plat or an item and get only the plat or items they dropped off that have sold not all of it like a master could and also that way 1 operator could not lower the price on another operator's items. It would require that folks clear everything off the buyer or seller but would add a lot more convience to it. and operator plat checks would only report their plat not how much total the vendor has.

I've been thinking about possible ways to do this, as have Anubis for the version he wrote on MQ2VIP, but so far I've kept coming back to why it wouldn't work:

• Multiple "users" can have similar items and as such should be able to set the price for the item they add. Problem here comes that they will set the price for all the other users as well (that have the same item on the trader).
  Who should decide the price?
• Tracking what is added is much easier said than done. You can't capture events in the bazaar window to check was bought and how much the item was sold for. Also tracking what you recieve and from who is a bit hard to do, especially with stacked items (you can read the "offered you" events but will not show how many in a stack).
  
  Now a possible way to do this would be to constantly keep track of what is in the traders inventory and cash. Then when something is bought (hence removed from inventory while cash increases, and is not done with !give command) it will remove the items gone from inventory from the relevant user and add the cash to their account. This would require a cumbersome (at least I think so) routine checks against an INI file everytime there's a change in cash and/or items and every item (and amount of cash) should be tracked per user/account. A bit much IMO Anyway, another problem arises. If more users have the same item, who should the items/cash be updated for first?
  
  All the previous reservations aside, I'll be thinking about if and how this could be implemented

3 Allow Master to issue a cleanup command because the item list would continue to grow as stuff sold and new items were added, A master would know when there wasn't any plat on the vendor to mess up a clean up and then the bot could remoe all items in the list that were no longer there. But games ini would still have the last saved price in it for adding an item back at a later time.

I'm not sure I understand your intentions here? Currently the only list maintained is what minimum and maximum prices should be on any give item, which there's really no need to remove or cleanup except to update min/max prices if/when the market change. If you're thinking about a possible list for your suggestion #2 then I would say that such a list would be updated/cleaned continuously as items are sold/removed or added.

I know Flame me for the big wish list but figure i might as well put in my thoughts.

God no, no flames Your #2 is something that I have thought about, I just still don't have a good way to track items and cash that way. You #1 actually got me thinking a bit about having accounts (or groups, which encompasses 1 or more users) rather than users, again something I'd have to think on how to best implement.

 

[Mandrake]

Multiple "users" can have similar items and as such should be able to set the price for the item they add. Problem here comes that they will set the price for all the other users as well (that have the same item on the trader).
Who should decide the price?

Well since they are sharing a trader so they don't have to have a 2nd account of their own running it would require being a Co-op where they agree on the new price change.

Tracking what is added is much easier said than done. You can't capture events in the bazaar window to check was bought and how much the item was sold for.

Since we can read ini's what about txt files every time an item is sold it is recorded in the bzr_toonname_servername.txt file in the eq logs directory would just be a simple matter of scanning the last few lines of the file if multiple items were bought one after the other since opening it while someone buys something make eq create a new one. so just having it wait 1 minute after a sale then read the last x number lines of the file based on how many items sold when macro saw a sale happen woud work.

Also tracking what you recieve and from who is a bit hard to do, especially with stacked items (you can read the "offered you" events but will not show how many in a stack).

What about using a modded version of some the foarge / fishing macro's that check inventory to see how many they already have before they decide to keep or destroy it only it would just check the numbers when trade command was given and the after it accepted the items?? You have the who based on who sends you the tell !trade would just be a matter of checking the counts at time trade is given then after vendor hits the trade button.

Now a possible way to do this would be to constantly keep track of what is in the traders inventory and cash. Then when something is bought (hence removed from inventory while cash increases, and is not done with !give command) it will remove the items gone from inventory from the relevant user and add the cash to their account. This would require a cumbersome (at least I think so) routine checks against an INI file everytime there's a change in cash and/or items and every item (and amount of cash) should be tracked per user/account. A bit much IMO Anyway, another problem arises. If more users have the same item, who should the items/cash be updated for first?

First in first out same with almost every inventory system in existance the one that place an item in 1st is the one that get the cash 1st imo and may be cumbersome but what does a vendor do most of the day anyway except sit there idle which means you could have the macro running the cumbersome section while doing nothing wouldn't affect him anyway.

I'm not sure I understand your intentions here? Currently the only list maintained is what minimum and maximum prices should be on any give item, which there's really no need to remove or cleanup except to update min/max prices if/when the market change. If you're thinking about a possible list for your suggestion #2 then I would say that such a list would be updated/cleaned continuously as items are sold/removed or added.

Does it automatically delete the items and their min max price whenever an item no longer exist in inventory if so you answered my question if not then the file would contimue to grow as items were added that mule never had before till it would become in the megs in size since each item would use 3 lines and since there are over 50,000 items already in game and more added every 3 months it would in time slow the macro down processing the file. True all server but 1 wouldn't have to worry about 1/4 of the items since they are no drops but that one server would.

 

[jiggins]

Don't know if i'm doing something wrong but everytime i /echo !underbid i ctd .. only defualt redquest plugins running

 

[motorsgt]

Is this supposed to create its own .ini? I have run it and not found one yet and I am not sure what the ini should look like so if possible could somone post an example?

 

[Mandrake]

Here ya go ini name same as macro

[Userlist]
; 3 = Master.
;	Can do everything Operators can do.
;	Can make the bot end the AdvTrader macro.
;	Can retrieve money/items.
;	Can add/modify users.
;
; 2 = Operator
;	Can change min/max prices on items.
;	Can trade new items to be sold
;	Can force overbid (barter)/underbid (trader).
;	Can set tradermode on/off.
;	Can set AFK.
;	Can check money.
;
; 1 = User
;	Can do pricechecks.
;
Fred=3
Barny=2
Wilma=1
Betty=1

 

[kegyen]

I am having trouble with this. Whenever I do /echo !underbid is it supposed to set all my prices lower than others currently selling?

 

[kegyen]

does anyone use this macro?

 

[Ccomp5950]

This uses /bzsrch

This hasn't worked right since April 2007.

 

[kegyen]

It would be really cool if there was a way to fix this or something, but im clueless lol

 

[Ccomp5950]

/bzsrch is a plugin that used packets, I'll see if it can be fixed, it was maintained by the MQ2dev's but since the packet checks are fixed we can probably fix it.

I'll talk with Yammers and Jmo.

 

[kegyen]

very cool thanks, was just curious, when one person is selling an item for 150k and i put it at 150k 5 minutes later 3 people log in and sell it for 50k it would allow a person to be able to price appropriately all of their items instead of routinely searching throughout the day everything i am selling.