Bug - KA saves wrong spell for MiscGem

[eqholic]

I started using the loadspellset feature and noticed that KA saves the contents for MiscGem (and possibly MiscGemLW) before the spellset is loaded.

 

[TreeHuginDruid]

I started using the loadspellset feature and noticed that KA saves the contents for MiscGem (and possibly MiscGemLW) before the spellset is loaded.

Your making my ToDO list grow every time you post...... GRRRRRRRRR...

Added to ToDO checklist ( grumble.. bitch... whine.. moan ).

Quick fix... which will be pushed when we post Kiss 10.0.4

| ----------------------------------------------------------------------------
| SUB: LoadSpellSet
| ----------------------------------------------------------------------------
    Sub LoadSpellSet
    
    /declare GemNum      int local
    /declare ValidSpells int local 0
        
    /if (${Debug}) /echo \atDEBUG Sub LoadSpellSet LoadSpellSet=(${LoadSpellSet}) \agLine#: ${Macro.CurLine}
    /if (${LoadSpellSet}==1) {
        /if (${Debug}) /echo \atDEBUG Sub LoadSpellSet SpellSetName=(${SpellSetName}) \agLine#: ${Macro.CurLine}
        /echo Memming spellset (${SpellSetName}).
        /memspellset ${SpellSetName}    
    } else {       
        |---Test to see if we have MySpells section defined in INI or not.
        /for GemNum 1 to 12
            /call LoadIni MySpells Gem${GemNum} string NULL
            /if (${Gem${GemNum}.Length} && ${Gem${GemNum}.NotEqual[NULL]}) {
                |-- We have found a good spell defined, one good spell is all it takes to be a valid MySpells config.
                /varset ValidSpells 1
            }
        /next GemNum 
        /if (${LoadSpellSet}==2 && ${ValidSpells}==0) /echo You have no valid spells defined in your ini file [MySpells], load your spells now and do a /writespells command while in KissAsssist.
        /if (${LoadSpellSet}==2 && ${ValidSpells}==1) /call Bind_MemMySpells ${Me.CleanName}
    }
    |-- If we called this routine, make sure we update values for ReMemMiscGem and ReMemMiscGemLW since they might have changed after spellset load.
    /varset ReMemMiscGem ${Me.Gem[${MiscGem}].Name}
    /varset ReMemMiscGemLW ${Me.Gem[${MiscGemLW}].Name}
    
    /return

Now STOP making my day harder.. lol

 

[eqholic]

Your making my ToDO list grow every time you post...... GRRRRRRRRR...

Added to ToDO checklist ( grumble.. bitch... whine.. moan ).

Quick fix... which will be pushed when we post Kiss 10.0.4

| ----------------------------------------------------------------------------
| SUB: LoadSpellSet
| ----------------------------------------------------------------------------
    Sub LoadSpellSet
    
    /declare GemNum      int local
    /declare ValidSpells int local 0
        
    /if (${Debug}) /echo \atDEBUG Sub LoadSpellSet LoadSpellSet=(${LoadSpellSet}) \agLine#: ${Macro.CurLine}
    /if (${LoadSpellSet}==1) {
        /if (${Debug}) /echo \atDEBUG Sub LoadSpellSet SpellSetName=(${SpellSetName}) \agLine#: ${Macro.CurLine}
        /echo Memming spellset (${SpellSetName}).
        /memspellset ${SpellSetName}    
    } else {       
        |---Test to see if we have MySpells section defined in INI or not.
        /for GemNum 1 to 12
            /call LoadIni MySpells Gem${GemNum} string NULL
            /if (${Gem${GemNum}.Length} && ${Gem${GemNum}.NotEqual[NULL]}) {
                |-- We have found a good spell defined, one good spell is all it takes to be a valid MySpells config.
                /varset ValidSpells 1
            }
        /next GemNum 
        /if (${LoadSpellSet}==2 && ${ValidSpells}==0) /echo You have no valid spells defined in your ini file [MySpells], load your spells now and do a /writespells command while in KissAsssist.
        /if (${LoadSpellSet}==2 && ${ValidSpells}==1) /call Bind_MemMySpells ${Me.CleanName}
    }
    |-- If we called this routine, make sure we update values for ReMemMiscGem and ReMemMiscGemLW since they might have changed after spellset load.
    /varset ReMemMiscGem ${Me.Gem[${MiscGem}].Name}
    /varset ReMemMiscGemLW ${Me.Gem[${MiscGemLW}].Name}
    
    /return

Now STOP making my day harder.. lol

I came up with the same solution. One question tough: How do arrays behave with outoffbound indices (MiscGemLW == 0 ie) in mq2 ?

 

[ctaylor22]

MQ will bark and yell at you if you try and use an element of an array that is out of bounds.. I normally try and test for bad element index values before trying to access an array element. We look at the MiscGemLW as a switch as well as the index element. We only try and use the MiscGemLW if it contains a valid value, otherwise it ignores the code..