Problem - Does Not Return to Camp

[islandgirl671]

Ive taken the liberty to find out why is it from the last update to the current why in some cases my character doesn't return to camp when it goes out and pulls and gets agroed. He just stands there and takes a beating until he is dead. Ive repeated this numerous times and this is where the macro line is processing.

Note: Around Line 6840

:StopCombat	
			/attack off
			/if (${Stick.Active}) /stick off
			/squelch /target clear
| Cycle until combat off and mob is aggro'd
			/if (${Me.Combat} && ${PullAggroTargetID} || ${Target.PctHPs}<100) /goto :StopCombat
| Turn on mq2melee function back on after pull
			/if (${Select[${Role},puller,pullertank]} && ${UseMQ2Melee}) /squelch /melee melee=1
		}
	}

it seems when it hits this section, it is looping back to :StopCombat and therefore doesn't even attempt to navigate back. each time it hangs up I use the /invoke ${Macro.CurLine} to see where it is at and its in this section each and every time. You can try to target the monster but it will just auto clear it since its written in the code.

So if its looping back to :StopCombat, my question is how is it even attempting to get back to the camp. I don't even know why its going into the Sub Routine Sub PullWithMelee, when clearly its pulling with range, but even so, if it hits this section, shoulfnt there be a way to see if you are not back at camp to get back? the only place in the macro that calls for that sub routine is

| Handle pulling with Melee setting
				/if (${PullWith.Equal[Melee]} || (${PullWithAlt.Equal[Melee]} && ${ToClose})) {
                	/call PullWithMelee

hoe its getting into that sub routine I am unsure as I am set to pull with Range

Thank you

- - - Updated - - -

I think I know why its going into that sub routine

/if (${PullWith.Equal[Melee]} || (${PullWithAlt.Equal[Melee]} && ${ToClose}))
since I am pulling with ranged ${PullWith.Equal[Melee]} will always return FALSE. now then ${PullWithAlt.Equal[Melee]} is always returning back TRUE (NO IDEA BUT YEAH and if ${ToClose} will bring me to that sub routine.

not sure not an expert just explainging how I am seeing it

- - - Updated - - -

so as a temporary fixed until 1 of the devs can look further into it I just replaced it with

- - - Updated - - -

/if (${Select[${Role},puller,pullertank,pullerpettank,hunterpettank]}) {
:StopCombat	
			/attack off
			/if (${Stick.Active}) /stick off
			/squelch /target clear
| Cycle until combat off and mob is aggro'd
			/echo Ignoring goto command
			|/if (${Me.Combat} && ${PullAggroTargetID} || ${Target.PctHPs}<100) /goto :StopCombat
| Turn on mq2melee function back on after pull
			/if (${Select[${Role},puller,pullertank]} && ${UseMQ2Melee}) /squelch /melee melee=1
		}

 

[ctaylor22]

We found that error and fixed it, but the fix has not been posted as of yet.

Basically what the code in the pull routine is doing, is checking to see if you are to close to the mob to pull with your /range item. That will set the ToClose flag and switch to pulling with melee.

The real issue is in the PullWithMelee routine all you need to do is Remark out, or delete the highlighted lines below.

    Sub PullWithMelee
        /if (${DebugPull}) /echo \atDEBUGPULL PullWithMelee: Enter \agLine#: ${Macro.CurLine}
        /if (!${Select[${Role},hunter,hunterpettank]}) {
            | Turn off mq2melee function so puller and pullertank doesn't attack mob on pull
            /if (${Select[${Role},puller,pullertank]} && ${UseMQ2Melee}) /squelch /melee melee=0
            :AttackAgain
                /moveto id ${MyTargetID} mdist 15
                /if (${Target.ID}) /face ${If[${FaceMobOn}==2,nolook,fast nolook]}
                /look 0
                /attack on
                /if (${PullMeleeStick} && !${PullAggroTargetID}) /stick id ${MyTargetID} 70%
                /delay 5
            /if (!${PullAggroTargetID} && ${Target.PctHPs}==100) /goto :AttackAgain
            | Turn off combat so puller returns to camp. You mean run like hell.
            /if (${Select[${Role},puller,pullertank,pullerpettank,hunterpettank]}) {
                |:StopCombat
                    /attack off
                    /if (${Stick.Active}) /stick off
                    /squelch /target clear
                | Cycle until combat off and mob is aggro'd
                /if (${Me.Combat} && ${PullAggroTargetID} || ${Target.PctHPs}<100) /goto :StopCombat
                | Turn on mq2melee function back on after pull
                /if (${Select[${Role},puller,pullertank]} && ${UseMQ2Melee}) /squelch /melee melee=1
            }
        }
        /varset Pulled 1
        /varset ToClose 0
        /if (${DebugPull}) /echo \atDEBUGPULL PullWithMelee: Leave \agLine#: ${Macro.CurLine}
    /return

 

[islandgirl671]

thank you ctaylor, yes that's exactly what I did on a temporary fix from my original post above. I appreciate your assistance

 

[ctaylor22]

I just do what I can.