Problem - Burn doesn't burn

[Pyrotek503]

RGMercs Build?

1.0

What level is the character?

113

I noticed all of my chars (same level range) are not recognizing a named is a named, I guess. When "Burn Always" is on, it allows the rotation.

 

[Derple]

There is a list of named in the main panel. If the named you are fighting isnt listed there then it doesn't know its a named and you should add it and submit a pr

 

[Pyrotek503]

There is a list of named in the main panel. If the named you are fighting isnt listed there then it doesn't know its a named and you should add it and submit a pr

are you talking about this list?


I also meant to add these to the original post, I appologize.

 

[Derple]

That first one is the named list yes.

 

[Pyrotek503]

That first one is the named list yes.

So if the group is in combat with a named that is listed, the group should go into Burn mode?

I finally caught Windchill and noticed it was the same way. Burn was not active during the fight.

 

[Derple]

Was the named list screenshot when the named was up? because it seems to not be seeing it if that is the case.

 

[Pyrotek503]

Was the named list screenshot when the named was up? because it seems to not be seeing it if that is the case.

Yes. The extended target shown in the screenshot was the current target of my group. Im pretty new to everything so I really dont know if I am missing something. Is there some other resource that I am supposed to be using to utilize that feature?

 

[Pyrotek503]

 

[Derple]

Your screenshot looks like there is something wrong. If Sofia is up she should have a green happy face with a distance and loc. So somehow it is not detecting her. Maybe named detection got broken I will take a look at it.

 

[Derple]

Okay I found a display bug with npcs that have # on their name so I fixed that.

Also if you have spawnmaster loaded that was overriding what is in our config, so make this more logical I made it check out list first and then fallback to spawnmaster as a backup.

See if this next build fixes it for you.

 

[Pyrotek503]

Spawnmaster was not being used. Visuals now show the named as being up. Sadly, it did not fix the issue when the group (war, clr, rog, bst, brd, dru) is engaged with a named mob, the "Burn" rotation is not called to run.

 

[Derple]

What class are you checking the burn rotation on lets check all your settings.

 

[Pyrotek503]

What class are you checking the burn rotation on lets check all your settings.

Warrior, Beast, Druid, Bard, Cleric, Rogue. All 114 AND 115


In this way, while the burn rotation will start as it is supposed to with 2+ mobs in the extended target window. The burn rotation also continues to run when "Auto Burn Always" is true. So that selector switch seems to work as intended.

This has been the case to all of the classes I listed.

What other requirements would be needed to start the burn rotation when a named mob that is listed is being killed other than the obvious "Auto Burn" and "Auto Burn Named" being true.


The only differences I have noticed is that the cleric, while in "Heal" mode doesn't ever go into burn rotation. This never changes even when "Auto Burn Always" is true. I feel like that makes sense in my head, so I haven't mentioned it.

 

[Derple]

---@return boolean
function RGMercUtils.BurnCheck()
    local settings = RGMercConfig:GetSettings()
    local autoBurn = settings.BurnAuto and
        ((RGMercUtils.GetXTHaterCount() >= settings.BurnMobCount) or (RGMercUtils.IsNamed(mq.TLO.Target) and settings.BurnNamed))
    local alwaysBurn = (settings.BurnAlways and settings.BurnAuto)
    return autoBurn or alwaysBurn
end

This is how the logic works for that.

 

[Pyrotek503]

I have been searching out the issue as best as I can and found line 1881, in the part of the logic you gave me out of the Utils, was blank. I removed that line and now the Warrior, rogue, and druid show they are burning when confronted with a named mob. The cleric and bard are still not starting the Burn rotation.

 

[Derple]

What exactly did you remove? i suspect you broke it ever not burning

 

[Pyrotek503]

What exactly did you remove? i suspect you broke it ever not burning

Line 1881 in rgmercs_utils.Lua on my computer.

The portion that you referenced earlier. I compared what you wrote, to what I saw on my computer. Then compared it to what is on github. There was a blank line so I removed it locally on my computer to see what happens. It didnt look right compared to everything else I saw.

Afterward, I found a named and tried it out. As I mentioned earlier, the cleric didnt run the Burn rotation. It makes even more sense now becuase the cleric is set in heal mode which doesnt call the burn rotation to start. The bard on the other hand is still not burning when in combat with a named mob, but I will continue to chase down what latches are involved while learning more about how things work so I can try and have better feedback for you guys.

 

[Derple]

If you just removed a blank line then nothing has changed and it would be working the same.