Problem - Ranger Rimespurs

[Robban]

RGMercs Build?

1.0

What level is the character?

115

Ranger trying to buff single DS after group DS

 

[Derple]

fixed.

 

[Robban]

still doing it

 

[Derple]

['GroupBuff'] = {
{
name = "Rathe",
type = "Spell",
tooltip = Tooltips.Rathe,
active_cond = function(self, spell) return RGMercUtils.BuffActiveByID(spell.RankName.ID()) end,
cond = function(self, spell, target, uiCheck)
if not uiCheck then RGMercUtils.SetTarget(target.ID() or 0) end
return RGMercUtils.SpellStacksOnTarget(spell) and not RGMercUtils.TargetHasBuff(spell) and not RGMercUtils.TargetHasBuffByName("Shared " .. spell.Name())
end,
},
},

Are you saying this group buff (casting on a group member not yourself) is casting even if it wont stack?

OR

Are you casting it on yourself?

 

[Robban]

['GroupBuff'] = {
{
name = "Rathe",
type = "Spell",
tooltip = Tooltips.Rathe,
active_cond = function(self, spell) return RGMercUtils.BuffActiveByID(spell.RankName.ID()) end,
cond = function(self, spell, target, uiCheck)
if not uiCheck then RGMercUtils.SetTarget(target.ID() or 0) end
return RGMercUtils.SpellStacksOnTarget(spell) and not RGMercUtils.TargetHasBuff(spell) and not RGMercUtils.TargetHasBuffByName("Shared " .. spell.Name())
end,
},
},

Are you saying this group buff (casting on a group member not yourself) is casting even if it wont stack?

OR

Are you casting it on yourself?

he tries to cast single ds on every groupmember, but they have the group version of it already. (first picture)

 

[Robban]

@Derple
What is the difference between
active_cond and cond?
if I put
not RGMercUtils.TargetHasBuffByName("Shared " .. spell.Name())
in the active_cond it seems to work correctly

 

[Algar]

Active condition is simply the condition to show the green smiley face that it's active.

Are the damage shields separate entries or something? I'll have a look later.

 

[Algar]

@Robban First things first, remove all "Shield of ... " entries from the Rathe table and check back (they are already listed under their own table). It actually appears that that author wanted the group versions there, so you could also change those out/add those in, but lets see if the original issue is resolved by that first change.

I'm blind on this one, no ranger.

 

[Robban]

@Robban First things first, remove all "Shield of ... " entries from the Rathe table and check back (they are already listed under their own table). It actually appears that that author wanted the group versions there, so you could also change those out/add those in, but lets see if the original issue is resolved by that first change.

I'm blind on this one, no ranger.

Yeah, I actually already did that. That could be what fixed it. Gonna check some more.

 

[Algar]

I honestly don't think it is the issue given your first picture, but I honestly don't see the issue looking at the code so hey!
L E T ' S G E T S P E C U L A T I V E !

 

[Robban]

I honestly don't think it is the issue given your first picture, but I honestly don't see the issue looking at the code so hey!
L E T ' S G E T S P E C U L A T I V E !

yeah, I also had removed the DS things you mentioned. So it was probably that. Did a PR on it