Bug - Puller keeps spamming looking for close range mobs.

[kaen01]

i been trying to track down this problem, because i will have a full pull area, puller pulls maybe half of it, then something in the code decides no nomore.

so i looked it over.

noticed the no pull alert list 1, has a refresh timer of 5minutes, and that corresponds to when puller would sometimes pick up pulling again.


listed the alert list 1 when puller stopped pulling, noticed an entry that said any

meaning any mob is not pulled.

went through the code with a fine tooth comb, and added an error infront of all calls to /alert add 1

turns out the bug happens when one of the variables is empty or null, i did not try and track down when it happened, but had 2 calls that failed and macro ended based on my edits.

so my proposal is that one of the 3 ${PullMob} ${MyTargetID} ${Target.ID} is testted if they a valid id before being added.

 

[kaen01]

made new edits that only allows it to add if the variables are true and its been pulling non stop for a while now, which in this particular camp it wouldnt before

 

[ctaylor22]

There were some changes made to the AlertAddToList routine that corrected adding null or zero ids to the alertlist. Where did you make your changes, because there are a lot of /alert add 1 lines of code in the macro..

 

[kaen01]

line #:

6129
6143
6350
6404
6424
6475
6507
6925

they all either test for ${PullMob} ${MyTargetID} ${Target.ID}

i just added to the line /if ${PullMob} /alert add 1 ${PullMob} etc. and that would toss a failure whne ever it tried adding something, first one i got was in the waiting for mob routine. then one in stuck i think. then i decided to correct all of them to see if it would run forver! it would. i did two forevers.

 

[ctaylor22]

OK. Thanks I will see about adding your suggestions to the code.

 

[kaen01]

the 2nd issue i mentioned in the release thread is that it never goes into the wait loop for looking for mobs, it just constantly spams if no mobs are valid to pull, you can recreate that easy by /alert add 1 ID

 

[kaen01]

i have done some more testing on the spamming issue, where it never enters the pullcheck loop if it dont find a mob.

            /if (${Select[${Role},puller,pullertank,pullerpettank,hunter,hunterpettank]}) {
                /if (!${PullMob}) /call FindMobToPull 1
                /if (${PullMob}) /call PullCheck
                /varset PullMob 0
            }

when you guys rewrote findmobtopull to return 0 if no valid mob found it never enters that sub.
so it runs findmobtopull over and over till it finds one then enters pullcheck, but it never goes there to wait if it dont find a mob.

i tried forcing it in there, but then there is other issues with some other stuff in there. but you is smarter than me.

 

[ctaylor22]

I will put it on my list of things to look at. That shouldn't be to hard to find and fix..

 

[microscope]

Not sure if I should necro this or not, but got a bit of info that might help. I had the same problem tonight. Puller kept spamming that he was looking for close range mobs even though his settings were good. I moved him into the middle of the room and suddenly he sprang into life and started pulling. I think where he was standing was just causing him to not be able to see or path to mobs so it screwed it up. Also the zone I was in had no Nav Mesh and I was unable to make one myself because the zone file refused to load in mesh maker.

 

[kaen01]

which zone was that microscope?

and yeah Line of sight pulling will run out of mobs real quick if you dont have a flat area with no walls, trees, rocks, landscape, clouds, birds 3 miles out etc.

let me know what zone you cant mesh and i will try and mesh it for you.

 

[microscope]

It was Kaesora Library, an instanced version but not sure that matters. Its ok though I probably wont go back anyway

 

[TheDroidUrLookingFor]

I've had this happen as well before but I was in the Underquarry. My bots would pull for HOURS and then randomly they'd stop being able to find mobs. My puller would just spam looking for close targets. However if I did a /plugin mq2nav unload and /plugin mq2nav it will magically start pulling again without any issue.