Question - Need help to make work this little macro plz

[zeusdraco]

Sub Main

/declare NPCName string outer Shazda Asad
/declare ItemName string outer Sentinel Creot's Head

:checkSpawnLoop
/if (${Spawn[${NPCName} npc].ID} && ${Target.ID}!=${Spawn[${NPCName} npc].ID}) {
/squelch /target id ${Spawn[${NPCName} npc].ID}



} leftmouseup
/delay 2s ${Cursor.ID}
/click left target
/delay 2s ${Window[GiveWnd].Open}
/if (${Window[GiveWnd].Open}) {
/notify GiveWnd GVW_Give_Button leftmouseup}
/goto :checkSpawnLoop


When i start it, it click the npc finely, put in the whatever thing i have on my cursor ( just like i wanted ) in trade with the say NPC, but doesnt click give.

It say : Invalid notification leftmouseup}


and when i use this

Sub Main

/declare NPCName string outer Shazda Asad
/declare ItemName string outer Sentinel Creot's Head

:checkSpawnLoop
/if (${Spawn[${NPCName} npc].ID} && ${Target.ID}!=${Spawn[${NPCName} npc].ID}) {
/squelch /target id ${Spawn[${NPCName} npc].ID}



} leftmouseup
/delay 2s ${Cursor.ID}
/click left target
/delay 2s ${Window[GiveWnd].Open}
/if (${Window[GiveWnd].Open}) {
/notify GiveWnd GVW_Give_Button leftmouseup


It work fine , target the NPC, put in whatever i have on the cursor like intended and give to the npc......but it endmacro coz i have no Loop properly configurated.

So i doesnt know how to properly fix it, as soon i add a loop it stop to work....

someone can tell me what is wrong with it ?

 

[Hihi]

Try this?

Sub Main

/declare NPCName string outer Shazda Asad
/declare ItemName string outer Sentinel Creot's Head

:checkSpawnLoop
/if (${Spawn[${NPCName} npc].ID} && ${Target.ID}!=${Spawn[${NPCName} npc].ID}) {
/squelch /target id ${Spawn[${NPCName} npc].ID}



} leftmouseup
/delay 2s ${Cursor.ID}
/click left target
/delay 2s ${Window[GiveWnd].Open}
/if (${Window[GiveWnd].Open}) {
/notify GiveWnd GVW_Give_Button leftmouseup
} /goto :checkSpawnLoop

 

[zeusdraco]

Well it worked, it gave the item to the npc but it say reached the end of the macro.

If the npc isnt up and i wait his spawn and i start the macro before it pop, will it loop til it actualy gave the item to the npc or it will end right away?

- - - Updated - - -

It worked when the npc was up, i killed it to start the macro and wait for his spawn.

Once i started the macro, You must have a target selected for /click x target. reached end of macro

So guessing it doesnt loop properly, i just want it to keep checking for the named and once it have it on target it turn in....

Someone can help to make it possible and as simple as possible, the code above should work, it just need to be looped over and over which i dont know how

- - - Updated - - -

i got it working properly after few hours of test and lurking everywhere to find some part of code, thx for your help.

 

[Maskoi]

Post the macro tht is working for you please