Fishing Mac Question (1 Viewer)

[Yimmno]

Hello All,

I'm not very good at making macros and what I basically do is take pieces from other macros I find on here and try to piece things together. Sometimes I can get it to work, I have a very basic knowledge of what I'm doing.

Anyways, I'm trying to make a fishing macro that keeps only three items that I want and destroys everything else. I've tried it a few ways and nothing seems to work. Here's my latest attempt. Any help/guidance would be amazing, thanks! (Please be kind on the pathetic attempt!)

#turbo

#event BrokenPole "#*#You can't fish without a fishing pole, go buy one.#*#"
#event NoBait "#*#You can't fish without fishing bait, go buy some.#*#"

Sub Main

/declare RV_LootArray[3] string outer
   /varset RV_LootArray[1] "Cave Catfish"
   /varset RV_LootArray[2] "Mossmatt"
   /varset RV_LootArray[3] "Fungus-covered Plecostomus"



    /cleanup
    :Fish
        /call CheckPole 
        /doability Fishing
        /delay 65 
        /doevents

        /if (!${Cursor.ID}) /goto :Fish

     
            } else {
                /call KeepItem
            }
      }
   /goto :Fish
/return

Sub KeepItem
   /declare LootCheck   int inner  0
   /declare LootTotal   int inner  0

/varset LootTotal 1
/delay 1s

|---------Keep Good Stuff---------------------
         /for LootCheck 1 to ${RV_LootArray.Size}
            /if (${Cursor.Name.Find[${RV_LootArray[${LootCheck}]}]}) {
               /echo Keeping a ${Cursor.Name}... WOOT!
               /autoinventory
               /delay 1s
            }
         /next LootCheck 

|---------Destroy Bad Stuff-------------------
      /if (${Cursor.ID}) {
         /echo Destroying a ${Cursor.Name}...
         /destroy
         /delay 1s
      } 	


/return



Sub CheckPole
   /if (${Me.Inventory[mainhand].Name.Find[Brell's Fishin' Pole]}) /return
   /echo  You need to put your fishing pole in your primary hand.
   /endm
/return

Sub Event_BrokenPole
   /endmacro
/return

Sub Event_NoBait
   /endmacro
/return

 

[Yimmno]

Ok nevermind, I made a much simpler version and it seems to work. It has an extra step in it that's not necessary, but it seems to make it work. Also added in a check to cast a new Brell's fishin' pole if it breaks which is working nicely. If anyone is interested in using it or giving me tips on how I can make it more efficient, that'd be great!

#turbo

#event BrokenPole "#*#You can't fish without a fishing pole, go buy one.#*#"
#event NoBait "#*#You can't fish without fishing bait, go buy some.#*#"

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability Fishing
        /delay 65 
        /doevents

        /if (!${Cursor.ID}) /goto :Fish

        /if (${Cursor.Name.Equal[Cave Catfish]}) /call keepforreal
	  
        /if (${Cursor.Name.Equal[Mossmatt]}) /call keepforreal
		
        /if (${Cursor.Name.Equal[Fungus-covered Plecostomus]}) /call keepforreal
      
         /call KeepItem
      
   /goto :Fish
/return

Sub Keepforreal
   /echo Keeping ${Cursor.Name}
   /notify InventoryWindow IW_CharacterView leftmouseup                
   /delay 1s
/return

Sub KeepItem
   /echo Destroying ${Cursor.Name}
   /destroy
   /delay 1s
/return

Sub CheckPole
   /if (${Me.Inventory[mainhand].Name.Find[Brell's Fishin' Pole]}) /return
   /echo  You need to put your fishing pole in your primary hand.
   /keypress 9
   /delay 11s
   /notify InventoryWindow IW_CharacterView leftmouseup                
   /delay 1s
/return

Sub Event_BrokenPole
   /echo  You need to put your fishing pole in your primary hand.
   /keypress 9
   /delay 11s
   /notify InventoryWindow IW_CharacterView leftmouseup                
   /delay 1s
/return

Sub Event_NoBait
   /endmacro
/return

 

[Ccomp5950]

Looks good though your subroutine for destroying the items left after checking for stuff to keep could be a little more accurately named

 

[Yimmno]

Looks good though your subroutine for destroying the items left after checking for stuff to keep could be a little more accurately named

Haha ya it certainly could. I just happened to change the sub and didn't bother renaming it .