Assistance with a Macro (1 Viewer)

[Blackskull]

Hello im looking for some assistance on editing a macro. this is what i need.. editing the target.mac but i want in side /circle and /twist. i want it to start circling then targeting a mob and then twisting it to death and once its done, select another target and repeat to kill it. Also i would like it for to use a heal pot when health gets to about 75% or so on the potion belt.

so far i have in mind is this:

| This macro made for www.Redguides.com
| Don't steal it or we'll punch your fase!
#turbo  
#event camp "personingroup tells the group, 'lets roll'  
#event dzadd "personyouwanttoadd tells you, 'add me'  
#event invite "#*#invites you to join#*#"  
#Event Zoned "#*#You have entered#*#"  
  
  
Sub Main  
  
    
:loopstart 
/doevents  
/call GMcheck  
/if (${Target.Level}>70) /tar npc next 
/if (${Target.Distance}>220) /keypress esc  
/if (${Target.ID}==FALSE) /tar NPC radius 220  
/delay 10  
/goto :loopstart  
/return  
  
 Sub GMcheck  
 /if (${Spawn[gm].ID}) {  
 /echo Gm detected  
 /beep 
 /beep 
 /beep  
 /keypress 9 
 /endmac 
 /unload 
 /q  
 }  
 /return  
 
Sub Kiting
/circle on 60
/delay 2s
/twist 3 4 5 6 7
/return

 Sub event_camp  
 /sit  
 /camp desk  
 /return  
  
 sub event_zoned  
 /delay 5s  
 /sit  
 /camp desk  
 /endmac 
 /return  

 sub event_dzadd 
 /dzadd personyouwanttoadd 
 /return 

 sub event_invite  
 /invite  
 /return

 

[kaneda86]

looks like your missing a call to get your sub working. you need to add in a /call kiting somewhere into the main loop to get it to do the kiting. this will be a pretty basic macro if it works. to add in a potionbelt caller or something make another sub that gets called when you are < 75% hp or whatever.

FYI this should be posted in the requests and help section

 

[Blackskull]

ok sorry about that. i must have hit the wrong section

 

[kaneda86]

hehe np. did that make sense about the rest of it though?

 

[Blackskull]

LOL i think so adding it in now and trying it out. Hope it works if not, try, try again .

 

[Blackskull]

So I started with this:

| This macro made for www.Redguides.com
| Don't steal it or we'll punch your fase!
#turbo  
#event camp "personingroup tells the group, 'lets roll'  
#event dzadd "personyouwanttoadd tells you, 'add me'  
#event invite "#*#invites you to join#*#"  
#Event Zoned "#*#You have entered#*#"  
  
  
Sub Main  
  
    
:loopstart 
/doevents  
/call GMcheck  
/if (${Target.Level}>70) /tar npc next 
/if (${Target.Distance}>220) /keypress esc  
/if (${Target.ID}==FALSE) /tar NPC radius 220  
/delay 10  
/call kiting  
/return  
  
 Sub GMcheck  
 /if (${Spawn[gm].ID}) {  
 /echo Gm detected  
 /beep 
 /beep 
 /beep  
 /keypress 9 
 /endmac 
 /unload 
 /q  
 }  
 /return  
  
Sub kiting
/circle on 60
/keypress forward hold
/delay 2s
/twist 3 4 3 5 3 6 3 7 3 8
/if (${Me.PctHPs}<=75) /potionbelt activate 1
/goto :loopstart
/return

Sub event_camp  
 /sit  
 /camp desk  
 /return  
  
 sub event_zoned  
 /delay 5s  
 /sit  
 /camp desk  
 /endmac 
 /return  

 sub event_dzadd 
 /dzadd personyouwanttoadd 
 /return 

 sub event_invite  
 /invite  
 /return

And now I'm getting an error in the mq2 window that says:
targets.mac@42 (kiting): /goto :loopstart
targets.mac@20 (Main): /call kiting
The current macro has ended.....

 

[Nightmare327]

I think you can take out the /go :loopstart in the kiting sub, as it isnt needed. the /return will put you back into the loop automatically. You do have some other conceptual issues with the macro though too, as the main loop probably will not do what you want. or you may need to put a :kiteloop in the kiting routine and loop there.

There is another kiting macro we just rewrote that may be a very good starting point for what you wish to do, I put some replies on it so you can look up some of my recent posts to find it. At work now or I would do more on it, sorry.

 

[Blackskull]

There i now have it set correctly.

Tested it out and works great.
_________________________________________________________________

#turbo  
#event camp "personingroup tells the group, 'lets roll'  
#event dzadd "personyouwanttoadd tells you, 'add me'  
#event invite "#*#invites you to join#*#"  
#Event Zoned "#*#You have entered#*#"  
  
  
Sub Main
	/stoptwist
	/circle on 60
	/delay 2s
	/squelch /twist 3 4 3 5 3 6 3 7 3 8
	:loop
	/doevents
	/if (${Target.Distance}>=200) /keypress esc
	/if (${Target.ID}==FALSE) /tar NPC radius 220
	/if (${Me.PctHPs}<=75) /potionbelt activate 1
	/goto :loop
  
 Sub GMcheck  
 /if (${Spawn[gm].ID}) {  
 /echo Gm detected  
 /beep 
 /beep 
 /beep  
 /keypress 9 
 /endmac 
 /unload 
 /q  
 }  
 /return  
  
 Sub event_camp  
 /sit  
 /camp desk  
 /return  
  
 sub event_zoned  
 /delay 5s  
 /sit  
 /camp desk  
 /endmac 
 /return  

 sub event_dzadd 
 /dzadd personyouwanttoadd 
 /return 

 sub event_invite  
 /invite  
 /return

 

[aamlord]

Sub GMcheck
/if (${Spawn[gm].ID}) {
/echo Gm detected
/beep
/beep
/beep
/keypress 9
/endmac
/unload
/q
}
/return

Just wondering if the end mac is encountered, wouldn't that cause the macro to end before it reaches unload and quit? Wouldn't it work better if you skipped /end and /unload and just use /quit or /exit?

Never had the chance to try any GM detection code as GM don't exists on my server.

 

[Acigaretteandsex]

Sub GMcheck
/if (${Spawn[gm].ID}) {
/echo Gm detected
/beep
/beep
/beep
/keypress 9
/endmac
/unload
/q
}
/return

Sub GMcheck
/if (${Spawn[gm].ID}) {
/echo Gm detected
/popup GM tryin to bust my shits homes!
/keypress 9
/AFK
/exit
/end
/return

 

[armysoldier]

OK quick question for you

Why are you using keypress 9?

in the older days it used to have fade or something like that in that hotkey.

you could just hard code that in.




2nd

change

Sub event_camp  
 /sit  
 /camp desk  
 /return  
  
 sub event_zoned  
 /delay 5s  
 /sit  
 /camp desk  
 /endmac 
 /return

to

Sub event_camp
 /keypress 9 (or hard code the bard fade in)
 /twist off 
 /circle off
 /sit  
 /camp desk  
 /return  
  
 sub event_zoned  
 /delay 5s 
 /twist off 
 /circle off 
 /sit  
 /camp desk  
 /endmac 
 /return

Nothing like running in circles in pok twisting songs.... it screams out MQ2

8-)

ARMY

 

[armysoldier]

add /call GMCheck after or before your /doevents

:loop
    /call GMcheck
    /doevents

ARMY

 

[armysoldier]

It looks like a good simple macro ...

the best kind

Last comments and I think you will have a good macro on your hands.

#event dzadd "personyouwanttoadd tells you, 'add me'  
#event invite "#*#invites you to join#*#"

I would remove or change these.

your invite event will allow anyone to join your grp ..
granted in your in forgotten halls they can not get into the instance, but it still is a wide open door

if your not going to really use them I would remove them,
are you going to have other bots join the grp? or the instance?

if not then its just extra useless code.

IMHO of course

Good job

Army

 

[Blackskull]

I have edited the whole macro and will have it up soon enough

Just fooling around with it right now. And so for it is running great. Have killed almost 400 mobs straight without one death. I will add all the thanx to all the people that helped me make this simple but very sucessfull macro.

Cheers