Question - Anything wrong with this Yaulp holyflag?

[Skyjet2000]

Currently trying to learn how to better use Downshits/holyshits, but I'm completely unfamiliar with the syntax, please bare with me.

Currently working on one that will have my Paladin cast and keep Yaulp up during combat.

holyshit1=/if (${Me.CombatState.Equal[COMBAT]} && ${Target.Type.Equal[NPC]} && ${Me.PctMana}>40 && ${Cast.Ready[Yaulp II]}) /casting "Yaulp II" gem5

I've just began testing it, and it seems to work as intended, but wondering if this is the correct way to go about this, or am I going to run into unexpected problems due to missing TLO or some such?

 

[Meistro]

Don't need the ${Me.CombatState.Equal[COMBAT] because holys only work while in melee combat so it is kindof redundant, but may wish to add

!${Me.Buff[Yaulp II].ID} && ${Spell[Yaulp II].Stacks}

so I doesn't spam cast if buff duration longer than refresh or for some reason you get a buff that blocks it.

 

[Skyjet2000]

Don't need the ${Me.CombatState.Equal[COMBAT] because holys only work while in melee combat so it is kindof redundant, but may wish to add

!${Me.Buff[Yaulp II].ID} && ${Spell[Yaulp II].Stacks})

so I doesn't spam cast if buff duration longer than refresh or for some reason you get a buff that blocks it.

Thanks a lot, this is exactly what I was looking for. I knew what I had was probably sloppy or needed tightening up etc.

 

[Maskoi]

Code Tags people

	
	

		
holyshit1=/if (${Target.Type.Equal[NPC]} && ${Me.PctMana}>40 && ${Cast.Ready[Yaulp II]} && !${Me.Buff[Yaulp II].ID} && ${Spell[Yaulp II].Stacks})  /casting "Yaulp II" gem5