Problem - Anizok's Bait Dispenser, bait making macro

[CharlieMurpheyPHD]

I am attempting to make a macro that automates the bait production using fresh fish and Anizok's Bait Dispenser. I want it to drop 1 fresh fish in the container, hit combine, then autoinventory it until I /end or until I run out of fresh fish. When I /mac bait I get the following:

Starting bait production...
No more Fresh Fish. Finished!
The current macro has ended.

I have 206 Fresh Fish in my inventory and the anizok's bait dispenser. I am not a skilled macro writer but I thought I had all the things covered. Can someone look over this and let me know what I'm getting wrong?

|===========================================================
| makebait.mac
|===========================================================

Sub Main
/echo Starting bait production...

/declare Dispenser string outer "=Anizok's Bait Dispenser"
/declare Fish string outer "=Fresh Fish"

/if (!${FindItem[${Dispenser}].ID}) {
/echo You do not have Anizok's Bait Dispenser!
/end
}

:loop
/if (!${FindItem[${Fresh Fish}].ID}) {
/echo No more Fresh Fish. Finished!
/end
}

|--- Open the dispenser ---
/itemnotify "${FindItem[${Dispenser}].Name}" rightmouseup
/delay 5 ${Window[TradeskillWnd].Open}

|--- Put 1 fish in slot 1 ---
/combineitem "${FindItem[${Fresh Fish}].Name}"

|--- Click Combine ---
/notify TradeskillWnd CombineButton leftmouseup
/delay 2s

|--- Close window ---
/notify TradeskillWnd DoneButton leftmouseup
/delay 5

/goto :loop
/return

 

[Sic]

hi charlie,

glad to see folks making stuff.

I'd recommend submitting something for a resource if you'd like to be a resource contributor - I know you asked about helping you with it, just i just wanted to mention before you spend too much time on something when you might rather just be making the bait

keep in mind this particular thing you have above has a half dozen other resources that does the same thing, and I would deny this resource solely based on the usage of /goto.

this is incorrect

${Fresh Fish}

your variable is ${Fish}

 

[CharlieMurpheyPHD]

Thank you for the response, Sic. I am not skilled in this endeavor (I am sure that is apparent). I was doing this piece-meal using what things I could find through basic searches. I think I understand the premise of some of the macro things but making them actually work is over my head.

When you mention that there are half a dozen resources that do the same thing, could you point me to one? I tried searching for bait, bait dispenser, Anizok, Anizok's, and found only old, very old requests for something that does this, not an existing bait making resource using this - I probably should have started with that in the initial post as I am seirously do not wish to waste folks time. Sometimes the obvious things escape me and I'm embarrassed when I have to ask because I know is greatly upsets some folks when people make ask help but do not do the homework first.