Question - Why does PullRoleToggle only work for PetTankPuller & MOLO w/Merc?

[DriveCrash]

I have been trying to use the puller flag toggle to help control my group, but it never worked. So I went digging.

  /if (${Select[${Role},pullerpettank]} && ${PullRoleToggle} && ${Group.Puller.ID}!=${Me.ID}) {
            /if (${Math.Distance[${Spawn[${Target.ID}].Y},${Spawn[${Target.ID}].X}:${CampYLoc},${CampXLoc}]}>${CampRadius}) /call TogglePullMode TurnOn

Is the pullerpettank only option intentional? Would it hurt to ignore puller role (since it's already defined) and just use PullRoleToggle & Group Puller ID?

I changed the code in mine to

        /if (${PullRoleToggle} && ${Group.Puller.ID}!=${Me.ID}) {
                  /if (${Math.Distance[${Spawn[${Target.ID}].Y},${Spawn[${Target.ID}].X}:${CampYLoc},${CampXLoc}]}>${CampRadius}) /call TogglePullMode TurnOn

Then added

        /if (${DebugPull}) /echo DEBUGPULL Pull Done Pulling
        /if (${ReturnToCamp} && ${Pulled}) {
            |- Toggle puller mode off if option enabled.
            /if (${PullRoleToggle} && ${Group.Puller.ID}==${Me.ID}) /call TogglePullMode TurnOff            
			/call WaitForMob
            /varset Pulled 0

Now it works for any character I want to pull with in any of the puller roles. However, I wanted to ask if this change would hurt some other function.. or perhaps just make it less Oops proof? I'm not sure.

Thoughts?

 

[Maskoi]

Treehumper will have to answer this. It was his addition for some pet function.

 

[TreeHuginDruid]

It is specific to pullerpettank role, to allow toggling puller role in group roles in eq. I did this because I don't want cleric following mage on pulls and accidentally gaining agro/forcing mob to not follow mage or pet back to camp for assisting toons to help. Technically it can be used by anyone who is puller to prevent mercs from following them on pulls and messing up the pull back to camp, but it was my decision to limit it to that ka role at the time.
If lizardboy wants thr role restriction removed to give all pullers this option to keep merc in camp on pull, i'll alter it. But need his "go ahead" first.

Your alteration will work, but is definately NOT the way we would want to alter it in production. We would simply remove select role pullerpettank from the lead conditions.