Problem - Unbank macro reliably crashes macroquest and eq (1 Viewer)

[PricklyGoat723]

I have a macro that reliably crashes macroquest and eq.
I have a simple macro, half copied from another macro, that unbanks items for my vendor.
Basically, it tries to /autoinventory every item in the first 2 containers in the bank.
If the item doesn't go in my inventory and is still on the cursor, then it tries to put it back in the bank with /autobank.
It worked for a couple months, but now it reliably crashes macroquest and eq.
I stopped using it, but i thought maybe it would help to post it here. Perhaps it will help one of the macroquest developers find a bug.
Also, if there are any flaws or problems with the macro itself, then please let me know.
If anyone wants additional information, like screenshots of the crash or logs or something, please let me know.
Thank you.

Notes:
I ran Launchpad and EQ is up to date.
I ran Redguides launcher and Macroquest is up to date for live.
Copied (with some modifications) most of the code from: GoCo.mac by BobWeaver!

Steps to Reproduce:

1. Run Macroquest Very Vanilla
2. Load my vendor profile
3. Open bank familiar
4. Open first two containers in bank
5. First bank container has 8 items, second container is empty
6. 10 vendor bags are closed, they have 10 empty slots sprinkled around
7. /mac unbank
8. KABOOM! EverQuest Crash Detected. MacroQuest caught a crash: Version 3.1.0.1424 (I have a screenshot of just the error message, but was not sure if that is safe to post here.)

Sub Main
    /declare     i                     int     local     0
    /declare     j                     int     local     0
    /declare    intPackSlots        int        local    10

    /echo Unbanking first 2 containers
    /for i 1 to 2
        /if (${Me.Bank[${i}].Container})  {
            /call BankPack ${i}
        } else {
            /if (${Me.Bank[${i}].ID}) /mqlog ${i}) ${Me.Bank[${i}].Stack}x ${Me.Bank[${i}].Name}
        }
    /next i
   
/return

Sub BankPack(int i)
    /declare j int local
    /if (${Me.Bank[${i}].ID}) {
        /for j 1 to ${Me.Bank[${i}].Container}
            /if (${Me.Bank[${i}].Item[${j}].ID}) {
                /echo -- ${Me.Bank[${i}].Item[${j}].Stack}x ${Me.Bank[${i}].Item[${j}].Name}
                /echo [BC] Pack ${i}, Slot ${j} holds ${InvSlot[pack${i}].Item.Item[${j}].Name}
                /nomodkey /shiftkey /itemnotify in bank${i} ${j} leftmouseup
                /delay 5s ${Cursor.ID}
                /delay 1
                /if (${Cursor.ID}) {
                    /echo autoinventory ${Cursor.Name}
                    /autoinventory
                    /delay 5 (!${Cursor.ID})
                }
                /if (${Cursor.ID}) {
                    /echo rebanking ${Cursor.Name}
                    /autobank
                    /delay 5 (!${Cursor.ID})
                }
            }
        /next j
    }
/return

 

[PricklyGoat723]

So a couple changes seemed to help.

I open the bank packs and all my inventory packs before I run Unbank.mac.
Plus I changed 3 of the delays in Sub BankPack.
/delay 1
is now
/delay 5

and both
/delay 5 (!${Cursor.ID})
are now
/delay 5

This seems to let the macro run happily again.
I think it was too impatient before.

 

[Knightly]

The detailed writeup was good, but I'm not able to recreate this with your original script and following your instructions. Can you send me your Crash ID from one of the crashes?