Shaman Macro Help! (1 Viewer)

[LordMage]

Hey guys, I am running this Shaman macro but it won't keep Panther up on Berserkers, if anyone can figure out to edit it to keep it on Berserkers I'd Appreciate it!

Here is the part that needs editing:
| ############## Cast_Panther Line on group
Sub Cast_Panther
/target id ${TargetArray[4]}
/delay 5
/if (${Target.PctHPs}>=${PantherSkip}) {
/declare i int local 1
/for i 1 to ${Group.Members}
/if (${Group.Member[${i}].ID}) {
/if (${PANBuffed${i}}==0) /if (${Group.Member[${i}].Class.Name.Equal[Beastlord]} || ${Group.Member[${i}].Class.Name.Equal[Shadow Knight]} || ${Group.Member[${i}].Class.Name.Equal[Bard]} || ${Group.Member[${i}].Class.Name.Equal[Ranger]} || ${Group.Member[${i}].Class.Name.Equal[Rogue]} || ${Group.Member[${i}].Class.Name.Equal[Paladin]} || ${Group.Member[${i}].Class.Name.Equal[Monk]} || ${Group.Member[${i}].Class.Name.Equal[Warrior]}) {
/if (${Me.CurrentMana}>${Spell[${SpellPanther}].Mana}) {
/target pc ${Group.Member[${i}]}
/delay 5
/tell ${Group.Member[${i}]} ${SpellPanther} is incomming to you ${Group.Member[${i}]} , Stay in Range !!!
/call cast ${SpellPanther} gem5 4s
/if (${Macro.Return.Equal["CAST_OUTOFRANGE"]}) /varset PANBuffed${i} 200
/if (${Macro.Return.Equal["CAST_SUCCESS"]}) /varset PANBuffed${i} ${PantherDelay}
/return
}
}
}
/next i
/target id ${TargetArray[4]}
/delay 1s
}
/return

 

[Majic]

(${Group.Member[${i}].Class.Name.Equal[Beastlord]} || ${Group.Member[${i}].Class.Name.Equal[Shadow Knight]} || ${Group.Member[${i}].Class.Name.Equal[Bard]} || ${Group.Member[${i}].Class.Name.Equal[Ranger]} || ${Group.Member[${i}].Class.Name.Equal[Rogue]} || ${Group.Member[${i}].Class.Name.Equal[Paladin]} || ${Group.Member[${i}].Class.Name.Equal[Monk]} || ${Group.Member[${i}].Class.Name.Equal[Warrior]})

Well I dont see beserker in you list of ppl to buff.

My grp sub for doing panther looks like this:

| ############## CastPanther Line on group
Sub CastPanther
  /declare i int local
  /if ((${DoSlow} && !${MobSlowed}) || (${DoCripple} && !${MobCrippled}) || ${Target.Type.NotEqual[NPC]}) /return
  /for i ${Group.Members} downto 0
    /if (${Target.PctHPs}<=${PantherSkip}) /return
    /if (${Group.Member[${i}].ID}) {
      /if (${PanGrp${i}}==0 && ${Select[${Group.Member[${i}].Class.ShortName},BER,BRD,BST,MNK,PAL,RNG,ROG,SHD,WAR]} && ${DoPantherGroup}) {
       /call AcquireTarget ${Group.Member[${i}]} PC FALSE
       /if (${Me.CurrentMana}>${Spell[${SpellPanther}].Mana} && ${Target.Distance}<${Spell[${SpellPanther}].Range}) {
          /call cast ${SpellPanther} ${SpellPantherGem} ${CastRetryTime}
          /if (${Macro.Return.Equal["CAST_OUTOFRANGE"]}) /varset PanGrp${i} 200
          /if (${Macro.Return.Equal["CAST_SUCCESS"]}) /varset PanGrp${i} ${PantherDelay}
        }
        /return
      }
      /if (${PanPet${i}}==0 && ${Group.Member[${i}].Pet.ID} && ${DoPantherPets} && ${Select[${Group.Member[${i}].Class.ShortName},BST,MAG,NEC,SHM]}) {
        /call AcquireTarget ${Group.Member[${i}].Pet} PET FALSE
        /if (${Me.CurrentMana}>${Spell[${SpellPanther}].Mana} && ${Target.Distance}<${Spell[${SpellPanther}].Range}) {
          /call cast ${SpellPanther} ${SpellPantherGem} ${CastRetryTime}
          /if (${Macro.Return.Equal["CAST_OUTOFRANGE"]}) /varset PanPet${i} 200
          /if (${Macro.Return.Equal["CAST_SUCCESS"]}) /varset PanPet${i} ${PantherDelay}
        }
        /return
      }
    }
  /next i
/return

I think all you really need to do is add beserker to you list.

 

[nyghteyes]

Have a full working sham mac you could post? I have ViP access but havent gotten one fully working. All I'm looking to do is HoT, Patch and Slow

 

[Majic]

I am actually using the shambot one from vip and have been for over 6months with very few problems.

shambot.mac v3.23 -- (updated 06/02/19) -- Fixes+