paladin macro

[Ghostyrus]

just a simple paladin macro

sub main

/declare HomeXLoc		  int	outer ${Me.X}
/declare HomeYLoc		  int	outer ${Me.Y}
/declare Distoftarget             int   outer 100
/declare radius                   int   outer 100
/declare closeenoughtoattack      int   outer 40



:loop
/keypress esc
/delay 1
/target npc radius ${radius} 
/if (${Target.ID} && ${Target.Distance} <= ${Distoftarget} && ${Target.LineOfSight}) {
/goto :pull
}
/goto :loop
/return

:pull
/delay 1s
/cast "Lesson of Penitence"
/delay 2s
/cast "Sacred Force"
/delay 2s
/cast "Call of Honor"
/delay 1s
/if (${Target.Distance} <= ${closeenoughtoattack}) {
/goto :kill
}
/goto :loop
/return


:kill
/stick 12
/attack on
/doability bash
/if (${Target.ID} && ${Target.Type.Equal[NPC]}) {
/goto :kill
}
/clean
/stick off
/call ReturnHome
/goto :loop
/return



Sub ReturnHome
:returnhome
/keypress jump
  /if (${Me.State.Equal[SIT]}) /stand
  /face fast nolook loc ${HomeYLoc},${HomeXLoc}
  /if (${Math.Distance[${HomeYLoc},${HomeXLoc}]}>2) /nomodkey /keypress forward hold
  /if (${Math.Distance[${HomeYLoc},${HomeXLoc}]}<=5) {
	/nomodkey /keypress back
/return
  }

 

[Alatyami]

missing your /return on your Sub main.

 

[armysoldier]

I am not trying to be rude here but did you write both this and the warrior code?

both are distinctly different...one uses /goto loops and the other uses sub routines



is /keypress jump a command? (remember I have been away for a while) 8-)

Lastly this could be a pally / SK macro if you made the spells variables that the user could change.

OR they could go down to the cast area and change it there also, since the macro is not very big.



your missing a /goto :returnhome in your return home sub

 

[Alatyami]

You should tie in spell_routines.inc to handle spell fizzles ...

 

[Tantroth]

mmm fort carson too eh?

 

[armysoldier]

yeah tant.... on month 10 or 11 of our 15 month tour in Iraq.

whoo hoo

8-)

 

[Tantroth]

Yup, about to head back over again in a couple months. Just happened to notice you were from here

 

[Ghostyrus]

had alil more help with this 1 then i did with the warrior macro hehe , taking a few more tips and wha not

 

[armysoldier]

well ok ..

here is my tip for you ....

goto loops should not be your primary means of movement in a macro. I am not saying there are not times they need to be used.... but thats all you have here is goto loops

they cause the macro to become bulky, unmanageable and slow.

take your other macro and make a modified version for a paladan / SK and you will be much better off.

that is just my opinion....