Bug - Named mob Burn routine gives no spawns matching error

[DriveCrash]

This has been happening all night when I engage a named spawn -

[2015/07/26 07:39:05] MQ2Melee::Attacking [Carrionmancer Marrowrot].

[2015/07/26 07:39:05] [MQ2] *** Mob#:(Carrionmancer Marrowrot) is a NAMED!

[2015/07/26 07:39:05] [MQ2] BURN ACTIVATED => Autobots Transform <=

[2015/07/26 07:39:06] There are no spawns matching: (0-115) any

[2015/07/26 07:39:10] [MQ2] Casting >> BURN1:Frenzied Burnout

[2015/07/26 07:39:11] There are no spawns matching: (0-115) any

[2015/07/26 07:39:13] [MQ2] Casting >> BURN2:Servant of Ro

[2015/07/26 07:39:14] There are no spawns matching: (0-115) any

[2015/07/26 07:39:19] [MQ2] Casting >> BURN3:Bolt of Molten Dross

It happens on multiple characters with everything from AA to spells. I've tried using |Mob and leaving the switch blank. I can't seem to find the problem in the code either, but I suspect it's like the merc issue with some target ID being returned incorrectly.

 

[Maskoi]

Is this your modified version with the mobradar changes?

 

[DriveCrash]

Stock KA. But it's not a critical thing, because the named mob is targeted already so the spells land. I noticed it while i was trying different camp radius's to get my puller to work better.

 

[Maskoi]

thats weird will look into it.

 

[TreeHuginDruid]

Looking at the burn code now.. cant see a darn thing wrong with it....

| ----------------------------------------------------------------------------
| SUB: Burn Section
| ----------------------------------------------------------------------------
    Sub Event_Burn
        /declare i int local
        /declare BurnSpell string local
        /declare BurnTarget string local
        /declare BurnTargetID int local
        /call BroadCast ${IRCOn} ${EQBCOn} r "BURN ACTIVATED => Autobots Transform <="
        /for i 1 to ${Burn.Size}
            /if (${Burn[${i}].Arg[2,|].Length}) {
                /varset BurnSpell ${Burn[${i}].Arg[1,|]}
                /varset BurnTarget ${Burn[${i}].Arg[2,|]}
            } else {
                /varset BurnSpell ${Burn[${i}]}
            }
            /if (${BurnSpell.Equal[null]} || ${Me.Hovering}) /goto :SkipBurnEntry
                /if (${BurnTarget.Equal[null]} || ${BurnTarget.Equal[Mob]}) /varset BurnTargetID ${MyTargetID}
                /if (${BurnTarget.Equal[Me]}) /varset BurnTargetID ${Me.ID}
                /if (${BurnTarget.Equal[MA]}) /varset BurnTargetID ${Spawn[=${MainAssist}].ID}
                /if (${BurnTarget.Equal[Pet]}) /varset BurnTargetID ${Me.Pet.ID}
                /delay 5
                /call CastWhat "${BurnSpell}" ${BurnTargetID} Burn
                /if (${Macro.Return.Equal[CAST_SUCCESS]}) {
                    /echo Casting >> BURN${i}:${BurnSpell}
                    /delay 5
                }
            :SkipBurnEntry
        /next i
        /doevents flush Event_Burn
    /return

Unless I'm blind.. every condition to set the BurnTargetID is covered.
So the call to castwhat for BurnSpell on BurnTargetID should not be producing that error...

Gotta look at the castwhat sub now.

 

[DriveCrash]

Yeah, I'm confused. Adding the |Mob tag fixes it. But by the code it should catch null value as well.. *mind boggle* Maybe I had a space after the end of the spell name and that returned an value?

Strange. But yeah, you can close this. Sorry for the trouble.

 

[TreeHuginDruid]

Yeah, I'm confused. Adding the |Mob tag fixes it. But by the code it should catch null value as well.. *mind boggle* Maybe I had a space after the end of the spell name and that returned an value?

Strange. But yeah, you can close this. Sorry for the trouble.

It can't be closed yet.. because although specifying the target via filter | method is a valid fix, it should work without any filter and default to the mob as the target in that case... so.. it is an issue as far as we are concerned due to not functioning as intended... still looking at it.

Quick down and dirty fix would be to check the length of arg 2... instead of comparing null... as an opposing method to determine existence.

example:

/if (${BurnTarget.Equal[null]} || ${BurnTarget.Equal[Mob]}) /varset BurnTargetID ${MyTargetID}

to

/if (!${Burn[${i}].Arg[2,|].Length} || ${BurnTarget.Equal[Mob]}) /varset BurnTargetID ${MyTargetID}

If you wanna test that for me... and remove the |MOB for the burn spell in question... i would appreciate it.. but I'll end up testing this as well.... once i debug a named burn cycle.

- - - Updated - - -

CAN YOU PLEASE TEST THAT CHANGE?

 

[DriveCrash]

Sorry, I was out of town for business. Just got back home. I will run tests this morning before work!

EDIT: Error in testing, attempting a clean test.

- - - Updated - - -

That seems to have fixed the problem. I've cycled through 6 named mobs and not seen the spawn not found error. I have another client running a non-modified version of KA (as a control group) and it still gets the spawn error on the same fights.

Tested on two different groups of characters, and it seems to work correctly on both.

 

[TreeHuginDruid]

Yeah.. i tested it several times and confirmed it works b4 i posted it.

Closing ticket.. the code is already in production under 8.3.0 version.