Problem - Mage role PetTank not working?

[eqgeek]

This is working in 8.1.2 but not in 8.1.4. The mage won't assist the puller or even the tank unless you click the mob.

 

[ctaylor22]

Who is setup as the MA?

 

[eqgeek]

Enchanter is MA. I keep kiss paused on her and manually pull to the mage. The mage usually sends pet in (assisting the enchanter's target) as I run back to camp. With 8.1.2 this works great. With 8.1.4 the mage isn't targeting the MAs target. When. I tab to her window she has nothing on target. If I target the mob, she takes over per usual.

- - - Updated - - -

Also I should get a red cent every time I said "target" LOL Hopefully I was clear... Only 2in group. Mage and enchanter. Mage is fully kiss assist as pet tank. Enchanter is fully played 99% of the time.

 

[ctaylor22]

If the Enchanter is on target when you start KA on your mage, then anything that your enchanter targets should be targeted by your mage. I have seen a few time when you get mobs on your xtarget and then fade and the xtarget is cleared then you pull a new mob, the tank/MA doesn't engage the next mob pulled to camp, but that only happens when playing the puller manually. This is kind of the same thing, but in reverse.. Does your mage even have a mob on target?

 

[PussyFoot]

I run into this a lot with my mage. Enough that I have taken to manually using EQBC to //pet attack with the mage. He won't target anything I pull half the time. Just sits there. When I pull multiples? He often jumps right in. Singles? Doesn't bother.

 

[ctaylor22]

PussyFoot or EQGeek, Could either of you run me a log use the DebugCombat flag. Send it to me in a PM please. I am looking at the code, but nothing is jumping out at me.

 

[eqgeek]

I won't be online until Monday but I'd be happy to do that. Let me explain myself a bit better...

My mage will target the enchanter and start up /mac kissassist pettank and say that my pet is tanking and assisting Enchanter.

In version 8.1.2, anything the enchanter has on target, the mage targets also (within the range limit). Even if the enchanter switches targets the mage will switch (before we are in combat). When the enchanter aggros the mob and pulls it within the range of the mage, she sends pet in and goes through the dps routine. If the enchanter switches targets during the fight, the mage stays on the one she's currently dpsing unless I do /switch. All is working as I expect in this case.

In version 8.1.4, the mage is simply not targeting what the enchanter is targeting. Not in range or in combat. I usually test this by putting the mage as MA in group role so I can see when the 3d target ring is on the mob. She just never targets the mob even if it's standing right on top beating on everyone. You have to manually target mob before she sends the pet in and starts the dps routine.

Pussyfoot has had some problems with the mage not pet tanking quite right, but maybe it is possible it is just a version issue?? Also, I've not tested 8.1.3 - if there is one.

8.1.2 works sweet alll day long in high level zones, even on named.

 

[ctaylor22]

I think the issue is in the assist or validatetarget routine, but just need a debug listing. I am leaning towards the validatetarget sub, the Assist sub is straight forward and looks clean. The debug log will be helpful.

 

[Maskoi]

The new hunter pet tank may have caused a bug.

 

[PussyFoot]

I'll see what I can do when I get a chance =/ One of those busy weekends here myself.

 

[ctaylor22]

Not a problem. I am kind of busy myself, but in a good way.

 

[eqgeek]

I sent this over this morning.

 

[TreeHuginDruid]

The new hunter pet tank may have caused a bug.

None of the new coding changes for HunterPetTank role implementation would have effected this. With that.. It was simply a clean definition of hard coded config values for the initial role assignment declarations, and either the inclusion or exclusion of the HunterPetTank role within all exisitng pertinent functions. I did not code any actual new code or alter any existing code to accomodate the new role.

I am starting to lean towards agreeing with Ctaylor22 right now, I'm looking at the validate target fucntion code... and placing aditional debug/trap code in it for testing this.. to pinpoint an display specific information I want to see in regards to this issue.. that we do not normally display/capture during a normal debug.

Gonna do a quick bypas of the validatetarget sub itself in the logical code flow... to isolate it in general from the macro and see what happens with a simple targeting of mobs via MA and see what the mage in petTabk role does. Looking into this now.

 

[eqgeek]

Thanks! The log I sent Ctaylor said I was targeting my pet and assisting... I swear that I targeted the ENC, but to be sure I will be sending him the same info tomorrow when I'm 100% sure. :-)

 

[ctaylor22]

here is the problem.

8.1.2 and 8.1.3 are ok. Here is the code:

| -------------------------------------------------------------------------------------
| Assign Main Tank from command line parameter or targeted player, merc or pet
| -------------------------------------------------------------------------------------
    /if (${Defined[Param0]}) {
        /varset Role ${Param0}
    }
    /if (!${Defined[Param1]}) {
        /if (!${Spawn[${Target}].ID} && ${Select[${Role},tank,pullertank,pullerpettank,pettank,puller,hunter]}) {
            /target id ${Me.ID}
            /delay 10
        }
        /if ((!${Spawn[${Target}].ID} || ${Target.ID}!=${Spawn[${Me.Pet}].ID}) && ${Select[${Role},pullerpettank]}) {
            /target ${Me.Pet}
            /delay 10
        }
        /call AssignMainAssist
    }

Here is the code for 8.1.4

| -------------------------------------------------------------------------------------
| Assign Main Tank from command line parameter or targeted player, merc or pet
| -------------------------------------------------------------------------------------
    /if (${Defined[Param0]}) {
        /varset Role ${Param0}
    }
    /if (!${Defined[Param1]}) {
        /if (!${Spawn[${Target}].ID} && ${Select[${Role},tank,pullertank,puller,hunter]}) {
            /target id ${Me.ID}
            /delay 10
        }
        /if ((!${Spawn[${Target}].ID} || ${Target.ID}!=${Spawn[${Me.Pet}].ID}) && ${Select[${Role},pettank,pullerpettank,hunterpettank]}) {
            /target ${Me.Pet}
            /delay 10
        }
        /call AssignMainAssist
    }

Check out the highlighted lines. Pettank forces you to target your pet. That is the problem.

 

[eqgeek]

Yep, made that change and all is right with the world.

 

[TreeHuginDruid]

Motherless..... i spent the last 12 hours hunting that down.. and was just about to post the solution.. when i see ctaylor beat me to it.

Well... updating source and KA post thread with the fix now.

Production code section updated to:

| -------------------------------------------------------------------------------------
| Assign Main Tank from command line parameter or targeted player, merc or pet
| -------------------------------------------------------------------------------------
    /if (${Defined[Param0]}) {
        /varset Role ${Param0}
    }
    /if (!${Defined[Param1]}) {
        /if (!${Spawn[${Target}].ID} && ${Select[${Role},tank,pettank,pullertank,puller,hunter]}) {
            /target id ${Me.ID}
            /delay 10
        }
        /if ((!${Spawn[${Target}].ID} || ${Target.ID}!=${Spawn[${Me.Pet}].ID}) && ${Select[${Role},pullerpettank,hunterpettank]}) {
            /target ${Me.Pet}
            /delay 10
        }
        /call AssignMainAssist
    }

Releasing fix under 8.1.5 update.