Problem - Macro ending on zone

[kilroy]

Original thread for this problem: http://www.redguides.com/community/showthread.php/28042-Macro-ending

Since commenting on the thread I made a few changes to the INI and at some point it stopped ending the macro on zone. I went back to the old INI settings and it started ending again. I attempted to identify which specific change causes the problem but it seems to be a combination of settings that triggers it. I'm attaching an INI that exhibits the problem (KissAssist_Bad.ini) and one that does not (KissAssist_Good.ini).

Differences between the the files:

BAD:

MedOn=1
RezAcceptOn=0
GroupWatchOn=1
HoTTOn=0

GOOD:

MedOn=0
RezAcceptOn=1
GroupWatchOn=0
HoTTOn=1

I tested this by zoning from the guild hall to the guild lobby several times. With the bad file KissAssist ended every zone and it never ended with the good file. The settings I want to use don't cause the issue so this is just FYI in the event someone else has this problem.

 

[Maskoi]

RezAcceptOn=0 is the issue. change it to =1 for now. I will look at changing that code this week so it doesn't kill the macro from just zoning.

 

[kilroy]

Awesome. And thanks for KissAssist in general. Been using a hand-coded MQ2 script for a while now and this blows it away. You've got a new long-term subscriber!

 

[Maskoi]

Glad you are enjoyingit. One of the reasons I wrote it was so people could have fun again playing Everquest.

 

[TreeHuginDruid]

| ----------------------------------------------------------------------------
| SUB: End Mac If
| ----------------------------------------------------------------------------
    Sub EndMacroIf

        /if (${Debug}) /echo DEBUG EndMacroIf: Enter
        | I died wait for rez loop
        :WaitOnRez
        /if (${GameState.Equal[CHARSELECT]}) /endmac
        /if ((${Me.Hovering} || ${CampZone} != ${Zone.ID}) && ${RezAcceptOn} && ${IAmDead}) {
            /if (${Attacking}) /call CombatReset
            /delay 10
            /if (${ClickBacktoCamp}) /call CampfireBack
            /if (${CampOnDeath}) /call DoICamp
            /goto :WaitOnRez
        }
        /if (!${RezAcceptOn} && ${CampZone} != ${Zone.ID}) {
            /if (${CampOnDeath}) /call DoICamp
            /endmac
        }
        /if (${Debug}) /echo DEBUG EndMacroIf: leave
    /return

Since ${CampZone} (Zone of the ID macro was started in) is no longer eqal to current ${Zone.ID} upon zoning... and ${RezAcceptOn} is set off (0) .. condition true and endmac done.

At current time I will change ticket status to Known Bug, since Maskoi obviously does not want this condition to occur.

Since KissAssist 8.0 beta testing in full swing, I expect the coding change/direction Maskoi wants will be discussed soon.

- - - Updated - - -

Spoke to Maskoi .. we are in agreement.... there needs to eb a check in place to make sure condition also checks that you have just died upon zoning. This will make sure you only end macro if you zoned due to death.. with the RezAccept turned off.

So lines should change from:

        /if (!${RezAcceptOn} && ${CampZone} != ${Zone.ID}) {
            /if (${CampOnDeath}) /call DoICamp
            /endmac
        }

to

        /if (!${RezAcceptOn} && ${Me.Buff[Revival Sickness].ID} && ${CampZone} != ${Zone.ID}) {
            /if (${CampOnDeath}) /call DoICamp
            /endmac
        }

You can make this change manually to kissassist 7.6.7, or wait for 8.0 to be released.

 

[kilroy]

WTB support like this for all my software. You guys rock. Thanks so much!

 

[TreeHuginDruid]

The fix is in ...

Code fix for KA 8.0 release for this matter is in.. and archived.. it will be part of the rollout for 8.0.

In the mean time.. you can manually edit that line as i showed to resolve the issue. I will close this ticket and consider it resolved.. because we have identified the issue.. and it will be resolved in 8.0 release / available for you to fix now.