Bug - KA Buffing, not checking correctly and overcasting

[BigDorf]

Version of KissAssist.mac?

12.002.015

When did your problem start?

This month, following update to address the melee attack problem

Character Role?

1. Assist
2. Tank
3. PullerTank

What class is having this issue?

1. Bard
2. Beastlord
3. Cleric
4. Druid
5. Enchanter
6. Magician
7. Necromancer
8. Paladin
9. Ranger
10. Shadow Knight
11. Shaman
12. Wizard

How often does this issue occur?

Always

Can you reproduce the issue?

Yes.
Have a high level buff. Have KA profile configured with a low level buff that would be blocked normally.

e.g. Have characters in 80-100 range, buffed by ToV / ToL spells, and use their own correct profiles for buffing self and group.
They will step through the KA Buffs list, and try to cast "current" spells. The casts complete but fail to take as they are blocked by the higher spells.
They shouldnt be casting them until there is a requirement to do so. It works as expected in version 12.002.011.

Hello @ctaylor22 and Redguides

I think there has been a bug introduced to KA12, as of version 12.002.013 and still found current in 12.002.015.
Yet, it does not happen in 12.002.011 and earlier.

This is with regards a toon buffing itself and the group.
In particular the decision making that evaluates if casting a buff is a good idea against it being blocked by a superior spell and would not stick.


To be clear, the same KA profiles without amendment work fine for buffing in 12.002.011. Yet they fail in 12.002.013 & 12.002.015, as they repeatidly try to cast the same buff spells and they dont stick.

I have used the KA, /debug buffs on, and believe tracked the problem down to a commented out / change in if statement at line 3966.


By commenting out 3966, and reinstate 3965 of version 12.002.015 the buff activities behaved.

Noting that the key difference between the two is the additional requirement of ${Spell[${SpellToCast}].WillLand} to evaluate true.




Regards and Best Wishes

 

[ctaylor22]

@BigDorf That remarked out line is part of the testing I have been up to since the .Stacks[0] no longer works in MQNext like it did in MQ. If you are willing to do some testing for me, I can send you a copy of the macro that has the new logic for the CheckBuff routine.

 

[BigDorf]

Sure, did some tests with you before and no problem doing some more.


It's important we get the buff element working again.


Accepting it doesn't really impact boxers much running KA toons in ToL, levels 116-120.
The impact is to those much lower, who are perhaps getting buffed initially with ToV-CoV-ToL buffs and then hunting.
Or any of the PL buffing that goes on for that matter.