Help with a (supposedly) basic Shammy macro

[Borys212]

I copied this code from another macro. This subroutine is supposed to cycle through the group, check their class, and if they're a melee cast Spritit of the Puma on them. The code is entering the loop when called, but its not doing anything else. It just returns to the sub that called it.

Any thoughts on why this isn't working?

Thanks so much.

/declare MyMob int local 
/varset MyMob ${Target.ID} 
/declare x int local
/for x 1 to {Group.Members}
      /if (${Group.Member[${i}].ID}) {
	/if (${Select[${Group.Member[${i}].Class.ShortName},WAR,MNK,ROG,RNG,BST,SHD,PAL,BER,BRD]}) {
 	     /squelch /target id ${Spawn[${Group.Member[${i}]}].ID}
	     /delay 5 ${Target.ID}==${Spawn[${Group.Member[${i}]}].ID}
	     /call cast "${Me.Gem[4]}"
	}
      }
/next x
/target id ${MyMob} 
/return

 

[Alatyami]

You're missing a dollar sign.

/for x 1 to {Group.Members}

/for x 1 to ${Group.Members}

 

[Borys212]

Thanks so much for replying Alatyami. It's always the most obvious mistakes...

I plugged this in expecting everything to do fine, but it still won't target the group members. I think it has something to do with the way that character names have changed for the spam flagging. Right now I'm doing it the heard way and hard-coded the names of the group members with whom I group regularly plus mercs, so I cycle through and hit them, but it does seem like such a waste.

If anyone else has this problem and has a fix, please let me know. It would be nice to know that my buffs get spread out the way they ought to without having to tab back and forth between toons.

 

[Maskoi]

Ummmm

you declared x but have ${i} as your variable so nothing is looping. Change the x to i

/declare x int local
/for x

/declare MyMob int local 
/varset MyMob ${Target.ID} 
/declare i int local
/for i 1 to ${Group.Members}
      /if (${Group.Member[${i}].ID}) {
	/if (${Select[${Group.Member[${i}].Class.ShortName},WAR,MNK,ROG,RNG,BST,SHD,PAL,BER,BRD]}) {
 	     /squelch /target id ${Spawn[${Group.Member[${i}]}].ID}
	     /delay 5 ${Target.ID}==${Spawn[${Group.Member[${i}]}].ID}
	     /call cast "${Me.Gem[4]}"
	}
      }
/next i
/target id ${MyMob} 

/return