Bug - Corpse target with Heals1=Lifedraw|80|Tap

[LamahHerder]

Low level necro will keep trying to lifetap corpse

Heals1=Lifedraw|80|Tap

- - - Updated - - -

Added an npc check to the Tap check around line 2883
Working so far...

       | Check For Life Taps
            /if (${SHealTag.Find[Tap]}) {
                /if (!${Pulled} && ${CombatStart} && ${Me.PctHPs}<=${SHealPct} && ${Spawn[${MyTargetID}].ID} && ${Spawn[${MyTargetID}].Distance}<=${SHealRange} && ${Target.Type.Equal[NPC]} && ${Spell${i}GM0}==0) {
                    /call CastWhat "${SHealSpell}" ${Spawn[${MyTargetID}].ID} Heal
                    /if (${Macro.Return.Equal[CAST_SUCCESS]}) {
                        /call BroadCast ${IRCOn} ${EQBCOn} o "${SHealSpell} for  >> ${Me.CleanName} <<"
                        /varcalc Spell${i}GM0 (${Spell[${SHealSpell}].Duration.TotalSeconds}*${DurationMod})*10
                        /if (${DebugHeal}) /echo DEBUGHEALS SingleHeal Assign Timer:Spell${i}GM0 (${Spell[${SHealSpell}].Duration.TotalSeconds}*${DurationMod}) ${Spell${i}GM0}
                        /return
                    }
                } else {
                    /goto :SNextHeal
                }

 

[TreeHuginDruid]

If you wanted to ensure it is not trying to tap a corpse... putting in a check for NPC isn't the way to go... since you are excluding the target type of PET.

I would suggest:

/if (!${Pulled} && ${CombatStart} && ${Me.PctHPs}<=${SHealPct} && ${Spawn[${MyTargetID}].ID} && ${Spawn[${MyTargetID}].Distance}<=${SHealRange} && ${Target.Type.NotEqual[corpse]} && ${Spell${i}GM0}==0) {

First I've heard of this tap loop happening on a corpse... but if it is reported again... this is most likely the solution I would be putting in place for the oficial code release update.

Ticket being closed.