Bug - Characters not buffing themselves

[kontraband]

All my characters running KissAssist 9.1.3 will only buff the other group members and never themselves. For example Buffs1=Spirit of Wolf will buff every member of the group but not the class casting the spell. Also using the |Me tag will never cast on themselves.

I have experienced this issue since installing 9.1.3 and couldn't find another topic with anyone else having the issue by searching the forums. Not sure if this is a operator issue or not.
Even though I experience these issues with my set up INI for all characters for the sake of debugging I have reinstalled MQ from fresh and updated as following instructions in getting started and I created a fresh new INI file with only modifications to Buffs ON and Spirit of Wolf added to buff slot. I have KissAssist running on both characters in the group: Character1 the MA and Character2 the buffer and have renamed the character names in the debugger and INI accordingly.

I have attached my buff casting class INI, a copy of my unmodified KissAssist.mac as well as a snippet of the debug log.
In the debug log all the text before and after the actual cast of the spell is repeated on a loop, I cut out the top and bottom parts for the sake of readability but can supply the whole unedited log if needed.

Please advice with any changes I need to make or if I can assist you with any more information.

Thanks,

Versions:
KissAssist 9.1.3
MQ2Cast_Spell_Routines.inc v3.03
Ninjaadvloot.inc 6.0

- - - Updated - - -

Also as a note, I have tried deleting the buffs.ini as well as ensured that both characters showed up in there. Its writing the buffs from the buffing class (any that I cast manually, or any I receive from another character)

- - - Updated - - -

After hours of debugging and writing my own debug code I think I found the issue:

In KissAssist.mac under the CheckIniBuffs sub

lines:
LINE# 2724 | If the Spawn ID is not in the zone and not a PC/merc and not me skip to next ID
LINE# 2725 /if (!${Spawn[${IniIDList.Arg[${k},|]}].ID} || ${Select[${Spawn[${IniIDList.Arg[${k},|]}].Type},AURA,BANNER,CAMPFIRE,CORPSE,CHEST,ITEM,NPC,TRIGGER,TRAP,TIMER,MOUNT]} || ${IniIDList.Arg[${k},|]}==${Me.ID}) /goto :NextCharCheck


removing Line #2725 completely fixes the issue. The comment for the code uses AND logic, but the if statement is OR. Could be that?



Thoughts?

 

[ctaylor22]

There may be an issue in the normal buff routine. Single/self buffs are checked and cast in the normal buff routine. The ini section is more for checking anyone other than yourself to see if they need buffs/rebuffed. I am not sure why you are having issues. I have plenty of my characters casting single buffs on the group as well as themselves. I will try and take a closer look using my shaman and cast single target SOW on the group and see what happens. Maybe someone can try and confirm this as an issue, because I won't be able to look at this until later tomorrow.

 

[Gator]

This might be related to the issue with my enchanter buff in this thread:

http://www.redguides.com/community/showthread.php/46623-Lack-of-Enchanter-knowledge

 

[kontraband]

There may be an issue in the normal buff routine. Single/self buffs are checked and cast in the normal buff routine. The ini section is more for checking anyone other than yourself to see if they need buffs/rebuffed. I am not sure why you are having issues. I have plenty of my characters casting single buffs on the group as well as themselves. I will try and take a closer look using my shaman and cast single target SOW on the group and see what happens. Maybe someone can try and confirm this as an issue, because I won't be able to look at this until later tomorrow.

This was my initial thoughts. To diagnose the problem I ended up adding an /echo DEBUGCAST n where n is a int from 1 to infinity next to each 'CastWhat' call in the check buff routines. This let me identify in the mlog which CastWhat was being called at which time. What I learned from this was that 'CastWhat' when buffing any single target buffs was never being called from this routine and only from CheckIni. CheckIni was skipping the self cast due to the clauses '${IniIDList.Arg[${k},|]}==${Me.ID}' which says if the Id is not Me then check next character.

What I don't know is if the CheckIni is only intended to buff the other party members and if self buffing is suppose to be handled through CheckBuffs or not. Removing Line #2724 is at least a work around for me and after a few hours of testing last night doesnt seem to have any negative effects. I assume that I would run into issues with my characters not being in the same zone but as of now thats something I can live with until I can figure out a more permanent fix.

-Thanks

 

[ctaylor22]

Found the problem. The problem is around line 2441

Change this:

                /if ((${BookSpellTT.Find[0]} && ${Spell[${Buffs[${i}]}].TargetType.Find[single]}) || ${BookSpellTT.Find[single]} && (!${Medding} && ${MedCombat})) {

Too This:

                /if ((${BookSpellTT.Find[0]} && ${Spell[${Buffs[${i}]}].TargetType.Find[single]}) || ${BookSpellTT.Find[single]}) {

 

[kontraband]

I'll make the changes and try this when I get home today. Thank you for the support!