Can someone help me condense this buff Sub? (1 Viewer)

[nijhal]

Ok as I always say, I am still learning, how can I condense this buff sub?

|--------------------------------------------------
|Buffs the party
|--------------------------------------------------
Sub event_Buffs
/popup ReBuffing Group!!!
/delay 1s
/keypress F1
/delay 1s
/aa act breath of wind
/delay 9s
/Keypress F2
/delay 1s
/call GMCheck
/warp target
/delay 1s
/aa act breath of wind
/delay 5s
/call GMCheck
/warp target
/delay 1s
/aa act Swift Like the Wind
/delay 9s
/doevents
/Keypress F3
/delay 1s
/call GMCheck
/warp target
/delay 1s
/aa act breath of wind
/delay 5s
/call GMCheck
/warp target
/delay 1s
/aa act Swift Like the Wind
/delay 9s
/doevents
/Keypress F4
/delay 1s
/call GMCheck
/warp target
/delay 1s
/aa act breath of wind
/delay 5s
/call GMCheck
/warp target
/delay 1s
/aa act Swift Like the Wind
/delay 9s
/doevents
/Keypress F5
/delay 1s
/call GMCheck
/warp target
/delay 1s
/aa act breath of wind
/delay 5s
/call GMCheck
/warp target
/delay 1s
/aa act Swift Like the Wind
/delay 9s
/doevents
/Keypress F6
/delay 1s
/call GMCheck
/warp target
/delay 1s
/aa act breath of wind
/delay 5s
/call GMCheck
/warp target
/delay 1s
/aa act Swift Like the Wind
/delay 9s
/doevents
/return

I know it has something to do with /next i but I cant remember how.

N

 

[forsakenshadow]

10 times you checked for a gm in that sub? To each their own but my shambot will buff up the group then just go back to the main loop where it calls for gmchecks as a part of a cycle. Your just adding in a lot of checks that aren't going to do much, after all, you are just buffing...i have run my SK's self buff sub right infront of a gm no probs.

At any rate, maybe just set it up to buff once starting with you and then just rebuff group as they wear off of you, that way your not doing them all at once.

If your going to keep that flow, how about something more like:

/keypress f1
/call buff
/keypress f2
/call buff
/keypress f3
yada yada

then just have buff be a second sub that buffs up that toon with all the buffs you want in one shot then change toon, of if you don't like another sub have it go into a loop and back out.

Something like this:

Sub event_Buffs
/popup ReBuffing Group!!!
/delay 1s
/keypress F1
/call buffage
/keypress F2
/call buffage
/keypress F3
/call buffage
/keypress F4
/call buffage
/keypress F5
/call buffage
/keypress F6
/call buffage
/return

Sub buffage
/aa act breath of wind
/delay 9s
/insert any other buffs ya want here
/return

Not the prettest thing in the world but then if you want pretty I'd look at shambot or some other bot mac from the vip forums

 

[nijhal]

All of the GMChecks are me being paranoid, I do one before every warp.

All this because some GM came to talk to me the other night while I was running the final testing on my BBMM macro and suspended all 6 of my accounts for a week, cause they were warping.

Funnny thing is after awhile all the macros turned off cause of the GM being in my instance, but because of the MQ2nosummon plugin everytime he tried to summon one of my toons they bounced back. Lol imagine that.

N

 

[nyghteyes]

lmao...

sorry just imagining what the GM was saying to himself as he tried summoning your chars... way to graphical to post

 

[HardOne]

Here is something Taken from the macro I run, it will buff each group member with the buffs inputed into the sub. Requires spell_routines.inc to function properly.

It targets each group member, makes sure their within 150 range, and cast a spell on them, if their OOR it tells you, if their not in zone it tells you. It will also buff pets for all classes (except wizard familiars).

I modified it from the version thats in my macro, and havent tested it, but it should work just fine.

Sub Event_BuffGroup
	/declare i int local 0
	
	/for i 0 to 5
		/if (${Spawn[pc ${Group.Member[${i}].Name}].ID}) {
			/if (${Group.Member[${i}].Distance} < 150) {
				/echo Buffing ${Group.Member[${i}].Name} (${Group.Member[${i}].Class.ShortName})
				/target pc ${Group.Member[${i}].Name}
				/call Cast "Swift like the Wind" gem8
				/docommand /aa act Breath of Wind
				/delay 3s
			} else {
				/echo ${Group.Member[${i}].Name} (${Group.Member[${i}].Class.ShortName}) is OOR, ${Group.Member[${i}].Distance} distance
		}
			} else {
				/echo ${Group.Member[${i}].Name} (${Group.Member[${i}].Class.ShortName}) not in zone
			}
		}
		/if (${Group.Member[${i}].Class.Name.NotEqual["Wizard"]} && ${Group.Member[${i}].Pet.ID} && ${Group.Member[${i}].Pet.Level} > 28) {
			/if (${Group.Member[${i}].Pet.Distance} < 150) {
				/echo Buffing ${Group.Member[${i}].Pet.CleanName} (${Group.Member[${i}].Name}'s pet)
				/target pet ${Group.Member[${i}].Pet.Name}
				/call Cast "Swift like the Wind" gem8
				/docommand /aa act Breath of Wind
				/delay 3s
			}
		}
		/next i
			/echo Done Buffing Group & Pets.
		}
	}