Problem - Bug: Spells & Abilities with Same Name

[drwhomphd]

Version of KissAssist.mac?

11.005

When did your problem start?

10/19/2019

Character Role?

1. Assist

What class is having this issue?

1. Beastlord

How often does this issue occur?

Always

Can you reproduce the issue?

Yes. As a Beastlord add Frenzy, the spell, to your ini and attempt to add it to a buff rotation.

This morning I found a bug while playing my Beastlord.
=
Upon adding Frenzy, the SHM/BST spell to my BST ini under the Buffs section:

Buff01=Frenzy

I regularly received a message saying, "you don't have that skill" in the MQ2 window. On Discord we traced the problem down to the order of operations in which KissAssist determines to use abilities or spells. Even though my Beastlord does not have Frenzy the BEZ ability, Kissassist was trying to use it.

@kaen01 suggested a solution as follows that worked:
### Bug With Frenzy
~ Line 2752
/varset ReadyToCast ${Select[TRUE,${Me.ItemReady[=${castWhat}]},${Me.AltAbilityReady[${castWhat}]},${Me.CombatAbilityReady[${castWhat}]},${If[${Me.AbilityReady[${castWhat}]} && ${Skill[${castWhat}].SkillCap}>0,TRUE,FALSE]},${Me.SpellReady[${castWhat}]},${Bool[${castWhat.Find[command:]}]}]}

Most likely this corner case will effect any chance where a spell has the same name as an ability.

 

[ctaylor22]

Hmm, I am trying to do some testing on this. According to MQ2 a Monk has the Frenzy Ability/Skill. Even though it doesn't show up in her Skill list. Looking at what is posted above should work, but would be better if MQ2 just returned FASLE for ${Me.AbilityReady[Frenzy]} on classes who do NOT have that Skill in their Skill List. I am going to Tag @Redbot and let him decide on who should be made aware of this issue.

 

[Sic]

Hmm, I am trying to do some testing on this. According to MQ2 a Monk has the Frenzy Ability/Skill. Even though it doesn't show up in her Skill list. Looking at what is posted above should work, but would be better if MQ2 just returned FASLE for ${Me.AbilityReady[Frenzy]} on classes who do NOT have that Skill in their Skill List. I am going to Tag @Redbot and let him decide on who should be made aware of this issue.

as I was explaining yesterday - everyone has those baseline abilities - it is just a matter if they have a 0 for their skill in that skill and can actually use it or not --- these are the abilities that everquest thinks toons have - you can check each of those (like you can /echo ${Me.Ability[Round Kick]} on a mage and get a 38 returned (I'm assuming 38 is the eq ability id)). It appears to be any abilities that have modifiers - so Bash (10), Backstab (8), etc

Pretty funny to echo ${Me.AbilityReady[Backstab]} on a mage and get a true, however

 

[ctaylor22]

OK after doing a little more testing, I would make a slight change to the Select statement above.

I would change it to this:
${Select[TRUE,${Me.ItemReady[=${castWhat}]},${Me.AltAbilityReady[${castWhat}]},${Me.CombatAbilityReady[${castWhat}]},${If[${Me.AbilityReady[${castWhat}]} && ${Me.Skill[${castWhat}]}>0,TRUE,FALSE]},${Me.SpellReady[${castWhat}]},${Bool[${castWhat.Find[command:]}]}]}

Me.Skill[Some Skill] returns 0 if you can't use the skill and a value if you can use it.

 

[ctaylor22]

Give this a try and let me know if you get the results you are looking for.

 

[drwhomphd]

Give this a try and let me know if you get the results you are looking for.

I'll try it out this afternoon when I get a chance to play and report back!

UPDATE: @ctaylor22 -- Tried out your updated script and it is buffing Frenzy appropriately!