Question - Boastful Conclusion

[Bolbod]

I ran this Lua today for my bard as a way to get away from having to constantly update my KA INI file, and while the way the songs are organized on the gems isn't the way I like, almost everything I want is there (i'm still fussing with the config window, so thats not my issue). While I was running the program, I noticed that Boastful Bellow is recasting at around 4s left on its effect timer (which is chopping off the Boastful Conclusion effect when the effect expires on the target). I have been reading like mad through everything associated with this fantastic piece of work trying to see if you guys had answered the question before I type this out, and found nothing. Is there a way to change the recast of bellow to accomodate (not as accurate because there is a rather large window of time that the skill registers in the log files), or to add a condition check for the expiration of bellow to allow for recast?
In KA, I have the skill set to be cast once, and then downloaded Lua Event Manager and set a condition check that recasts boastful bellow after it expires (saves a BUNCH on end, plus you get the full effect of the skill every single cast).

 

[Derple]

If you look in the brd_class_config.Lua you will find this

            {
                name = "InsultSong",
                type = "Song",
                cond = function(self, songSpell)
                    return RGMercUtils.SongMemed(songSpell) and RGMercUtils.GetSetting('UseInsult')
                        and mq.TLO.Me.SpellReady(self.ResolvedActionMap['InsultSong'] or "")()
                        -- If dot is about to wear off, recast
                        and getDetSongDuration(songSpell) <= 4
                        and mq.TLO.Me.PctMana() > 20
                end,
            },

So it recasts it when the duration is under 4 seconds.

 

[Bolbod]

I was actually looking at this skill. I was hoping for some kind of line of code that could create a check for Boastful Bellow wearing off before recasting I have been using it all day, and the only other thing I have noticed is that the program will not send in my bard when it hits 20% end (my threshold I set for meditate, which I set for in combat, and then reset it back to out of combat), but it also won't sit him down to med up. I wonder if I am missing a setting in the configuration screan maybe?

 

[Derple]

You can check

not RGMercUtils.SongActiveByName("Group Bestial Alignment")

 

[Bolbod]

awesome, I threw that into the blurb I screenshotted and changed the GBA line to Boastful Bellow, I'll give it a run and see if it pans out The program loaded after the add of the line, so I am pretty hopeful

UPDATE: that worked flawlessly. the skill wore off the target, and the program recast after that!

 

[Derple]

it iwll get overwritten by the next patch if you don't submit a PR or put it in your config directory as an override. I recommend you push a pr for this or send the the whole spell section so I can push it in if this is desired behavior for everyone.