test macro, will this work? (1 Viewer)

[nijhal]

What changes are necessary to make this work?

#turbo 40

Sub Main (string outer attacktype)
/declare StartZone           int outer ${Zone.ID}
:loop
  /if (${Zone.ID}!=${StartZone}) /call Done
    /if (!${Target.ID}) { 
        /target npc
    }
/call Combat
/goto :loop

Sub Combat
          	   /squelch /${attacktype}s
                /delay 0
                /squelch /${attacktype}n
                /delay 0
                /squelch /${attacktype}e
                /delay 0
                /squelch /${attacktype}w
                /delay 0
/return

Sub Done
  /echo Not in starting zone, camping and ending macro...
  /echo You have 15 seconds to abort...
  /delay 15s
  /gate
  /delay 90s
  /camp desktop
/end

mainly i am concerned with the attacktype

 

[Ccomp5950]

#turbo 40
Sub Main (string paramA)
/declare string outer attacktype ${paramA}
/declare StartZone           int outer ${Zone.ID}
:loop
  /if (${Zone.ID}!=${StartZone}) /call Done
    /if (!${Target.ID}) { 
        /target npc
    }
/call Combat
/goto :loop

Sub Combat
          	/squelch /docommand /${attacktype}s
                /delay 0
                /squelch /docommand /${attacktype}n
                /delay 0
                /squelch /docommand /${attacktype}e
                /delay 0
                /squelch /docommand /${attacktype}w
                /delay 0
/return

Sub Done
  /echo Not in starting zone, camping and ending macro...
  /echo You have 15 seconds to abort...
  /delay 15s
  /gate
  /delay 90s
  /camp desktop
/end

 

[RedQuest]

That's a bad way of doing it. If the macro is being restarted, it won't get changed. Do this:

Take out the stuff from the main sub, you don't need to do that, since you're just declaring another variable anyways.

Sub Main
/if (!${Defined[attacktype]}) /declare string outer attacktype
/varset attacktype ${Param0}