Help with macro (1 Viewer)

[Martin66]

|hitallmobs.mac By: Harden 07/08/06
|-------------------------------------------------------------------
|Description: Hit's all mobs within 50 range of you with a specified 
|ability. Keep's count of how many mobs were hit, and reports when 
|done. (Requires spell_routines.inc)
--------------------------------------------------------------------
|-Useage: /hitallmobs
|=================================================  ==================
#include spell_routines.inc

Sub Main
/squelch /alias /hitallmobs /echo hitallmobs
	:loop
		/doevents
	/goto :loop
/return

#Event HitAllMobs        "[MQ2] HitAllMobs"
Sub Event_HitAllMobs
|=========================================|
|==Edit Throw Stone, for your AA ability==|
|=========================================|
	/declare ABILITY_NAME string local Throw Stone
	/echo *Attempting to hit all mobs in Range with ${ABILITY_NAME}.	
	/if (!${SpawnCount[npc radius 50]}) {
	/echo No Mobs in Range, Aborting...
	/return
}	
	/target npc
	/declare i int local 0
	/declare cnt int local 0	
		/for i 1 to ${SpawnCount[npc radius 50]} {
			:loop	
				/if (${Me.AltAbilityReady[${ABILITY_NAME}]} && ${Target.LineOfSight}) {
					/face
					/delay 1s
					/aa act ${ABILITY_NAME}
					/delay 3s
				} else {
				/if (!${Me.AltAbilityReady[${ABILITY_NAME}]}) }{
					/goto :loop
				} else {
				/if (!${Target.LineOfSight}) }{
					/echo ${Target.CleanName} Not in Line of sight, Skipping...
					/next i
						}
					}
				}
			/varcalc cnt ${cnt}+1
			/target npc next radius 50
		/next i
	/echo *Done Hitting mobs all mobs in range.
	/echo *Total of ${cnt} Mob(s) hit.
/return

Cant get this macro to work, /mac hitallmobs /hitallmobs any ideas?

 

[Timbuktu]

Well, looks to me like if a mob isn't in line of sight, it jumps to the next i, but doesn't target the next mob. So since it's the same target, it's just going to check it again and it's likely to still be out of sight.

Second, shouldn't Throw Stone in the declare be in quotes? That's always been a sticky thing for me.

Other than that, what the heck isn't working about it for ya? You do /mac hitallmobs to start it, then it waits for you to hit a hotkey with /echo HitAllMobs on it... that triggers it to start hitting them.

Good luck.

 

[Acigaretteandsex]

Nice doin some pl'n eh?