Bard heal mac addition (1 Viewer)

[letmein]

Was wondering if anyone had any idea how to code the following.

I currently Include Wind of Marr in my /twist when I play to counter act the maulings I get. Problem is, when I'm at 100% health, I'm losing valuable DPS because I keep recasting Marr.

What would I have to include in my macro to only cast Marr when Below 90% health?

And would it mess up my /twist? Or just include it as part of the twist or what?

Thanks again!

 

[Ted]

(add this at the end of your delcares in the macro)

/declare turnedon outer FALSE

(add this somewhere in the main loop)

/call CheckHPs

(add this to the end)

Sub CheckHPs
  /if (${Me.PctHPs}<90 && !${turnedon}) {
    /twist <gem> <gem> <gem> <gem> <gem>
    /varset turnedon TRUE
  } else {
    /if (${turnedon}) {
      /twist <gem> <gem> <gem> <gem>
      /varset turnedon FALSE
    }
  }
/return

Put each peice where it says in the macro. Replace <gem> with the corresponding #'s of your song gems you are using. The extra variable is there to check and see if /twist has switched so it doesn't constantly reset your twist when the sub is called. This isn't tested and I'm well known for leaving out brackets and ( all the time It should work though.

**EDIT**
Already had to fix a bug :mad:
Also make sure there isn't already a Sub named CheckHPs if there is rename the one here to something else and make sure to change the /call CheckHPs to whatever you renamed Sub CheckHPs to.

 

[letmein]

Ted...

I'm at work ATM, but can't wait to try this out. I'll post my finished macro if all works as intended.

Thanks again!

 

[letmein]

Does not work. Anyone else?

I got the following error

/varset failed, variable 'turnedon' not found

macname.mac@39(checkhps):/varset turnedon true
macname.mac@15(main):/call checkhps

 

[Cade]

Did you /declare it like he said?

 

[letmein]

Yes.



#turbo
#Event Zoned "#*#You have entered#*#"


Sub Main
/declare turnedon FALSE


:loopstart
/doevents
/call GMcheck
/call CheckHPs
/if (${Target.Level}>67) /tar npc next
/if (${Target.Distance}>220) /keypress esc
/if (${Target.ID}==FALSE) /tar NPC radius 220
/delay 10
/goto :loopstart
/return

Sub GMcheck
/if (${Spawn[gm].ID}) {
/echo Gm detected
/beep
/beep
/beep
/keypress 9
/endmac
/unload
/q
}
/return

Sub CheckHPs
/if (${Me.PctHPs}<90 && !${turnedon}) {
/twist 1 2 3 4 5
/varset turnedon TRUE
} else {
/if (${turnedon}) {
/twist 1 2 3 4 5 6
/varset turnedon FALSE
}
}
/return

Sub event_camp
/sit
/camp desk
/return

sub event_zoned
/delay 5s
/sit
/camp desk
/endmac
/return

 

[Ted]

whoops that's my bad im pretty sure.

/declare turnedon outer FALSE

>< change the declare and you should be good to go. Edited in reply above as well.

 

[letmein]

This fixed it to some extent.

No errors anymore. However when I am below 90% health all it does it tries to twist 1 2 3 4 5 6, (the twist with regen like it is supposed to) and the twist 1 2 3 4 5 back and forth back and forth over and over in a loop. It is not even casting Selo's once, it is switching back between the two over and over and over again.

It needs to just play 6 <regen> as /twist 1 2 3 4 5 6 until I am above 90% health again then switch back to doing just DPS /twist 1 2 3 4 5

Almost there...

 

[Ted]

Sub CheckHPs
  /if (${Me.PctHPs}<90 && !${turnedon}) {
    /twist <gem> <gem> <gem> <gem> <gem>
    /varset turnedon TRUE
  } else {
    /if (${turnedon} && ${Me.PctHPs}>90) {
      /twist <gem> <gem> <gem> <gem>
      /varset turnedon FALSE
    }
  }
/return

Give this a try. Added a HP check to the else so it shouldn't switch it back unless the twist has change AND you are over 90%

 

[letmein]

Perfect Ted.

Thank you