How to add additional abilities to fish macro (1 Viewer)

[hoosierbilly]

I am wondering if it is possible to add more doability commends to this macro. The macro works great as it is written, but i would like my my bard and monk to also sneak and/or sense traps at the same time. I suspect I can just add the command /doability sneak under the /doability fish command. Is that correct? or will it cause problems?

I do not know very much about programming and only use very basic macro's and plugin's, mostly to avoid pressing the same key over and over a few hundred times. I rarely leave the computer for very long while macro's are running. I just don't want to mess up what is working good for me.

The macro code follows (hopefully in the box like it's suppose to), hehe.

|*******************************************************************|
| - YodaFish.mac -                                                 *|
| - By: Yoda                                                       *|
| - v2.0 by DKAA                                                   *|
|                                                                  *|
| Usage:                                                           *|
| To Fish and Gate if anything attacks you.                        *|
| Will Sit and camp out when you run out of bait.                  *|
| To be used with a Fisherman's Companion.                         *|
|                                                                  *|
|*******************************************************************|

#turbo

#event BrokenPole "#*#You can't fish without a fishing pole, go buy one.#*#"
#event NoBait "#*#You can't fish without fishing bait, go buy some.#*#"

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability Fishing
        /delay 65 
        /doevents

        /if (!${Cursor.ID}) /goto :Fish

        /if (${Cursor.Name.Equal[Tattered Cloth Sandal]}) {
            /destroy
            /delay 1s
        } else {
            /if (${Cursor.Name.Equal[Rusty Dagger]}) {
                /destroy
                /delay 1s
            } else {
                /call KeepItem
            }
      }
   /goto :Fish
/return

Sub KeepItem
   /if (${Cursor.Name.NotEqual[Fish Scales]}) /echo Caught ${Cursor.Name}
   /notify InventoryWindow IW_CharacterView leftmouseup
/return

Sub CheckPole
   /if (${Me.Inventory[mainhand].Name.Find[Fishing Pole]}) /return
   /echo  You need to put your fishing pole in your primary hand.
   /endm
/return

Sub Event_BrokenPole
   /endmacro
/return

Sub Event_NoBait
   /endmacro
/return

I think this part :

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability Fishing
        /delay 65 
        /doevents

Could be changed like this:

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability Fishing
        /doability sneak
        /doability "sense traps"
        /doability hide
        /delay 65 
        /doevents

Am I correct?

I am also interested in a simple macro that will allow me to perform any ability such as lock pick, hide, sneak.... Just want it to activate the command for me is all really.

Thanks for taking the time to post an answer

 

[zxcvbb]

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability Fishing
        /doability sneak
        /doability "sense traps"
        /doability hide
        /delay 65 
        /doevents

I think it need to look like

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability "Fishing"
        /doability "sneak"
        /doability "sense traps"
        /doability "hide"
        /delay 65 
        /doevents

i Think this would work <<<<<<<i'm not that good yet trying to learn still>>>>>>>>>>>

#turbo

#event BrokenPole "#*#You can't fish without a fishing pole, go buy one.#*#"
#event NoBait "#*#You can't fish without fishing bait, go buy some.#*#"

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability Fishing
	/call sneak
	/call hide
	/call sense 
        /delay 65 
        /doevents

        /if (!${Cursor.ID}) /goto :Fish

        /if (${Cursor.Name.Equal[Tattered Cloth Sandal]}) {
            /destroy
            /delay 1s
        } else {
            /if (${Cursor.Name.Equal[Rusty Dagger]}) {
                /destroy
                /delay 1s
            } else {
                /call KeepItem
            }
      }
   /goto :Fish
/return

Sub Sneak
	/if (${Me.AbilityReady["Sneak"]) /doability "Sneak"
 /return

sub hide
	/if (${Me.AbilityReady["Hide"]) /doability "Hide"
 /return

Sub sense
	/if (${Me.AbilityReady["sense traps"]) /doability "sense traps"
 /return



Sub KeepItem
   /if (${Cursor.Name.NotEqual[Fish Scales]}) /echo Caught ${Cursor.Name}
   /notify InventoryWindow IW_CharacterView leftmouseup
/return

Sub CheckPole
   /if (${Me.Inventory[mainhand].Name.Find[Fishing Pole]}) /return
   /echo  You need to put your fishing pole in your primary hand.
   /endmacro
/return

Sub Event_BrokenPole
   /endmacro
/return

Sub Event_NoBait
   /endmacro
/return

 

[Nightmare327]

The last one wouldn't work, as the /call is a call to a subroutine. the one before it should work, may just want to throw some pauses between each doability, to give them time to activate.

 

[thez]

You can just put the /if's that you are calling in the main sub. Calling them is just superfluous code.

 

[rawwar]

Just a point and someone who knows more can comment and if wrong I will remove ... the only time you need it in quotes is when the phrase has a space in it example: "sense traps" must be in quotes becuse of the space sneak does not because there are no spaces.

I know this is true of the bardswap.ini when you have spacing...

I think it need to look like

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability "Fishing"
        /doability "sneak"
        /doability "sense traps"
        /doability "hide"
        /delay 65 
        /doevents

 

[hoosierbilly]

You can just put the /if's that you are calling in the main sub. Calling them is just superfluous code.

Do I NEED to have the /if statements? Will it work with just the /doability commands or will it crash if I don't actually have the ability?

Also is the /delay commends tenths of a second, I'm guessing that they are?

Again I know almost nothing about programming or writting macros, I can always expirment but would rather make sure I'm not doing anything that could cause problems.

Thank you very much for teh time to answer.

Is this an acceptable modification?

This:

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability Fishing
        /delay 65 
        /doevents

Could be changed like this:

Sub Main
    /cleanup
    :Fish
        /call CheckPole 
        /doability Fishing
        /delay 15
        /doability sneak
        /delay 15
        /doability "sense traps"
        /delay 15
        /doability hide
        /delay 20
        /doevents